[PATCH 15/20] tools build: Move tabs to spaces where suitable
From: Jiri OlsaWe've been hit several times by a Makefile bug where line indented by tab was falsely considered as target command. We prevent this by always using space indentation for everything except for the target commands. Signed-off-by: Jiri Olsa Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1480884178-8072-3-git-send-email-jo...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/build/Build.include| 12 ++-- tools/build/Makefile.feature | 138 +-- tools/build/feature/Makefile | 102 3 files changed, 126 insertions(+), 126 deletions(-) diff --git a/tools/build/Build.include b/tools/build/Build.include index 475152c52871..418871d02ebf 100644 --- a/tools/build/Build.include +++ b/tools/build/Build.include @@ -72,15 +72,15 @@ dep-cmd = $(if $(wildcard $(fixdep)), # target, or command line has changed and update # dependencies in the cmd file if_changed_dep = $(if $(strip $(any-prereq) $(arg-check)), \ - @set -e; \ - $(echo-cmd) $(cmd_$(1)) && $(dep-cmd)) + @set -e; \ + $(echo-cmd) $(cmd_$(1)) && $(dep-cmd)) # if_changed - execute command if any prerequisite is newer than # target, or command line has changed -if_changed = $(if $(strip $(any-prereq) $(arg-check)), \ - @set -e; \ - $(echo-cmd) $(cmd_$(1)); \ - printf '%s\n' 'cmd_$@ := $(make-cmd)' > $(dot-target).cmd) +if_changed = $(if $(strip $(any-prereq) $(arg-check)), \ + @set -e; \ + $(echo-cmd) $(cmd_$(1)); \ + printf '%s\n' 'cmd_$@ := $(make-cmd)' > $(dot-target).cmd) ### # C flags to be used in rule definitions, includes: diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature index ae52e029dd22..e3fb5ecbdcb6 100644 --- a/tools/build/Makefile.feature +++ b/tools/build/Makefile.feature @@ -27,58 +27,58 @@ endef # the rule that uses them - an example for that is the 'bionic' # feature check. ] # -FEATURE_TESTS_BASIC := \ - backtrace \ - dwarf \ - dwarf_getlocations \ - fortify-source \ - sync-compare-and-swap \ - glibc \ - gtk2\ - gtk2-infobar\ - libaudit\ - libbfd \ - libelf \ - libelf-getphdrnum \ - libelf-gelf_getnote \ - libelf-getshdrstrndx\ - libelf-mmap \ - libnuma \ - numa_num_possible_cpus \ - libperl \ - libpython \ - libpython-version \ - libslang\ - libcrypto \ - libunwind \ - libunwind-x86 \ - libunwind-x86_64\ - libunwind-arm \ - libunwind-aarch64 \ - pthread-attr-setaffinity-np \ - stackprotector-all \ - timerfd \ - libdw-dwarf-unwind \ - zlib\ - lzma\ - get_cpuid \ - bpf \ - sdt +FEATURE_TESTS_BASIC := \ +backtrace \ +dwarf \ +dwarf_getlocations \ +fortify-source \ +sync-compare-and-swap \ +glibc \ +gtk2\ +gtk2-infobar\ +libaudit\ +libbfd \ +libelf \ +libelf-getphdrnum \ +libelf-gelf_getnote \ +libelf-getshdrstrndx\ +libelf-mmap \ +libnuma \ +numa_num_possible_cpus \ +libperl \ +libpython \ +libpython-version \ +libslang
[PATCH 15/20] tools build: Move tabs to spaces where suitable
From: Jiri Olsa We've been hit several times by a Makefile bug where line indented by tab was falsely considered as target command. We prevent this by always using space indentation for everything except for the target commands. Signed-off-by: Jiri Olsa Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1480884178-8072-3-git-send-email-jo...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/build/Build.include| 12 ++-- tools/build/Makefile.feature | 138 +-- tools/build/feature/Makefile | 102 3 files changed, 126 insertions(+), 126 deletions(-) diff --git a/tools/build/Build.include b/tools/build/Build.include index 475152c52871..418871d02ebf 100644 --- a/tools/build/Build.include +++ b/tools/build/Build.include @@ -72,15 +72,15 @@ dep-cmd = $(if $(wildcard $(fixdep)), # target, or command line has changed and update # dependencies in the cmd file if_changed_dep = $(if $(strip $(any-prereq) $(arg-check)), \ - @set -e; \ - $(echo-cmd) $(cmd_$(1)) && $(dep-cmd)) + @set -e; \ + $(echo-cmd) $(cmd_$(1)) && $(dep-cmd)) # if_changed - execute command if any prerequisite is newer than # target, or command line has changed -if_changed = $(if $(strip $(any-prereq) $(arg-check)), \ - @set -e; \ - $(echo-cmd) $(cmd_$(1)); \ - printf '%s\n' 'cmd_$@ := $(make-cmd)' > $(dot-target).cmd) +if_changed = $(if $(strip $(any-prereq) $(arg-check)), \ + @set -e; \ + $(echo-cmd) $(cmd_$(1)); \ + printf '%s\n' 'cmd_$@ := $(make-cmd)' > $(dot-target).cmd) ### # C flags to be used in rule definitions, includes: diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature index ae52e029dd22..e3fb5ecbdcb6 100644 --- a/tools/build/Makefile.feature +++ b/tools/build/Makefile.feature @@ -27,58 +27,58 @@ endef # the rule that uses them - an example for that is the 'bionic' # feature check. ] # -FEATURE_TESTS_BASIC := \ - backtrace \ - dwarf \ - dwarf_getlocations \ - fortify-source \ - sync-compare-and-swap \ - glibc \ - gtk2\ - gtk2-infobar\ - libaudit\ - libbfd \ - libelf \ - libelf-getphdrnum \ - libelf-gelf_getnote \ - libelf-getshdrstrndx\ - libelf-mmap \ - libnuma \ - numa_num_possible_cpus \ - libperl \ - libpython \ - libpython-version \ - libslang\ - libcrypto \ - libunwind \ - libunwind-x86 \ - libunwind-x86_64\ - libunwind-arm \ - libunwind-aarch64 \ - pthread-attr-setaffinity-np \ - stackprotector-all \ - timerfd \ - libdw-dwarf-unwind \ - zlib\ - lzma\ - get_cpuid \ - bpf \ - sdt +FEATURE_TESTS_BASIC := \ +backtrace \ +dwarf \ +dwarf_getlocations \ +fortify-source \ +sync-compare-and-swap \ +glibc \ +gtk2\ +gtk2-infobar\ +libaudit\ +libbfd \ +libelf \ +libelf-getphdrnum \ +libelf-gelf_getnote \ +libelf-getshdrstrndx\ +libelf-mmap \ +libnuma \ +numa_num_possible_cpus \ +libperl \ +libpython \ +libpython-version \ +libslang\ +libcrypto \ +libunwind \ +libunwind-x86