Re: [PATCH 17/34] power: supply: bq24257_charger: simplify getting the adapter of a client
On Sat, Jun 08, 2019 at 12:55:56PM +0200, Wolfram Sang wrote: > We have a dedicated pointer for that, so use it. Much easier to read and > less computation involved. > > Signed-off-by: Wolfram Sang Reviewed-by: Simon Horman > --- > > Please apply to your subsystem tree. > > drivers/power/supply/bq24257_charger.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/supply/bq24257_charger.c > b/drivers/power/supply/bq24257_charger.c > index 7eb58f10e092..eb151687beb3 100644 > --- a/drivers/power/supply/bq24257_charger.c > +++ b/drivers/power/supply/bq24257_charger.c > @@ -950,7 +950,7 @@ static int bq24257_fw_probe(struct bq24257_device *bq) > static int bq24257_probe(struct i2c_client *client, >const struct i2c_device_id *id) > { > - struct i2c_adapter *adapter = to_i2c_adapter(client->dev.parent); > + struct i2c_adapter *adapter = client->adapter; > struct device *dev = >dev; > const struct acpi_device_id *acpi_id; > struct bq24257_device *bq; > -- > 2.19.1 >
[PATCH 17/34] power: supply: bq24257_charger: simplify getting the adapter of a client
We have a dedicated pointer for that, so use it. Much easier to read and less computation involved. Signed-off-by: Wolfram Sang --- Please apply to your subsystem tree. drivers/power/supply/bq24257_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/bq24257_charger.c b/drivers/power/supply/bq24257_charger.c index 7eb58f10e092..eb151687beb3 100644 --- a/drivers/power/supply/bq24257_charger.c +++ b/drivers/power/supply/bq24257_charger.c @@ -950,7 +950,7 @@ static int bq24257_fw_probe(struct bq24257_device *bq) static int bq24257_probe(struct i2c_client *client, const struct i2c_device_id *id) { - struct i2c_adapter *adapter = to_i2c_adapter(client->dev.parent); + struct i2c_adapter *adapter = client->adapter; struct device *dev = >dev; const struct acpi_device_id *acpi_id; struct bq24257_device *bq; -- 2.19.1