[PATCH 2/2] ASoC: sun4i-codec: Remove redundant SND_PCM_RATE_KNOT

[Maxime Ripard]

The SND_PCM_RATE_KNOT covers all the rate settings, even though some that
we don't support, while we also list all the rate we support. Simply remove
it.

Signed-off-by: Maxime Ripard 
---
 sound/soc/sunxi/sun4i-codec.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c
index 28834129bea3..e5d195fe491e 100644
--- a/sound/soc/sunxi/sun4i-codec.c
+++ b/sound/soc/sunxi/sun4i-codec.c
@@ -389,8 +389,7 @@ static struct snd_soc_dai_driver sun4i_codec_dai = {
.rate_max   = 192000,
.rates  = SNDRV_PCM_RATE_8000_48000 |
  SNDRV_PCM_RATE_96000 |
- SNDRV_PCM_RATE_192000 |
- SNDRV_PCM_RATE_KNOT,
+ SNDRV_PCM_RATE_192000,
.formats= SNDRV_PCM_FMTBIT_S16_LE |
  SNDRV_PCM_FMTBIT_S32_LE,
.sig_bits   = 24,
-- 
2.5.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/2] ASoC: sun4i-codec: Remove redundant SND_PCM_RATE_KNOT

[Mark Brown]

On Tue, Sep 29, 2015 at 09:43:18PM +0200, Maxime Ripard wrote:
> The SND_PCM_RATE_KNOT covers all the rate settings, even though some that
> we don't support, while we also list all the rate we support. Simply remove
> it.

I'll apply this but ideally you'd be able to use _KNOT plus some
extra constraints registered in startup() for maximum flexability but
realistically people mostly only use the standard rates anyway.


signature.asc
Description: Digital signature