Re: [PATCH 2/2] HID: intel-ish-hid: format 32-bit integers with %X

[Srinivas Pandruvada]

On Thu, 2016-12-22 at 11:09 +0100, Nicolas Iooss wrote:
> In ishtp_hid_probe(), use %04X instead of %04hX to format __u32
> values,
> in order to silent a format error reported by clang:
> 
> drivers/hid/intel-ish-hid/ishtp-hid.c:212:3: error: format
> specifies
> type 'unsigned short' but the argument has type '__u32' (aka
> 'unsigned int') [-Werror,-Wformat]
> hid->vendor, hid->product);
> ^~~
> drivers/hid/intel-ish-hid/ishtp-hid.c:212:16: error: format
> specifies type 'unsigned short' but the argument has type '__u32'
> (aka 'unsigned int') [-Werror,-Wformat]
> hid->vendor, hid->product);
>  ^~~~
> 
> Signed-off-by: Nicolas Iooss 
Acked-by: Srinivas Pandruvada 

> ---
>  drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/intel-ish-hid/ishtp-hid.c
> b/drivers/hid/intel-ish-hid/ishtp-hid.c
> index 277983aa1d90..cd23903ddcf1 100644
> --- a/drivers/hid/intel-ish-hid/ishtp-hid.c
> +++ b/drivers/hid/intel-ish-hid/ishtp-hid.c
> @@ -208,7 +208,7 @@ int ishtp_hid_probe(unsigned int cur_hid_dev,
>   hid->version = le16_to_cpu(ISH_HID_VERSION);
>   hid->vendor = le16_to_cpu(ISH_HID_VENDOR);
>   hid->product = le16_to_cpu(ISH_HID_PRODUCT);
> - snprintf(hid->name, sizeof(hid->name), "%s %04hX:%04hX",
> "hid-ishtp",
> + snprintf(hid->name, sizeof(hid->name), "%s %04X:%04X", "hid-
> ishtp",
>   hid->vendor, hid->product);
>  
>   rv = hid_add_device(hid);

[PATCH 2/2] HID: intel-ish-hid: format 32-bit integers with %X

[Nicolas Iooss]

In ishtp_hid_probe(), use %04X instead of %04hX to format __u32 values,
in order to silent a format error reported by clang:

drivers/hid/intel-ish-hid/ishtp-hid.c:212:3: error: format specifies
type 'unsigned short' but the argument has type '__u32' (aka
'unsigned int') [-Werror,-Wformat]
hid->vendor, hid->product);
^~~
drivers/hid/intel-ish-hid/ishtp-hid.c:212:16: error: format
specifies type 'unsigned short' but the argument has type '__u32'
(aka 'unsigned int') [-Werror,-Wformat]
hid->vendor, hid->product);
 ^~~~

Signed-off-by: Nicolas Iooss 
---
 drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/intel-ish-hid/ishtp-hid.c 
b/drivers/hid/intel-ish-hid/ishtp-hid.c
index 277983aa1d90..cd23903ddcf1 100644
--- a/drivers/hid/intel-ish-hid/ishtp-hid.c
+++ b/drivers/hid/intel-ish-hid/ishtp-hid.c
@@ -208,7 +208,7 @@ int ishtp_hid_probe(unsigned int cur_hid_dev,
hid->version = le16_to_cpu(ISH_HID_VERSION);
hid->vendor = le16_to_cpu(ISH_HID_VENDOR);
hid->product = le16_to_cpu(ISH_HID_PRODUCT);
-   snprintf(hid->name, sizeof(hid->name), "%s %04hX:%04hX", "hid-ishtp",
+   snprintf(hid->name, sizeof(hid->name), "%s %04X:%04X", "hid-ishtp",
hid->vendor, hid->product);
 
rv = hid_add_device(hid);
-- 
2.11.0