Re: [PATCH 2/2] Staging: xgifb:XGI_main_26: Added braces to the conditional statement

2017-02-24 Thread Greg KH 
On Wed, Feb 22, 2017 at 08:26:01PM +0200, Georgios Emmanouil wrote:
> Coding style issue. Added brances to the conditional statement.
> 
> Signed-off-by: Georgios Emmanouil 
> ---
>  drivers/staging/xgifb/XGI_main_26.c | 11 ++-
>  1 file changed, 6 insertions(+), 5 deletions(-)

Same here, someone else already did this :(

Re: [PATCH 2/2] Staging: xgifb:XGI_main_26: Added braces to the conditional statement

2017-02-24 Thread Greg KH 
On Wed, Feb 22, 2017 at 08:26:01PM +0200, Georgios Emmanouil wrote:
> Coding style issue. Added brances to the conditional statement.
> 
> Signed-off-by: Georgios Emmanouil 
> ---
>  drivers/staging/xgifb/XGI_main_26.c | 11 ++-
>  1 file changed, 6 insertions(+), 5 deletions(-)

Same here, someone else already did this :(

[PATCH 2/2] Staging: xgifb:XGI_main_26: Added braces to the conditional statement

2017-02-22 Thread Georgios Emmanouil 
Coding style issue. Added brances to the conditional statement.

Signed-off-by: Georgios Emmanouil 
---
 drivers/staging/xgifb/XGI_main_26.c | 11 ++-
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/xgifb/XGI_main_26.c 
b/drivers/staging/xgifb/XGI_main_26.c
index c4fdc1c..1be0343 100644
--- a/drivers/staging/xgifb/XGI_main_26.c
+++ b/drivers/staging/xgifb/XGI_main_26.c
@@ -1500,18 +1500,19 @@ static void XGIfb_detect_VB(struct xgifb_video_info 
*xgifb_info)
xgifb_info->display2 = XGIFB_DISP_NONE;
}

-   if (XGIfb_tvplug != -1)
+   if (XGIfb_tvplug != -1) {
/* Override with option */
xgifb_info->TV_plug = XGIfb_tvplug;
-   else if (cr32 & SIS_VB_HIVISION) {
+   } else if (cr32 & SIS_VB_HIVISION) {
xgifb_info->TV_type = TVMODE_HIVISION;
xgifb_info->TV_plug = TVPLUG_SVIDEO;
-   } else if (cr32 & SIS_VB_SVIDEO)
+   } else if (cr32 & SIS_VB_SVIDEO) {
xgifb_info->TV_plug = TVPLUG_SVIDEO;
-   else if (cr32 & SIS_VB_COMPOSITE)
+   } else if (cr32 & SIS_VB_COMPOSITE) {
xgifb_info->TV_plug = TVPLUG_COMPOSITE;
-   else if (cr32 & SIS_VB_SCART)
+   } else if (cr32 & SIS_VB_SCART) {
xgifb_info->TV_plug = TVPLUG_SCART;
+   }

if (xgifb_info->TV_type == 0) {
temp = xgifb_reg_get(XGICR, 0x38);
--
2.1.4

[PATCH 2/2] Staging: xgifb:XGI_main_26: Added braces to the conditional statement

2017-02-22 Thread Georgios Emmanouil 
Coding style issue. Added brances to the conditional statement.

Signed-off-by: Georgios Emmanouil 
---
 drivers/staging/xgifb/XGI_main_26.c | 11 ++-
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/xgifb/XGI_main_26.c 
b/drivers/staging/xgifb/XGI_main_26.c
index c4fdc1c..1be0343 100644
--- a/drivers/staging/xgifb/XGI_main_26.c
+++ b/drivers/staging/xgifb/XGI_main_26.c
@@ -1500,18 +1500,19 @@ static void XGIfb_detect_VB(struct xgifb_video_info 
*xgifb_info)
xgifb_info->display2 = XGIFB_DISP_NONE;
}

-   if (XGIfb_tvplug != -1)
+   if (XGIfb_tvplug != -1) {
/* Override with option */
xgifb_info->TV_plug = XGIfb_tvplug;
-   else if (cr32 & SIS_VB_HIVISION) {
+   } else if (cr32 & SIS_VB_HIVISION) {
xgifb_info->TV_type = TVMODE_HIVISION;
xgifb_info->TV_plug = TVPLUG_SVIDEO;
-   } else if (cr32 & SIS_VB_SVIDEO)
+   } else if (cr32 & SIS_VB_SVIDEO) {
xgifb_info->TV_plug = TVPLUG_SVIDEO;
-   else if (cr32 & SIS_VB_COMPOSITE)
+   } else if (cr32 & SIS_VB_COMPOSITE) {
xgifb_info->TV_plug = TVPLUG_COMPOSITE;
-   else if (cr32 & SIS_VB_SCART)
+   } else if (cr32 & SIS_VB_SCART) {
xgifb_info->TV_plug = TVPLUG_SCART;
+   }

if (xgifb_info->TV_type == 0) {
temp = xgifb_reg_get(XGICR, 0x38);
--
2.1.4