RE: [EXT] Re: [PATCH 2/2] arm64: dts: fsl: ls1046a: Add the guts node in dts

2019-05-08 Thread Chuanhua Han 


> -Original Message-
> From: Sascha Hauer 
> Sent: 2019年5月6日 15:41
> To: Chuanhua Han 
> Cc: shawn...@kernel.org; Leo Li ; robh...@kernel.org;
> mark.rutl...@arm.com; linux-kernel@vger.kernel.org;
> linux-...@vger.kernel.org; linux-arm-ker...@lists.infradead.org;
> devicet...@vger.kernel.org; feste...@gmail.com; dl-linux-imx
> ; wsa+rene...@sang-engineering.com;
> u.kleine-koe...@pengutronix.de; e...@deif.com; li...@rempel-privat.de;
> l.st...@pengutronix.de; p...@axentia.se; Sumit Batra
> 
> Subject: [EXT] Re: [PATCH 2/2] arm64: dts: fsl: ls1046a: Add the guts node in
> dts
> 
> Caution: EXT Email
> 
> On Tue, Apr 30, 2019 at 12:47:19PM +0800, Chuanhua Han wrote:
> > For NXP ls1046a SoC, the i2c clock needs to be configured with the
> > appropriate bit of RCW, so we add the guts node (GUTS/DCFG global
> > utilities block) for the driver to read.
> >
> > Signed-off-by: Sumit Batra 
> > Signed-off-by: Chuanhua Han 
> > ---
> >  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 5 +
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > index 373310e4c0ea..f88599df18bb 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > @@ -205,6 +205,11 @@
> >   status = "disabled";
> >   };
> >
> > + guts: global-utilities@1ee {
> > + compatible = "fsl,qoriq-device-config";
> > + reg = <0x0 0x1ee 0x0 0x1000>;
> > + };
> 
> According to Documentation/devicetree/bindings/soc/fsl/guts.txt we have the
> following compatibles:
> 
> "fsl,qoriq-device-config-1.0"
> "fsl,qoriq-device-config-2.0"
> "fsl,-device-config"
> "fsl,-guts"
> 
> "fsl,qoriq-device-config" is none of them and I don't think you should give 
> this
> SoC specific thing a generic compatible.
> "fsl,ls1046a-device-config" would be better.
> 
Yes, you should be right
> Sascha
> 
> 
> --
> Pengutronix e.K.   |
> |
> Industrial Linux Solutions |
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.pe
> ngutronix.de%2Fdata=02%7C01%7Cchuanhua.han%40nxp.com%7C139
> 23fe17a1d46dad7e708d6d1f63f41%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C0%7C0%7C636927252885458344sdata=RLeDiCtLJRYzOZQ4P8CN8g
> hTUGNF%2FKA%2FT%2FtLSCrgEaE%3Dreserved=0  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0
> |
> Amtsgericht Hildesheim, HRA 2686   | Fax:
> +49-5121-206917- |

RE: [EXT] Re: [PATCH 2/2] arm64: dts: fsl: ls1046a: Add the guts node in dts

2019-05-06 Thread Chuanhua Han 


> -Original Message-
> From: Sascha Hauer 
> Sent: 2019年5月6日 15:41
> To: Chuanhua Han 
> Cc: shawn...@kernel.org; Leo Li ; robh...@kernel.org;
> mark.rutl...@arm.com; linux-kernel@vger.kernel.org;
> linux-...@vger.kernel.org; linux-arm-ker...@lists.infradead.org;
> devicet...@vger.kernel.org; feste...@gmail.com; dl-linux-imx
> ; wsa+rene...@sang-engineering.com;
> u.kleine-koe...@pengutronix.de; e...@deif.com; li...@rempel-privat.de;
> l.st...@pengutronix.de; p...@axentia.se; Sumit Batra
> 
> Subject: [EXT] Re: [PATCH 2/2] arm64: dts: fsl: ls1046a: Add the guts node in
> dts
> 
> Caution: EXT Email
> 
> On Tue, Apr 30, 2019 at 12:47:19PM +0800, Chuanhua Han wrote:
> > For NXP ls1046a SoC, the i2c clock needs to be configured with the
> > appropriate bit of RCW, so we add the guts node (GUTS/DCFG global
> > utilities block) for the driver to read.
> >
> > Signed-off-by: Sumit Batra 
> > Signed-off-by: Chuanhua Han 
> > ---
> >  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 5 +
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > index 373310e4c0ea..f88599df18bb 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > @@ -205,6 +205,11 @@
> >   status = "disabled";
> >   };
> >
> > + guts: global-utilities@1ee {
> > + compatible = "fsl,qoriq-device-config";
> > + reg = <0x0 0x1ee 0x0 0x1000>;
> > + };
> 
> According to Documentation/devicetree/bindings/soc/fsl/guts.txt we have the
> following compatibles:
> 
> "fsl,qoriq-device-config-1.0"
> "fsl,qoriq-device-config-2.0"
> "fsl,-device-config"
> "fsl,-guts"
> 
> "fsl,qoriq-device-config" is none of them and I don't think you should give 
> this
> SoC specific thing a generic compatible.
> "fsl,ls1046a-device-config" would be better.
yes, you are right,I will modify it 
> 
> Sascha
> 
> 
> --
> Pengutronix e.K.   |
> |
> Industrial Linux Solutions |
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.pe
> ngutronix.de%2Fdata=02%7C01%7Cchuanhua.han%40nxp.com%7C139
> 23fe17a1d46dad7e708d6d1f63f41%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C0%7C0%7C636927252885458344sdata=RLeDiCtLJRYzOZQ4P8CN8g
> hTUGNF%2FKA%2FT%2FtLSCrgEaE%3Dreserved=0  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0
> |
> Amtsgericht Hildesheim, HRA 2686   | Fax:
> +49-5121-206917- |

Re: [PATCH 2/2] arm64: dts: fsl: ls1046a: Add the guts node in dts

2019-05-06 Thread Sascha Hauer 
On Tue, Apr 30, 2019 at 12:47:19PM +0800, Chuanhua Han wrote:
> For NXP ls1046a SoC, the i2c clock needs to be configured with the
> appropriate bit of RCW, so we add the guts node (GUTS/DCFG global
> utilities block) for the driver to read.
> 
> Signed-off-by: Sumit Batra 
> Signed-off-by: Chuanhua Han 
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 5 +
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi 
> b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index 373310e4c0ea..f88599df18bb 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -205,6 +205,11 @@
>   status = "disabled";
>   };
>  
> + guts: global-utilities@1ee {
> + compatible = "fsl,qoriq-device-config";
> + reg = <0x0 0x1ee 0x0 0x1000>;
> + };

According to Documentation/devicetree/bindings/soc/fsl/guts.txt we have
the following compatibles:

"fsl,qoriq-device-config-1.0"
"fsl,qoriq-device-config-2.0"
"fsl,-device-config"
"fsl,-guts"

"fsl,qoriq-device-config" is none of them and I don't think you should
give this SoC specific thing a generic compatible.
"fsl,ls1046a-device-config" would be better.

Sascha


-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

[PATCH 2/2] arm64: dts: fsl: ls1046a: Add the guts node in dts

2019-04-29 Thread Chuanhua Han 
For NXP ls1046a SoC, the i2c clock needs to be configured with the
appropriate bit of RCW, so we add the guts node (GUTS/DCFG global
utilities block) for the driver to read.

Signed-off-by: Sumit Batra 
Signed-off-by: Chuanhua Han 
---
 arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 5 +
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi 
b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index 373310e4c0ea..f88599df18bb 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
@@ -205,6 +205,11 @@
status = "disabled";
};
 
+   guts: global-utilities@1ee {
+   compatible = "fsl,qoriq-device-config";
+   reg = <0x0 0x1ee 0x0 0x1000>;
+   };
+
qspi: spi@155 {
compatible = "fsl,ls1021a-qspi";
#address-cells = <1>;
-- 
2.17.1