Re: [PATCH 2/2] driver: staging: wlan-ng: Removed unnecessary typedefs from hfa384x_usb.c
On Thu, Apr 03, 2014 at 02:25:54AM +0200, Sherif Shehab Aldin wrote: > Removed unnecessary typedefs from hfa384x_usb.c > > Signed-off-by: Sherif Shehab Aldin You've broken this patch set up in a wrong way. It should have just been one patch. Don't introduce a warning and fix it later. The two changes are closely related so they fall under the one thing per patch rule. The subject for this patch is nonsense because it fixes a long line. I can see how you meant is as in you were fixing up the typedef patch that context will be lost in the final git log. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/2] driver: staging: wlan-ng: Removed unnecessary typedefs from hfa384x_usb.c
On Thu, Apr 03, 2014 at 02:25:54AM +0200, Sherif Shehab Aldin wrote: Removed unnecessary typedefs from hfa384x_usb.c Signed-off-by: Sherif Shehab Aldin shehabaldin.she...@gmail.com You've broken this patch set up in a wrong way. It should have just been one patch. Don't introduce a warning and fix it later. The two changes are closely related so they fall under the one thing per patch rule. The subject for this patch is nonsense because it fixes a long line. I can see how you meant is as in you were fixing up the typedef patch that context will be lost in the final git log. regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/2] driver: staging: wlan-ng: Removed unnecessary typedefs from hfa384x_usb.c
Removed unnecessary typedefs from hfa384x_usb.c
Signed-off-by: Sherif Shehab Aldin
---
drivers/staging/wlan-ng/hfa384x_usb.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
b/drivers/staging/wlan-ng/hfa384x_usb.c
index 4cfd074..4e057d7 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -767,7 +767,8 @@ struct usbctlx_rmem_completor {
static int usbctlx_rmem_completor_fn(struct usbctlx_completor *head)
{
- struct usbctlx_rmem_completor *complete = (struct
usbctlx_rmem_completor *) head;
+ struct usbctlx_rmem_completor *complete =
+ (struct usbctlx_rmem_completor *)head;
pr_debug("rmemresp:len=%d\n", complete->rmemresp->frmlen);
memcpy(complete->data, complete->rmemresp->data, complete->len);
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/2] driver: staging: wlan-ng: Removed unnecessary typedefs from hfa384x_usb.c
Removed unnecessary typedefs from hfa384x_usb.c
Signed-off-by: Sherif Shehab Aldin shehabaldin.she...@gmail.com
---
drivers/staging/wlan-ng/hfa384x_usb.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
b/drivers/staging/wlan-ng/hfa384x_usb.c
index 4cfd074..4e057d7 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -767,7 +767,8 @@ struct usbctlx_rmem_completor {
static int usbctlx_rmem_completor_fn(struct usbctlx_completor *head)
{
- struct usbctlx_rmem_completor *complete = (struct
usbctlx_rmem_completor *) head;
+ struct usbctlx_rmem_completor *complete =
+ (struct usbctlx_rmem_completor *)head;
pr_debug(rmemresp:len=%d\n, complete-rmemresp-frmlen);
memcpy(complete-data, complete-rmemresp-data, complete-len);
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
