Re: [PATCH 2/2] dt-bindings: media: Document MSM8939 Venus

[Konrad Dybcio]

Ah, mea culpa!

I completely forgot to mention that this depends on the MSM8939 GCC
driver that has been sent a few days ago, sorry.. [1]

Have you found any additional mistakes in this patch that I should
correct besides this one?


[1] https://lwn.net/Articles/818486/

Konrad

Re: [PATCH 2/2] dt-bindings: media: Document MSM8939 Venus

[Rob Herring]

On Fri,  1 May 2020 22:35:03 +0200, Konrad Dybcio wrote:
> Signed-off-by: Konrad Dybcio 
> ---
>  .../bindings/media/qcom,msm8939-venus.yaml| 119 ++
>  1 file changed, 119 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/media/qcom,msm8939-venus.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

Documentation/devicetree/bindings/media/qcom,msm8939-venus.example.dts:20:18: 
fatal error: dt-bindings/clock/qcom,gcc-msm8939.h: No such file or directory
 #include 
  ^~
compilation terminated.
scripts/Makefile.lib:312: recipe for target 
'Documentation/devicetree/bindings/media/qcom,msm8939-venus.example.dt.yaml' 
failed
make[1]: *** 
[Documentation/devicetree/bindings/media/qcom,msm8939-venus.example.dt.yaml] 
Error 1
make[1]: *** Waiting for unfinished jobs
Makefile:1300: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2

See https://patchwork.ozlabs.org/patch/1281452

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master 
--upgrade

Please check and re-submit.

[PATCH 2/2] dt-bindings: media: Document MSM8939 Venus

[Konrad Dybcio]

Signed-off-by: Konrad Dybcio 
---
 .../bindings/media/qcom,msm8939-venus.yaml| 119 ++
 1 file changed, 119 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/media/qcom,msm8939-venus.yaml

diff --git a/Documentation/devicetree/bindings/media/qcom,msm8939-venus.yaml 
b/Documentation/devicetree/bindings/media/qcom,msm8939-venus.yaml
new file mode 100644
index 0..8cc0002d10163
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/qcom,msm8939-venus.yaml
@@ -0,0 +1,119 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/media/qcom,msm8939-venus.yaml#;
+$schema: "http://devicetree.org/meta-schemas/core.yaml#;
+
+title: Qualcomm Venus video encode and decode accelerators
+
+maintainers:
+  - Stanimir Varbanov 
+
+description: |
+  The Venus IP is a video encode and decode accelerator present
+  on Qualcomm platforms
+
+properties:
+  compatible:
+const: qcom,msm8939-venus
+
+  reg:
+maxItems: 1
+
+  interrupts:
+maxItems: 1
+
+  power-domains:
+maxItems: 1
+
+  clocks:
+maxItems: 3
+
+  clock-names:
+items:
+  - const: core
+  - const: iface
+  - const: bus
+
+  iommus:
+maxItems: 1
+
+  memory-region:
+maxItems: 1
+
+  video-decoder:
+type: object
+
+properties:
+  compatible:
+const: "venus-decoder"
+
+required:
+  - compatible
+
+additionalProperties: false
+
+  video-encoder:
+type: object
+
+properties:
+  compatible:
+const: "venus-encoder"
+
+required:
+  - compatible
+
+additionalProperties: false
+
+  video-firmware:
+type: object
+
+description: |
+  Firmware subnode is needed when the platform does not
+  have TrustZone.
+
+properties:
+  iommus:
+maxItems: 1
+
+required:
+  - iommus
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - power-domains
+  - clocks
+  - clock-names
+  - iommus
+  - memory-region
+  - video-decoder
+  - video-encoder
+
+examples:
+  - |
+#include 
+#include 
+
+video-codec@1d0 {
+compatible = "qcom,msm8939-venus";
+reg = <0x01d0 0xff000>;
+interrupts = ;
+clocks = < GCC_VENUS0_VCODEC0_CLK>,
+< GCC_VENUS0_AHB_CLK>,
+< GCC_VENUS0_AXI_CLK>;
+clock-names = "core", "iface", "bus";
+power-domains = < VENUS_GDSC>;
+iommus = <_iommu 5>;
+memory-region = <_mem>;
+
+video-decoder {
+compatible = "venus-decoder";
+};
+
+video-encoder {
+compatible = "venus-encoder";
+};
+};
-- 
2.26.1