Re: [PATCH 2/2] fs/notify: don't show f_handle if exportfs_encode_inode_fh failed
On Tue, Sep 02, 2014 at 12:00:15PM +0400, Andrey Vagin wrote: > Currently we handle only ENOSPC. In case of other errors the file_handle > variable isn't filled properly and we will show a part of stack. > > Cc: Cyrill Gorcunov > Cc: Alexander Viro > Cc: Andrew Morton > Signed-off-by: Andrey Vagin Acked-by: Cyrill Gorcunov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/2] fs/notify: don't show f_handle if exportfs_encode_inode_fh failed
Currently we handle only ENOSPC. In case of other errors the file_handle
variable isn't filled properly and we will show a part of stack.
Cc: Cyrill Gorcunov
Cc: Alexander Viro
Cc: Andrew Morton
Signed-off-by: Andrey Vagin
---
fs/notify/fdinfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/notify/fdinfo.c b/fs/notify/fdinfo.c
index 660d33b..9d7e2b9 100644
--- a/fs/notify/fdinfo.c
+++ b/fs/notify/fdinfo.c
@@ -50,7 +50,7 @@ static int show_mark_fhandle(struct seq_file *m, struct inode
*inode)
size = f.handle.handle_bytes >> 2;
ret = exportfs_encode_inode_fh(inode, (struct fid *)f.handle.f_handle,
, 0);
- if ((ret == FILEID_INVALID) || (ret == -ENOSPC)) {
+ if ((ret == FILEID_INVALID) || (ret < 0)) {
WARN_ONCE(1, "Can't encode file handler for inotify: %d\n",
ret);
return 0;
}
--
1.9.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/2] fs/notify: don't show f_handle if exportfs_encode_inode_fh failed
Currently we handle only ENOSPC. In case of other errors the file_handle
variable isn't filled properly and we will show a part of stack.
Cc: Cyrill Gorcunov gorcu...@openvz.org
Cc: Alexander Viro v...@zeniv.linux.org.uk
Cc: Andrew Morton a...@linux-foundation.org
Signed-off-by: Andrey Vagin ava...@openvz.org
---
fs/notify/fdinfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/notify/fdinfo.c b/fs/notify/fdinfo.c
index 660d33b..9d7e2b9 100644
--- a/fs/notify/fdinfo.c
+++ b/fs/notify/fdinfo.c
@@ -50,7 +50,7 @@ static int show_mark_fhandle(struct seq_file *m, struct inode
*inode)
size = f.handle.handle_bytes 2;
ret = exportfs_encode_inode_fh(inode, (struct fid *)f.handle.f_handle,
size, 0);
- if ((ret == FILEID_INVALID) || (ret == -ENOSPC)) {
+ if ((ret == FILEID_INVALID) || (ret 0)) {
WARN_ONCE(1, Can't encode file handler for inotify: %d\n,
ret);
return 0;
}
--
1.9.3
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/2] fs/notify: don't show f_handle if exportfs_encode_inode_fh failed
On Tue, Sep 02, 2014 at 12:00:15PM +0400, Andrey Vagin wrote: Currently we handle only ENOSPC. In case of other errors the file_handle variable isn't filled properly and we will show a part of stack. Cc: Cyrill Gorcunov gorcu...@openvz.org Cc: Alexander Viro v...@zeniv.linux.org.uk Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Andrey Vagin ava...@openvz.org Acked-by: Cyrill Gorcunov gorcu...@openvz.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
