Re: [PATCH 2/2] mm/hwpoison-inject: check PageLRU of hpage

2015-04-23 Thread Dean Nelson
On 04/16/2015 09:08 PM, Naoya Horiguchi wrote:
> Hwpoison injector checks PageLRU of the raw target page to find out whether
> the page is an appropriate target, but current code now filters out thp tail
> pages, which prevents us from testing for such cases via this interface.
> So let's check hpage instead of p.
> 
> Signed-off-by: Naoya Horiguchi 

Acked-by: Dean Nelson 


> ---
>   mm/hwpoison-inject.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git v4.0.orig/mm/hwpoison-inject.c v4.0/mm/hwpoison-inject.c
> index 2b3f933e3282..4ca5fe0042e1 100644
> --- v4.0.orig/mm/hwpoison-inject.c
> +++ v4.0/mm/hwpoison-inject.c
> @@ -34,12 +34,12 @@ static int hwpoison_inject(void *data, u64 val)
>   if (!hwpoison_filter_enable)
>   goto inject;
>   
> - if (!PageLRU(p) && !PageHuge(p))
> - shake_page(p, 0);
> + if (!PageLRU(hpage) && !PageHuge(p))
> + shake_page(hpage, 0);
>   /*
>* This implies unable to support non-LRU pages.
>*/
> - if (!PageLRU(p) && !PageHuge(p))
> + if (!PageLRU(hpage) && !PageHuge(p))
>   goto put_out;
>   
>   /*
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 2/2] mm/hwpoison-inject: check PageLRU of hpage

2015-04-16 Thread Naoya Horiguchi
Hwpoison injector checks PageLRU of the raw target page to find out whether
the page is an appropriate target, but current code now filters out thp tail
pages, which prevents us from testing for such cases via this interface.
So let's check hpage instead of p.

Signed-off-by: Naoya Horiguchi 
---
 mm/hwpoison-inject.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git v4.0.orig/mm/hwpoison-inject.c v4.0/mm/hwpoison-inject.c
index 2b3f933e3282..4ca5fe0042e1 100644
--- v4.0.orig/mm/hwpoison-inject.c
+++ v4.0/mm/hwpoison-inject.c
@@ -34,12 +34,12 @@ static int hwpoison_inject(void *data, u64 val)
if (!hwpoison_filter_enable)
goto inject;
 
-   if (!PageLRU(p) && !PageHuge(p))
-   shake_page(p, 0);
+   if (!PageLRU(hpage) && !PageHuge(p))
+   shake_page(hpage, 0);
/*
 * This implies unable to support non-LRU pages.
 */
-   if (!PageLRU(p) && !PageHuge(p))
+   if (!PageLRU(hpage) && !PageHuge(p))
goto put_out;
 
/*
-- 
2.1.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/