Re: [PATCH 2/2] pinctrl: digicolor: convert null test to IS_ERR test

[Linus Walleij]

On Mon, Aug 24, 2015 at 11:12 PM, Julia Lawall  wrote:

> Since commit 323de9efdf3e ("pinctrl: make pinctrl_register() return proper
> error code"), pinctrl_register returns an error code rather than NULL on
> failure.  Update a driver that was introduced more recently.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // 
> @@
> expression e,e1,e2;
> @@
>
> e = pinctrl_register(...)
> ... when != e = e1
> if (
> -   e == NULL
> +   IS_ERR(e)
>) {
>  ...
>  return
> -  e2
> +  PTR_ERR(e)
>  ;
>  }
> // 
>
> Signed-off-by: Julia Lawall 

Patch applied for fixes.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/2] pinctrl: digicolor: convert null test to IS_ERR test

[Linus Walleij]

On Mon, Aug 24, 2015 at 11:12 PM, Julia Lawall  wrote:

> Since commit 323de9efdf3e ("pinctrl: make pinctrl_register() return proper
> error code"), pinctrl_register returns an error code rather than NULL on
> failure.  Update a driver that was introduced more recently.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // 
> @@
> expression e,e1,e2;
> @@
>
> e = pinctrl_register(...)
> ... when != e = e1
> if (
> -   e == NULL
> +   IS_ERR(e)
>) {
>  ...
>  return
> -  e2
> +  PTR_ERR(e)
>  ;
>  }
> // 
>
> Signed-off-by: Julia Lawall 

Patch applied for fixes.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/2] pinctrl: digicolor: convert null test to IS_ERR test

[Baruch Siach]

Hi Julia,

On Mon, Aug 24, 2015 at 11:12:27PM +0200, Julia Lawall wrote:
> Since commit 323de9efdf3e ("pinctrl: make pinctrl_register() return proper
> error code"), pinctrl_register returns an error code rather than NULL on
> failure.  Update a driver that was introduced more recently.
> 
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // 
> @@
> expression e,e1,e2;
> @@
> 
> e = pinctrl_register(...)
> ... when != e = e1
> if (
> -   e == NULL
> +   IS_ERR(e)
>) {
>  ...
>  return
> -  e2
> +  PTR_ERR(e)
>  ;
>  }
> // 
> 
> Signed-off-by: Julia Lawall 

Acked-by: Baruch Siach 

Thanks,
baruch

>  drivers/pinctrl/pinctrl-digicolor.c |4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-digicolor.c 
> b/drivers/pinctrl/pinctrl-digicolor.c
> index 461fffc..11f8b83 100644
> --- a/drivers/pinctrl/pinctrl-digicolor.c
> +++ b/drivers/pinctrl/pinctrl-digicolor.c
> @@ -337,9 +337,9 @@ static int dc_pinctrl_probe(struct platform_device *pdev)
>   pmap->dev = >dev;
>  
>   pmap->pctl = pinctrl_register(pctl_desc, >dev, pmap);
> - if (!pmap->pctl) {
> + if (IS_ERR(pmap->pctl)) {
>   dev_err(>dev, "pinctrl driver registration failed\n");
> - return -EINVAL;
> + return PTR_ERR(pmap->pctl);
>   }
>  
>   ret = dc_gpiochip_add(pmap, pdev->dev.of_node);

-- 
 http://baruch.siach.name/blog/  ~. .~   Tk Open Systems
=}ooO--U--Ooo{=
   - bar...@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/2] pinctrl: digicolor: convert null test to IS_ERR test

[Julia Lawall]

Since commit 323de9efdf3e ("pinctrl: make pinctrl_register() return proper
error code"), pinctrl_register returns an error code rather than NULL on
failure.  Update a driver that was introduced more recently.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// 
@@
expression e,e1,e2;
@@

e = pinctrl_register(...)
... when != e = e1
if (
-   e == NULL
+   IS_ERR(e)
   ) {
 ...
 return
-  e2
+  PTR_ERR(e)
 ;
 }
// 

Signed-off-by: Julia Lawall 

---
 drivers/pinctrl/pinctrl-digicolor.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-digicolor.c 
b/drivers/pinctrl/pinctrl-digicolor.c
index 461fffc..11f8b83 100644
--- a/drivers/pinctrl/pinctrl-digicolor.c
+++ b/drivers/pinctrl/pinctrl-digicolor.c
@@ -337,9 +337,9 @@ static int dc_pinctrl_probe(struct platform_device *pdev)
pmap->dev = >dev;
 
pmap->pctl = pinctrl_register(pctl_desc, >dev, pmap);
-   if (!pmap->pctl) {
+   if (IS_ERR(pmap->pctl)) {
dev_err(>dev, "pinctrl driver registration failed\n");
-   return -EINVAL;
+   return PTR_ERR(pmap->pctl);
}
 
ret = dc_gpiochip_add(pmap, pdev->dev.of_node);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/2] pinctrl: digicolor: convert null test to IS_ERR test

[Julia Lawall]

Since commit 323de9efdf3e (pinctrl: make pinctrl_register() return proper
error code), pinctrl_register returns an error code rather than NULL on
failure.  Update a driver that was introduced more recently.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// smpl
@@
expression e,e1,e2;
@@

e = pinctrl_register(...)
... when != e = e1
if (
-   e == NULL
+   IS_ERR(e)
   ) {
 ...
 return
-  e2
+  PTR_ERR(e)
 ;
 }
// /smpl

Signed-off-by: Julia Lawall julia.law...@lip6.fr

---
 drivers/pinctrl/pinctrl-digicolor.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-digicolor.c 
b/drivers/pinctrl/pinctrl-digicolor.c
index 461fffc..11f8b83 100644
--- a/drivers/pinctrl/pinctrl-digicolor.c
+++ b/drivers/pinctrl/pinctrl-digicolor.c
@@ -337,9 +337,9 @@ static int dc_pinctrl_probe(struct platform_device *pdev)
pmap-dev = pdev-dev;
 
pmap-pctl = pinctrl_register(pctl_desc, pdev-dev, pmap);
-   if (!pmap-pctl) {
+   if (IS_ERR(pmap-pctl)) {
dev_err(pdev-dev, pinctrl driver registration failed\n);
-   return -EINVAL;
+   return PTR_ERR(pmap-pctl);
}
 
ret = dc_gpiochip_add(pmap, pdev-dev.of_node);

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/2] pinctrl: digicolor: convert null test to IS_ERR test

[Baruch Siach]

Hi Julia,

On Mon, Aug 24, 2015 at 11:12:27PM +0200, Julia Lawall wrote:
 Since commit 323de9efdf3e (pinctrl: make pinctrl_register() return proper
 error code), pinctrl_register returns an error code rather than NULL on
 failure.  Update a driver that was introduced more recently.
 
 The semantic patch that makes this change is as follows:
 (http://coccinelle.lip6.fr/)
 
 // smpl
 @@
 expression e,e1,e2;
 @@
 
 e = pinctrl_register(...)
 ... when != e = e1
 if (
 -   e == NULL
 +   IS_ERR(e)
) {
  ...
  return
 -  e2
 +  PTR_ERR(e)
  ;
  }
 // /smpl
 
 Signed-off-by: Julia Lawall julia.law...@lip6.fr

Acked-by: Baruch Siach bar...@tkos.co.il

Thanks,
baruch

  drivers/pinctrl/pinctrl-digicolor.c |4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/drivers/pinctrl/pinctrl-digicolor.c 
 b/drivers/pinctrl/pinctrl-digicolor.c
 index 461fffc..11f8b83 100644
 --- a/drivers/pinctrl/pinctrl-digicolor.c
 +++ b/drivers/pinctrl/pinctrl-digicolor.c
 @@ -337,9 +337,9 @@ static int dc_pinctrl_probe(struct platform_device *pdev)
   pmap-dev = pdev-dev;
  
   pmap-pctl = pinctrl_register(pctl_desc, pdev-dev, pmap);
 - if (!pmap-pctl) {
 + if (IS_ERR(pmap-pctl)) {
   dev_err(pdev-dev, pinctrl driver registration failed\n);
 - return -EINVAL;
 + return PTR_ERR(pmap-pctl);
   }
  
   ret = dc_gpiochip_add(pmap, pdev-dev.of_node);

-- 
 http://baruch.siach.name/blog/  ~. .~   Tk Open Systems
=}ooO--U--Ooo{=
   - bar...@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/