Hi Pi-Hsun,
Thank you for your patch. I don't accept patches with an empty commit
description. Can you add it? (maybe you could just explain more what cold-ap-off
means here. Apart from this, the patch LGTM.
Thanks,
Enric
On 17/12/20 9:14, Pi-Hsun Shih wrote:
> Signed-off-by: Pi-Hsun Shih
> ---
> drivers/platform/chrome/cros_ec_sysfs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_sysfs.c
> b/drivers/platform/chrome/cros_ec_sysfs.c
> index f521a5c65091..8210fb10e839 100644
> --- a/drivers/platform/chrome/cros_ec_sysfs.c
> +++ b/drivers/platform/chrome/cros_ec_sysfs.c
> @@ -28,7 +28,7 @@ static ssize_t reboot_show(struct device *dev,
> int count = 0;
>
> count += scnprintf(buf + count, PAGE_SIZE - count,
> -"ro|rw|cancel|cold|disable-jump|hibernate");
> +
> "ro|rw|cancel|cold|disable-jump|hibernate|cold-ap-off");
> count += scnprintf(buf + count, PAGE_SIZE - count,
> " [at-shutdown]\n");
> return count;
> @@ -46,6 +46,7 @@ static ssize_t reboot_store(struct device *dev,
> {"cancel", EC_REBOOT_CANCEL, 0},
> {"ro", EC_REBOOT_JUMP_RO, 0},
> {"rw", EC_REBOOT_JUMP_RW, 0},
> + {"cold-ap-off", EC_REBOOT_COLD_AP_OFF, 0},
> {"cold", EC_REBOOT_COLD, 0},
> {"disable-jump", EC_REBOOT_DISABLE_JUMP, 0},
> {"hibernate",EC_REBOOT_HIBERNATE, 0},
>
