Re: [PATCH 2/2] pps: generator: use new parport device model

[Rodolfo Giometti]

On 29/01/18 00:22, Sudip Mukherjee wrote:

Modify pps generator driver to use the new parallel port device model.

Signed-off-by: Sudip Mukherjee 


Acked-by: Rodolfo Giometti 

--

HCE Engineering  e-mail: giome...@hce-engineering.it
GNU/Linux Solutions  giome...@enneenne.com
Linux Device Driver  giome...@linux.it
Embedded Systems phone:  +39 349 2432127
UNIX programming skype:  rodolfo.giometti
Cosino Project - the quick prototyping embedded system - www.cosino.it
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it

Re: [PATCH 2/2] pps: generator: use new parport device model

[Rodolfo Giometti]

On 29/01/18 00:22, Sudip Mukherjee wrote:

Modify pps generator driver to use the new parallel port device model.

Signed-off-by: Sudip Mukherjee 


Acked-by: Rodolfo Giometti 

--

HCE Engineering  e-mail: giome...@hce-engineering.it
GNU/Linux Solutions  giome...@enneenne.com
Linux Device Driver  giome...@linux.it
Embedded Systems phone:  +39 349 2432127
UNIX programming skype:  rodolfo.giometti
Cosino Project - the quick prototyping embedded system - www.cosino.it
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it

[PATCH 2/2] pps: generator: use new parport device model

[Sudip Mukherjee]

Modify pps generator driver to use the new parallel port device model.

Signed-off-by: Sudip Mukherjee 
---

Tested on qemu with two parallel ports.

 drivers/pps/generators/pps_gen_parport.c | 12 +---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/pps/generators/pps_gen_parport.c 
b/drivers/pps/generators/pps_gen_parport.c
index dcd39fb..99b076c 100644
--- a/drivers/pps/generators/pps_gen_parport.c
+++ b/drivers/pps/generators/pps_gen_parport.c
@@ -192,13 +192,18 @@ static inline ktime_t next_intr_time(struct 
pps_generator_pp *dev)
 
 static void parport_attach(struct parport *port)
 {
+   struct pardev_cb pps_cb;
+
if (attached) {
/* we already have a port */
return;
}
 
-   device.pardev = parport_register_device(port, KBUILD_MODNAME,
-   NULL, NULL, NULL, PARPORT_FLAG_EXCL, );
+   memset(_cb, 0, sizeof(pps_cb));
+   pps_cb.private = 
+   pps_cb.flags = PARPORT_FLAG_EXCL;
+   device.pardev = parport_register_dev_model(port, KBUILD_MODNAME,
+  _cb, 0);
if (!device.pardev) {
pr_err("couldn't register with %s\n", port->name);
return;
@@ -236,8 +241,9 @@ static void parport_detach(struct parport *port)
 
 static struct parport_driver pps_gen_parport_driver = {
.name = KBUILD_MODNAME,
-   .attach = parport_attach,
+   .match_port = parport_attach,
.detach = parport_detach,
+   .devmodel = true,
 };
 
 /* module staff */
-- 
1.9.1

[PATCH 2/2] pps: generator: use new parport device model

[Sudip Mukherjee]

Modify pps generator driver to use the new parallel port device model.

Signed-off-by: Sudip Mukherjee 
---

Tested on qemu with two parallel ports.

 drivers/pps/generators/pps_gen_parport.c | 12 +---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/pps/generators/pps_gen_parport.c 
b/drivers/pps/generators/pps_gen_parport.c
index dcd39fb..99b076c 100644
--- a/drivers/pps/generators/pps_gen_parport.c
+++ b/drivers/pps/generators/pps_gen_parport.c
@@ -192,13 +192,18 @@ static inline ktime_t next_intr_time(struct 
pps_generator_pp *dev)
 
 static void parport_attach(struct parport *port)
 {
+   struct pardev_cb pps_cb;
+
if (attached) {
/* we already have a port */
return;
}
 
-   device.pardev = parport_register_device(port, KBUILD_MODNAME,
-   NULL, NULL, NULL, PARPORT_FLAG_EXCL, );
+   memset(_cb, 0, sizeof(pps_cb));
+   pps_cb.private = 
+   pps_cb.flags = PARPORT_FLAG_EXCL;
+   device.pardev = parport_register_dev_model(port, KBUILD_MODNAME,
+  _cb, 0);
if (!device.pardev) {
pr_err("couldn't register with %s\n", port->name);
return;
@@ -236,8 +241,9 @@ static void parport_detach(struct parport *port)
 
 static struct parport_driver pps_gen_parport_driver = {
.name = KBUILD_MODNAME,
-   .attach = parport_attach,
+   .match_port = parport_attach,
.detach = parport_detach,
+   .devmodel = true,
 };
 
 /* module staff */
-- 
1.9.1