Re: [PATCH 2/2] soundwire: cadence: reduce timeout on transactions

2021-01-19 Thread Vinod Koul
On 15-01-21, 14:16, Bard Liao wrote:
> From: Pierre-Louis Bossart 
> 
> Currently the timeout for SoundWire individual transactions is 2s.
> 
> This is too large in comparison with the enumeration and completion
> timeouts used in codec drivers.
> 
> A command will typically be handled in less than 100us, so 500ms for
> the command completion is more than generous.

Applied, thanks

-- 
~Vinod


[PATCH 2/2] soundwire: cadence: reduce timeout on transactions

2021-01-14 Thread Bard Liao
From: Pierre-Louis Bossart 

Currently the timeout for SoundWire individual transactions is 2s.

This is too large in comparison with the enumeration and completion
timeouts used in codec drivers.

A command will typically be handled in less than 100us, so 500ms for
the command completion is more than generous.

Signed-off-by: Pierre-Louis Bossart 
Signed-off-by: Bard Liao 
---
 drivers/soundwire/cadence_master.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soundwire/cadence_master.c 
b/drivers/soundwire/cadence_master.c
index 9fa55164354a..f0b0ec173f8b 100644
--- a/drivers/soundwire/cadence_master.c
+++ b/drivers/soundwire/cadence_master.c
@@ -188,7 +188,7 @@ MODULE_PARM_DESC(cdns_mcp_int_mask, "Cadence MCP IntMask");
 #define CDNS_PDI_CONFIG_PORT   GENMASK(4, 0)
 
 /* Driver defaults */
-#define CDNS_TX_TIMEOUT2000
+#define CDNS_TX_TIMEOUT500
 
 #define CDNS_SCP_RX_FIFOLEVEL  0x2
 
-- 
2.17.1