subject:"\[PATCH 2\/2\] staging\: rtl8192e\: Fix typo in rtl8192e"

Re: [PATCH 2/2] staging: rtl8192e: Fix typo in rtl8192e

2014-04-24 Thread James Cameron

On Fri, Apr 25, 2014 at 01:48:41AM +0900, Masanari Iida wrote:
> Fix spelling typo in comments within rtl8192e.
> 
> Signed-off-by: Masanari Iida 
> ---
>  drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 2 +-
>  drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c| 2 +-
>  drivers/staging/rtl8192e/rtl8192e/rtl_wx.c| 2 +-
>  drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +-
>  drivers/staging/rtl8192e/rtllib_rx.c  | 2 +-
>  drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
> 

...

> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c 
> b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> index 498995d..59494f5 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> @@ -1213,7 +1213,7 @@ static iw_handler r8192_wx_handlers[] = {
>  };
>  
>  /*
> - * the following rule need to be follwing,
> + * the following rule need to be following,
>   * Odd : get (world access),
>   * even : set (root access)
>   * */

The change is good, and a better change might be "s/rule/rules" and
"s/following/followed".

On the other hand, no other driver mentions this implementation detail
of IW_IS_SET in declaration of iw_priv_args, so perhaps the whole
comment block should be removed.

Either way;

Reviewed-by: James Cameron 

p.s. nice to see you again.

-- 
James Cameron
http://quozl.linux.org.au/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/2] staging: rtl8192e: Fix typo in rtl8192e

2014-04-24 Thread Masanari Iida

Fix spelling typo in comments within rtl8192e.

Signed-off-by: Masanari Iida 
---
 drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 2 +-
 drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c| 2 +-
 drivers/staging/rtl8192e/rtl8192e/rtl_wx.c| 2 +-
 drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +-
 drivers/staging/rtl8192e/rtllib_rx.c  | 2 +-
 drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c 
b/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c
index 5f10e40..79d86b9 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c
@@ -373,7 +373,7 @@ u32 cmpk_message_handle_rx(struct net_device *dev,
default:
 
RT_TRACE(COMP_CMDPKT, ">cmpk_message_handle_rx():"
-"unknow CMD Element\n");
+"unknown CMD Element\n");
return 1;
}
 
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c 
b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
index 5d6d304..b4bfafe 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
@@ -1555,7 +1555,7 @@ static bool SetRFPowerState8190(struct net_device *dev,
 
default:
bResult = false;
-   RT_TRACE(COMP_ERR, "SetRFPowerState8190(): unknow state"
+   RT_TRACE(COMP_ERR, "SetRFPowerState8190(): unknown 
state"
 " to set: 0x%X!!!\n", eRFPowerState);
break;
}
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c 
b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
index 498995d..59494f5 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
@@ -1213,7 +1213,7 @@ static iw_handler r8192_wx_handlers[] = {
 };
 
 /*
- * the following rule need to be follwing,
+ * the following rule need to be following,
  * Odd : get (world access),
  * even : set (root access)
  * */
diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c 
b/drivers/staging/rtl8192e/rtl819x_TSProc.c
index 29608e5..52b2977 100644
--- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
@@ -79,7 +79,7 @@ static void RxPktPendingTimeout(unsigned long data)
 
if (index > REORDER_WIN_SIZE) {
RTLLIB_DEBUG(RTLLIB_DL_ERR, "RxReorderIndicatePacket():"
-" Rx Reorer struct buffer full!!\n");
+" Rx Reorder struct buffer full!!\n");
spin_unlock_irqrestore(&(ieee->reorder_spinlock),
   flags);
return;
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c 
b/drivers/staging/rtl8192e/rtllib_rx.c
index 6c8a8e1..7413816 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -712,7 +712,7 @@ static void RxReorderIndicatePacket(struct rtllib_device 
*ieee,
 
if (index > REORDER_WIN_SIZE) {
RTLLIB_DEBUG(RTLLIB_DL_ERR, "RxReorderIndicatePacket():"
-" Rx Reorer struct buffer full!!\n");
+" Rx Reorder struct buffer full!!\n");
spin_unlock_irqrestore(&(ieee->reorder_spinlock),
   flags);
return;
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c 
b/drivers/staging/rtl8192e/rtllib_softmac.c
index 4bf72bc..d65cba4 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -543,7 +543,7 @@ void rtllib_softmac_scan_syncro(struct rtllib_device *ieee, 
u8 is_mesh)
goto out; /* scan completed */
} while (!ieee->active_channel_map[ch]);
 
-   /* this fuction can be called in two situations
+   /* this function can be called in two situations
 * 1- We have switched to ad-hoc mode and we are
 *performing a complete syncro scan before conclude
 *there are no interesting cell and to create a
-- 
2.0.0.rc0.26.g779792a

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/2] staging: rtl8192e: Fix typo in rtl8192e

2014-04-24 Thread Masanari Iida

Fix spelling typo in comments within rtl8192e.

Signed-off-by: Masanari Iida standby2...@gmail.com
---
 drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 2 +-
 drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c| 2 +-
 drivers/staging/rtl8192e/rtl8192e/rtl_wx.c| 2 +-
 drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +-
 drivers/staging/rtl8192e/rtllib_rx.c  | 2 +-
 drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c 
b/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c
index 5f10e40..79d86b9 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c
@@ -373,7 +373,7 @@ u32 cmpk_message_handle_rx(struct net_device *dev,
default:
 
RT_TRACE(COMP_CMDPKT, cmpk_message_handle_rx():
-unknow CMD Element\n);
+unknown CMD Element\n);
return 1;
}
 
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c 
b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
index 5d6d304..b4bfafe 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
@@ -1555,7 +1555,7 @@ static bool SetRFPowerState8190(struct net_device *dev,
 
default:
bResult = false;
-   RT_TRACE(COMP_ERR, SetRFPowerState8190(): unknow state
+   RT_TRACE(COMP_ERR, SetRFPowerState8190(): unknown 
state
  to set: 0x%X!!!\n, eRFPowerState);
break;
}
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c 
b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
index 498995d..59494f5 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
@@ -1213,7 +1213,7 @@ static iw_handler r8192_wx_handlers[] = {
 };
 
 /*
- * the following rule need to be follwing,
+ * the following rule need to be following,
  * Odd : get (world access),
  * even : set (root access)
  * */
diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c 
b/drivers/staging/rtl8192e/rtl819x_TSProc.c
index 29608e5..52b2977 100644
--- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
@@ -79,7 +79,7 @@ static void RxPktPendingTimeout(unsigned long data)
 
if (index  REORDER_WIN_SIZE) {
RTLLIB_DEBUG(RTLLIB_DL_ERR, RxReorderIndicatePacket():
- Rx Reorer struct buffer full!!\n);
+ Rx Reorder struct buffer full!!\n);
spin_unlock_irqrestore((ieee-reorder_spinlock),
   flags);
return;
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c 
b/drivers/staging/rtl8192e/rtllib_rx.c
index 6c8a8e1..7413816 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -712,7 +712,7 @@ static void RxReorderIndicatePacket(struct rtllib_device 
*ieee,
 
if (index  REORDER_WIN_SIZE) {
RTLLIB_DEBUG(RTLLIB_DL_ERR, RxReorderIndicatePacket():
- Rx Reorer struct buffer full!!\n);
+ Rx Reorder struct buffer full!!\n);
spin_unlock_irqrestore((ieee-reorder_spinlock),
   flags);
return;
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c 
b/drivers/staging/rtl8192e/rtllib_softmac.c
index 4bf72bc..d65cba4 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -543,7 +543,7 @@ void rtllib_softmac_scan_syncro(struct rtllib_device *ieee, 
u8 is_mesh)
goto out; /* scan completed */
} while (!ieee-active_channel_map[ch]);
 
-   /* this fuction can be called in two situations
+   /* this function can be called in two situations
 * 1- We have switched to ad-hoc mode and we are
 *performing a complete syncro scan before conclude
 *there are no interesting cell and to create a
-- 
2.0.0.rc0.26.g779792a

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/2] staging: rtl8192e: Fix typo in rtl8192e

2014-04-24 Thread James Cameron

On Fri, Apr 25, 2014 at 01:48:41AM +0900, Masanari Iida wrote:
 Fix spelling typo in comments within rtl8192e.
 
 Signed-off-by: Masanari Iida standby2...@gmail.com
 ---
  drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 2 +-
  drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c| 2 +-
  drivers/staging/rtl8192e/rtl8192e/rtl_wx.c| 2 +-
  drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +-
  drivers/staging/rtl8192e/rtllib_rx.c  | 2 +-
  drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
  6 files changed, 6 insertions(+), 6 deletions(-)
 

...

 diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c 
 b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
 index 498995d..59494f5 100644
 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
 +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
 @@ -1213,7 +1213,7 @@ static iw_handler r8192_wx_handlers[] = {
  };
  
  /*
 - * the following rule need to be follwing,
 + * the following rule need to be following,
   * Odd : get (world access),
   * even : set (root access)
   * */

The change is good, and a better change might be s/rule/rules and
s/following/followed.

On the other hand, no other driver mentions this implementation detail
of IW_IS_SET in declaration of iw_priv_args, so perhaps the whole
comment block should be removed.

Either way;

Reviewed-by: James Cameron qu...@laptop.org

p.s. nice to see you again.

-- 
James Cameron
http://quozl.linux.org.au/
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/2] staging: rtl8192e: Fix typo in rtl8192e

[PATCH 2/2] staging: rtl8192e: Fix typo in rtl8192e

[PATCH 2/2] staging: rtl8192e: Fix typo in rtl8192e

Re: [PATCH 2/2] staging: rtl8192e: Fix typo in rtl8192e

4 matches

Site Navigation

Mail list logo

Footer information