Re: [PATCH 2/2] usb: host: ehci-msm: Use posted data writes on AHB
On Fri, Nov 6, 2015 at 12:04 AM, Andy Gross wrote: > This patch sets the AHBMODE to allow for posted data writes. This > results in higher performance. > > Signed-off-by: Andy Gross I know it's a little late, but ... Acked-by: Timur Tabi -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/2] usb: host: ehci-msm: Use posted data writes on AHB
On Fri, 6 Nov 2015, Georgi Djakov wrote: > On 11/06/2015 08:04 AM, Andy Gross wrote: > > This patch sets the AHBMODE to allow for posted data writes. This > > results in higher performance. > > > > Signed-off-by: Andy Gross > > With these patches I see significant improvement in throughput > on my db410c board. > > Tested-by: Georgi Djakov > > > --- > > drivers/usb/host/ehci-msm.c |4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c > > index c4f84c8..c23e285 100644 > > --- a/drivers/usb/host/ehci-msm.c > > +++ b/drivers/usb/host/ehci-msm.c > > @@ -57,8 +57,8 @@ static int ehci_msm_reset(struct usb_hcd *hcd) > > > > /* bursts of unspecified length. */ > > writel(0, USB_AHBBURST); > > - /* Use the AHB transactor */ > > - writel(0, USB_AHBMODE); > > + /* Use the AHB transactor, allow posted data writes */ > > + writel(0x8, USB_AHBMODE); > > /* Disable streaming mode and select host mode */ > > writel(0x13, USB_USBMODE); Acked-by: Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/2] usb: host: ehci-msm: Use posted data writes on AHB
On 11/06/2015 08:04 AM, Andy Gross wrote: > This patch sets the AHBMODE to allow for posted data writes. This > results in higher performance. > > Signed-off-by: Andy Gross With these patches I see significant improvement in throughput on my db410c board. Tested-by: Georgi Djakov > --- > drivers/usb/host/ehci-msm.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c > index c4f84c8..c23e285 100644 > --- a/drivers/usb/host/ehci-msm.c > +++ b/drivers/usb/host/ehci-msm.c > @@ -57,8 +57,8 @@ static int ehci_msm_reset(struct usb_hcd *hcd) > > /* bursts of unspecified length. */ > writel(0, USB_AHBBURST); > - /* Use the AHB transactor */ > - writel(0, USB_AHBMODE); > + /* Use the AHB transactor, allow posted data writes */ > + writel(0x8, USB_AHBMODE); > /* Disable streaming mode and select host mode */ > writel(0x13, USB_USBMODE); > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/2] usb: host: ehci-msm: Use posted data writes on AHB
This patch sets the AHBMODE to allow for posted data writes. This results in higher performance. Signed-off-by: Andy Gross --- drivers/usb/host/ehci-msm.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c index c4f84c8..c23e285 100644 --- a/drivers/usb/host/ehci-msm.c +++ b/drivers/usb/host/ehci-msm.c @@ -57,8 +57,8 @@ static int ehci_msm_reset(struct usb_hcd *hcd) /* bursts of unspecified length. */ writel(0, USB_AHBBURST); - /* Use the AHB transactor */ - writel(0, USB_AHBMODE); + /* Use the AHB transactor, allow posted data writes */ + writel(0x8, USB_AHBMODE); /* Disable streaming mode and select host mode */ writel(0x13, USB_USBMODE); -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/