Re: [PATCH 2/2 v4] perf sched: adapt TASK_STATE_TO_CHAR_STR to the latest kernel

[Masami Hiramatsu]

On Mon, 1 Aug 2016 07:58:19 -0600
David Ahern  wrote:

> On 7/31/16 10:30 PM, Tomoki Sekiyama wrote:
> > Update TASK_STATE_TO_CHAR_STR macro to one from sched.h in the latest
> > kernel, where 'N' and 'n' are introduced, 'X' and 'Z' are swapped.
> >
> > Signed-off-by: Tomoki Sekiyama 
> > Fixes: cdce9d738b91e ("perf sched: Add sched latency profiling")
> 
> Wrong Fixes tag for this change.
> 
> This is really an update based on kernel changes, the last one being 
> 7dc603c9028ea.

Except for the above mistake, I'm also OK for the code.

Thanks,

> 
> 
> > Cc: Jiri Olsa 
> > Cc: David Ahern 
> > Cc: Namhyung Kim 
> > Cc: Peter Zijlstra 
> > Cc: Masami Hiramatsu 
> > ---
> > Changes from v3:
> >   Added Fixes:
> >   Split patch into 2 pieces.
> >
> >  tools/perf/builtin-sched.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> > index ce9bef6..5776263 100644
> > --- a/tools/perf/builtin-sched.c
> > +++ b/tools/perf/builtin-sched.c
> > @@ -70,7 +70,7 @@ struct sched_atom {
> > struct task_desc*wakee;
> >  };
> >
> > -#define TASK_STATE_TO_CHAR_STR "RSDTtZXxKWP"
> > +#define TASK_STATE_TO_CHAR_STR "RSDTtXZxKWPNn"
> >
> >  enum thread_state {
> > THREAD_SLEEPING = 0,
> >
> 
> Acked-by: David Ahern 


-- 
Masami Hiramatsu 

Re: [PATCH 2/2 v4] perf sched: adapt TASK_STATE_TO_CHAR_STR to the latest kernel

[Masami Hiramatsu]

On Mon, 1 Aug 2016 07:58:19 -0600
David Ahern  wrote:

> On 7/31/16 10:30 PM, Tomoki Sekiyama wrote:
> > Update TASK_STATE_TO_CHAR_STR macro to one from sched.h in the latest
> > kernel, where 'N' and 'n' are introduced, 'X' and 'Z' are swapped.
> >
> > Signed-off-by: Tomoki Sekiyama 
> > Fixes: cdce9d738b91e ("perf sched: Add sched latency profiling")
> 
> Wrong Fixes tag for this change.
> 
> This is really an update based on kernel changes, the last one being 
> 7dc603c9028ea.

Except for the above mistake, I'm also OK for the code.

Thanks,

> 
> 
> > Cc: Jiri Olsa 
> > Cc: David Ahern 
> > Cc: Namhyung Kim 
> > Cc: Peter Zijlstra 
> > Cc: Masami Hiramatsu 
> > ---
> > Changes from v3:
> >   Added Fixes:
> >   Split patch into 2 pieces.
> >
> >  tools/perf/builtin-sched.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> > index ce9bef6..5776263 100644
> > --- a/tools/perf/builtin-sched.c
> > +++ b/tools/perf/builtin-sched.c
> > @@ -70,7 +70,7 @@ struct sched_atom {
> > struct task_desc*wakee;
> >  };
> >
> > -#define TASK_STATE_TO_CHAR_STR "RSDTtZXxKWP"
> > +#define TASK_STATE_TO_CHAR_STR "RSDTtXZxKWPNn"
> >
> >  enum thread_state {
> > THREAD_SLEEPING = 0,
> >
> 
> Acked-by: David Ahern 


-- 
Masami Hiramatsu 

Re: [PATCH 2/2 v4] perf sched: adapt TASK_STATE_TO_CHAR_STR to the latest kernel

[David Ahern]

On 7/31/16 10:30 PM, Tomoki Sekiyama wrote:

Update TASK_STATE_TO_CHAR_STR macro to one from sched.h in the latest
kernel, where 'N' and 'n' are introduced, 'X' and 'Z' are swapped.

Signed-off-by: Tomoki Sekiyama 
Fixes: cdce9d738b91e ("perf sched: Add sched latency profiling")


Wrong Fixes tag for this change.

This is really an update based on kernel changes, the last one being 
7dc603c9028ea.




Cc: Jiri Olsa 
Cc: David Ahern 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Cc: Masami Hiramatsu 
---
Changes from v3:
  Added Fixes:
  Split patch into 2 pieces.

 tools/perf/builtin-sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index ce9bef6..5776263 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -70,7 +70,7 @@ struct sched_atom {
struct task_desc*wakee;
 };

-#define TASK_STATE_TO_CHAR_STR "RSDTtZXxKWP"
+#define TASK_STATE_TO_CHAR_STR "RSDTtXZxKWPNn"

 enum thread_state {
THREAD_SLEEPING = 0,



Acked-by: David Ahern 

Re: [PATCH 2/2 v4] perf sched: adapt TASK_STATE_TO_CHAR_STR to the latest kernel

[David Ahern]

On 7/31/16 10:30 PM, Tomoki Sekiyama wrote:

Update TASK_STATE_TO_CHAR_STR macro to one from sched.h in the latest
kernel, where 'N' and 'n' are introduced, 'X' and 'Z' are swapped.

Signed-off-by: Tomoki Sekiyama 
Fixes: cdce9d738b91e ("perf sched: Add sched latency profiling")


Wrong Fixes tag for this change.

This is really an update based on kernel changes, the last one being 
7dc603c9028ea.




Cc: Jiri Olsa 
Cc: David Ahern 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Cc: Masami Hiramatsu 
---
Changes from v3:
  Added Fixes:
  Split patch into 2 pieces.

 tools/perf/builtin-sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index ce9bef6..5776263 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -70,7 +70,7 @@ struct sched_atom {
struct task_desc*wakee;
 };

-#define TASK_STATE_TO_CHAR_STR "RSDTtZXxKWP"
+#define TASK_STATE_TO_CHAR_STR "RSDTtXZxKWPNn"

 enum thread_state {
THREAD_SLEEPING = 0,



Acked-by: David Ahern 

[PATCH 2/2 v4] perf sched: adapt TASK_STATE_TO_CHAR_STR to the latest kernel

[Tomoki Sekiyama]

Update TASK_STATE_TO_CHAR_STR macro to one from sched.h in the latest
kernel, where 'N' and 'n' are introduced, 'X' and 'Z' are swapped.

Signed-off-by: Tomoki Sekiyama 
Fixes: cdce9d738b91e ("perf sched: Add sched latency profiling")
Cc: Jiri Olsa 
Cc: David Ahern 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Cc: Masami Hiramatsu 
---
Changes from v3:
  Added Fixes:
  Split patch into 2 pieces.

 tools/perf/builtin-sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index ce9bef6..5776263 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -70,7 +70,7 @@ struct sched_atom {
struct task_desc*wakee;
 };
 
-#define TASK_STATE_TO_CHAR_STR "RSDTtZXxKWP"
+#define TASK_STATE_TO_CHAR_STR "RSDTtXZxKWPNn"
 
 enum thread_state {
THREAD_SLEEPING = 0,
-- 
2.7.4

[PATCH 2/2 v4] perf sched: adapt TASK_STATE_TO_CHAR_STR to the latest kernel

[Tomoki Sekiyama]

Update TASK_STATE_TO_CHAR_STR macro to one from sched.h in the latest
kernel, where 'N' and 'n' are introduced, 'X' and 'Z' are swapped.

Signed-off-by: Tomoki Sekiyama 
Fixes: cdce9d738b91e ("perf sched: Add sched latency profiling")
Cc: Jiri Olsa 
Cc: David Ahern 
Cc: Namhyung Kim 
Cc: Peter Zijlstra 
Cc: Masami Hiramatsu 
---
Changes from v3:
  Added Fixes:
  Split patch into 2 pieces.

 tools/perf/builtin-sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index ce9bef6..5776263 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -70,7 +70,7 @@ struct sched_atom {
struct task_desc*wakee;
 };
 
-#define TASK_STATE_TO_CHAR_STR "RSDTtZXxKWP"
+#define TASK_STATE_TO_CHAR_STR "RSDTtXZxKWPNn"
 
 enum thread_state {
THREAD_SLEEPING = 0,
-- 
2.7.4