Re: [PATCH 2/3] ARM: dts: aspeed: amd-ethanolx: Enable KCS channel 3

[Supreeth Venkatesh]

Thanks Konstantin for this patch.
Thanks Joel for reviewing this.

On 10/28/20 12:28 AM, Joel Stanley wrote:
> [CAUTION: External Email]
> 
> On Tue, 27 Oct 2020 at 12:41, Konstantin Aladyshev
>  wrote:
>>
>> The KCS interface on the LPC channel 3 in the controller
>> is used for the in-band BMC<->BIOS IPMI communication.
>> 0xCA2 is a default host CPU LPC IO address for this
>> interface.
>>
>> Signed-off-by: Konstantin Aladyshev 
> 
> I don't have any docs on the platform so I'll wait for a review from
> Supreeth before applying this one.
Done.
> 
> It's a correct use of the bindings:
> 
> Reviewed-by: Joel Stanley 
Reviewed-by: Supreeth Venkatesh 

> 
>> ---
>>  arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 5 +
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts 
>> b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
>> index 89ddc3847222..2a86bda8afd8 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
>> @@ -147,6 +147,11 @@
>> aspeed,lpc-io-reg = <0x62>;
>>  };
>>
>> + {
>> +   status = "okay";
>> +   aspeed,lpc-io-reg = <0xCA2>;
>> +};
>> +
>>   {
>> status = "okay";
>> aspeed,lpc-io-reg = <0x97DE>;
>> --
>> 2.17.1
>>

Re: [PATCH 2/3] ARM: dts: aspeed: amd-ethanolx: Enable KCS channel 3

[Joel Stanley]

On Tue, 27 Oct 2020 at 12:41, Konstantin Aladyshev
 wrote:
>
> The KCS interface on the LPC channel 3 in the controller
> is used for the in-band BMC<->BIOS IPMI communication.
> 0xCA2 is a default host CPU LPC IO address for this
> interface.
>
> Signed-off-by: Konstantin Aladyshev 

I don't have any docs on the platform so I'll wait for a review from
Supreeth before applying this one.

It's a correct use of the bindings:

Reviewed-by: Joel Stanley 

> ---
>  arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 5 +
>  1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts 
> b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
> index 89ddc3847222..2a86bda8afd8 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
> @@ -147,6 +147,11 @@
> aspeed,lpc-io-reg = <0x62>;
>  };
>
> + {
> +   status = "okay";
> +   aspeed,lpc-io-reg = <0xCA2>;
> +};
> +
>   {
> status = "okay";
> aspeed,lpc-io-reg = <0x97DE>;
> --
> 2.17.1
>

[PATCH 2/3] ARM: dts: aspeed: amd-ethanolx: Enable KCS channel 3

[Konstantin Aladyshev]

The KCS interface on the LPC channel 3 in the controller
is used for the in-band BMC<->BIOS IPMI communication.
0xCA2 is a default host CPU LPC IO address for this
interface.

Signed-off-by: Konstantin Aladyshev 
---
 arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts | 5 +
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts 
b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
index 89ddc3847222..2a86bda8afd8 100644
--- a/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts
@@ -147,6 +147,11 @@
aspeed,lpc-io-reg = <0x62>;
 };
 
+ {
+   status = "okay";
+   aspeed,lpc-io-reg = <0xCA2>;
+};
+
  {
status = "okay";
aspeed,lpc-io-reg = <0x97DE>;
-- 
2.17.1