Re: [PATCH 2/3] ARM: sun7i: dt: Add Security System to A20 SoC DTS
On Thursday, May 22, 2014 at 05:09:55 PM, LABBE Corentin wrote: Commit message ... damn, there is a reason why you _should_ write the commit message, even if the $subject is descriptive enough. You should elaborate on what you did here and _why_ you did it. The _why_ part is also really important since when you read this patch 5 years from now, you won't be looking at this in a confused fashion. > Signed-off-by: LABBE Corentin > --- > arch/arm/boot/dts/sun7i-a20.dtsi | 8 > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi > b/arch/arm/boot/dts/sun7i-a20.dtsi index f4b00a5..ea56552 100644 > --- a/arch/arm/boot/dts/sun7i-a20.dtsi > +++ b/arch/arm/boot/dts/sun7i-a20.dtsi > @@ -523,6 +523,14 @@ > status = "disabled"; > }; > > + crypto: crypto-engine@01c15000 { > + compatible = "allwinner,sun7i-a20-crypto"; > + reg = <0x01c15000 0x1000>; > + interrupts = <0 86 4>; > + clocks = <_gates 5>, <_clk>; > + clock-names = "ahb", "mod"; > + }; > + > spi2: spi@01c17000 { > compatible = "allwinner,sun4i-a10-spi"; > reg = <0x01c17000 0x1000>; Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ARM: sun7i: dt: Add Security System to A20 SoC DTS
On Thursday, May 22, 2014 at 05:09:55 PM, LABBE Corentin wrote: Commit message ... damn, there is a reason why you _should_ write the commit message, even if the $subject is descriptive enough. You should elaborate on what you did here and _why_ you did it. The _why_ part is also really important since when you read this patch 5 years from now, you won't be looking at this in a confused fashion. Signed-off-by: LABBE Corentin clabbe.montj...@gmail.com --- arch/arm/boot/dts/sun7i-a20.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi index f4b00a5..ea56552 100644 --- a/arch/arm/boot/dts/sun7i-a20.dtsi +++ b/arch/arm/boot/dts/sun7i-a20.dtsi @@ -523,6 +523,14 @@ status = disabled; }; + crypto: crypto-engine@01c15000 { + compatible = allwinner,sun7i-a20-crypto; + reg = 0x01c15000 0x1000; + interrupts = 0 86 4; + clocks = ahb_gates 5, ss_clk; + clock-names = ahb, mod; + }; + spi2: spi@01c17000 { compatible = allwinner,sun4i-a10-spi; reg = 0x01c17000 0x1000; Best regards, Marek Vasut -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/3] ARM: sun7i: dt: Add Security System to A20 SoC DTS
Signed-off-by: LABBE Corentin --- arch/arm/boot/dts/sun7i-a20.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi index f4b00a5..ea56552 100644 --- a/arch/arm/boot/dts/sun7i-a20.dtsi +++ b/arch/arm/boot/dts/sun7i-a20.dtsi @@ -523,6 +523,14 @@ status = "disabled"; }; + crypto: crypto-engine@01c15000 { + compatible = "allwinner,sun7i-a20-crypto"; + reg = <0x01c15000 0x1000>; + interrupts = <0 86 4>; + clocks = <_gates 5>, <_clk>; + clock-names = "ahb", "mod"; + }; + spi2: spi@01c17000 { compatible = "allwinner,sun4i-a10-spi"; reg = <0x01c17000 0x1000>; -- 1.8.5.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/3] ARM: sun7i: dt: Add Security System to A20 SoC DTS
Signed-off-by: LABBE Corentin clabbe.montj...@gmail.com --- arch/arm/boot/dts/sun7i-a20.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi index f4b00a5..ea56552 100644 --- a/arch/arm/boot/dts/sun7i-a20.dtsi +++ b/arch/arm/boot/dts/sun7i-a20.dtsi @@ -523,6 +523,14 @@ status = disabled; }; + crypto: crypto-engine@01c15000 { + compatible = allwinner,sun7i-a20-crypto; + reg = 0x01c15000 0x1000; + interrupts = 0 86 4; + clocks = ahb_gates 5, ss_clk; + clock-names = ahb, mod; + }; + spi2: spi@01c17000 { compatible = allwinner,sun4i-a10-spi; reg = 0x01c17000 0x1000; -- 1.8.5.5 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/