Re: [PATCH 2/3] dmaengine: Extend the k3dma driver binding

[Rob Herring]

On Fri, Dec 28, 2018 at 02:36:22PM +0800, h00249924 wrote:
> From: Youlin Wang 
> 
> Extend the k3dma driver binding to support hisi-asp hardware variants.
> 
> Signed-off-by: Youlin Wang 
> Signed-off-by: Tanglei Han 
> Cc: Vinod Koul 
> Cc: Rob Herring 
> Cc: Mark Rutland 
> ---
>  Documentation/devicetree/bindings/dma/k3dma.txt | 33 
> -
>  1 file changed, 32 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/k3dma.txt 
> b/Documentation/devicetree/bindings/dma/k3dma.txt
> index 4945aea..cd21b82 100644
> --- a/Documentation/devicetree/bindings/dma/k3dma.txt
> +++ b/Documentation/devicetree/bindings/dma/k3dma.txt
> @@ -3,7 +3,9 @@
>  See dma.txt first
>  
>  Required properties:
> -- compatible: Should be "hisilicon,k3-dma-1.0"
> +- compatible: Must be one of
> +-"hisilicon,k3-dma-1.0"
> +-"hisilicon,hisi-pcm-asp-dma-1.0"
>  - reg: Should contain DMA registers location and length.
>  - interrupts: Should contain one interrupt shared by all channel
>  - #dma-cells: see dma.txt, should be 1, para number
> @@ -43,3 +45,32 @@ For example, i2c0 read channel request line is 18, while 
> write channel use 19
>   dma-names = "rx", "tx";
>   };
>  
> +
> +
> +
> +Controller:

Why is a new example needed just for a new compatible string?

> + asp_dmac: asp_dmac@E804B000 {
> + compatible = "hisilicon,hisi-pcm-asp-dma-1.0";
> + reg = <0x0 0xe804b000 0x0 0x1000>;
> + #dma-cells = <1>;
> + dma-channels = <16>;
> + dma-requests = <32>;
> + dma-min-chan = <0>;
> + dma-used-chans = <0xFFFE>;
> + dma-share;
> + interrupts = <0 216 4>;
> + interrupt-names = "asp_dma_irq";
> + status = "ok";
> + };
> +
> +Client:
> + i2s2: hisi_i2s {
> + compatible = "hisilicon,hisi-i2s";
> + reg = <0x0 0xe804f800 0x0 0x400>,
> + <0x0 0xe804e000 0x0 0x400>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2s2_pmx_func &i2s2_cfg_func>;
> + dmas = <&asp_dmac 18 &asp_dmac 19>;
> + dma-names = "rx", "tx";
> + #sound-dai-cells = <0>;
> + };
> -- 
> 1.9.1
> 

Re: [PATCH 2/3] dmaengine: Extend the k3dma driver binding

[John Stultz]

On Thu, Dec 27, 2018 at 10:39 PM h00249924  wrote:
>
> From: Youlin Wang 
>
> Extend the k3dma driver binding to support hisi-asp hardware variants.
>
> Signed-off-by: Youlin Wang 
> Signed-off-by: Tanglei Han 
> Cc: Vinod Koul 
> Cc: Rob Herring 
> Cc: Mark Rutland 
> ---
>  Documentation/devicetree/bindings/dma/k3dma.txt | 33 
> -
>  1 file changed, 32 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/k3dma.txt 
> b/Documentation/devicetree/bindings/dma/k3dma.txt
> index 4945aea..cd21b82 100644
> --- a/Documentation/devicetree/bindings/dma/k3dma.txt
> +++ b/Documentation/devicetree/bindings/dma/k3dma.txt
> @@ -3,7 +3,9 @@
>  See dma.txt first
>
>  Required properties:
> -- compatible: Should be "hisilicon,k3-dma-1.0"
> +- compatible: Must be one of
> +-  "hisilicon,k3-dma-1.0"
> +-  "hisilicon,hisi-pcm-asp-dma-1.0"
>  - reg: Should contain DMA registers location and length.
>  - interrupts: Should contain one interrupt shared by all channel
>  - #dma-cells: see dma.txt, should be 1, para number
> @@ -43,3 +45,32 @@ For example, i2c0 read channel request line is 18, while 
> write channel use 19
> dma-names = "rx", "tx";
> };
>
> +
> +
> +
> +Controller:
> +   asp_dmac: asp_dmac@E804B000 {
> +   compatible = "hisilicon,hisi-pcm-asp-dma-1.0";
> +   reg = <0x0 0xe804b000 0x0 0x1000>;
> +   #dma-cells = <1>;
> +   dma-channels = <16>;
> +   dma-requests = <32>;
> +   dma-min-chan = <0>;
> +   dma-used-chans = <0xFFFE>;
> +   dma-share;

Thanks for sending this out!

So min-chan, used-chans and dma-share aren't in the existing binding
document. So they probably should be removed from this example, or the
binding document needs to be updated first.

thanks
-john

[PATCH 2/3] dmaengine: Extend the k3dma driver binding

[h00249924]

From: Youlin Wang 

Extend the k3dma driver binding to support hisi-asp hardware variants.

Signed-off-by: Youlin Wang 
Signed-off-by: Tanglei Han 
Cc: Vinod Koul 
Cc: Rob Herring 
Cc: Mark Rutland 
---
 Documentation/devicetree/bindings/dma/k3dma.txt | 33 -
 1 file changed, 32 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/dma/k3dma.txt 
b/Documentation/devicetree/bindings/dma/k3dma.txt
index 4945aea..cd21b82 100644
--- a/Documentation/devicetree/bindings/dma/k3dma.txt
+++ b/Documentation/devicetree/bindings/dma/k3dma.txt
@@ -3,7 +3,9 @@
 See dma.txt first
 
 Required properties:
-- compatible: Should be "hisilicon,k3-dma-1.0"
+- compatible: Must be one of
+-  "hisilicon,k3-dma-1.0"
+-  "hisilicon,hisi-pcm-asp-dma-1.0"
 - reg: Should contain DMA registers location and length.
 - interrupts: Should contain one interrupt shared by all channel
 - #dma-cells: see dma.txt, should be 1, para number
@@ -43,3 +45,32 @@ For example, i2c0 read channel request line is 18, while 
write channel use 19
dma-names = "rx", "tx";
};
 
+
+
+
+Controller:
+   asp_dmac: asp_dmac@E804B000 {
+   compatible = "hisilicon,hisi-pcm-asp-dma-1.0";
+   reg = <0x0 0xe804b000 0x0 0x1000>;
+   #dma-cells = <1>;
+   dma-channels = <16>;
+   dma-requests = <32>;
+   dma-min-chan = <0>;
+   dma-used-chans = <0xFFFE>;
+   dma-share;
+   interrupts = <0 216 4>;
+   interrupt-names = "asp_dma_irq";
+   status = "ok";
+   };
+
+Client:
+   i2s2: hisi_i2s {
+   compatible = "hisilicon,hisi-i2s";
+   reg = <0x0 0xe804f800 0x0 0x400>,
+   <0x0 0xe804e000 0x0 0x400>;
+   pinctrl-names = "default";
+   pinctrl-0 = <&i2s2_pmx_func &i2s2_cfg_func>;
+   dmas = <&asp_dmac 18 &asp_dmac 19>;
+   dma-names = "rx", "tx";
+   #sound-dai-cells = <0>;
+   };
-- 
1.9.1