Re: [PATCH 2/4] md: raid0: Remove return statement from void function

2019-05-20 Thread Song Liu 
On Mon, May 20, 2019 at 2:45 PM Marcos Paulo de Souza
 wrote:
>
> This return statement was introduced in commit
> 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 ("Linux-2.6.12-rc2") and can be
> safely removed.

Wow, that's a really old commit. :)

I think 3/4 and 4/4 of the set makes git-blame more difficult to
follow. Let's not
apply them.

Thanks,
Song

>
> Signed-off-by: Marcos Paulo de Souza 
> ---
>  drivers/md/raid0.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
> index f3fb5bb8c82a..42b0287104bd 100644
> --- a/drivers/md/raid0.c
> +++ b/drivers/md/raid0.c
> @@ -609,7 +609,6 @@ static bool raid0_make_request(struct mddev *mddev, 
> struct bio *bio)
>  static void raid0_status(struct seq_file *seq, struct mddev *mddev)
>  {
> seq_printf(seq, " %dk chunks", mddev->chunk_sectors / 2);
> -   return;
>  }
>
>  static void *raid0_takeover_raid45(struct mddev *mddev)
> --
> 2.21.0
>

[PATCH 2/4] md: raid0: Remove return statement from void function

2019-05-20 Thread Marcos Paulo de Souza 
This return statement was introduced in commit
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 ("Linux-2.6.12-rc2") and can be
safely removed.

Signed-off-by: Marcos Paulo de Souza 
---
 drivers/md/raid0.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
index f3fb5bb8c82a..42b0287104bd 100644
--- a/drivers/md/raid0.c
+++ b/drivers/md/raid0.c
@@ -609,7 +609,6 @@ static bool raid0_make_request(struct mddev *mddev, struct 
bio *bio)
 static void raid0_status(struct seq_file *seq, struct mddev *mddev)
 {
seq_printf(seq, " %dk chunks", mddev->chunk_sectors / 2);
-   return;
 }
 
 static void *raid0_takeover_raid45(struct mddev *mddev)
-- 
2.21.0