Re: [lttng-dev] [PATCH 2/4] tile: Add definition of NR_syscalls

2013-01-21 Thread Mathieu Desnoyers
* Simon Marchi (simon.mar...@polymtl.ca) wrote:
> It is required by the syscall tracepoint mechanism.
> 
> Signed-off-by: Simon Marchi 
> ---
>  arch/tile/include/uapi/asm/unistd.h |2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/tile/include/uapi/asm/unistd.h 
> b/arch/tile/include/uapi/asm/unistd.h
> index cd7b6dd..c763c86 100644
> --- a/arch/tile/include/uapi/asm/unistd.h
> +++ b/arch/tile/include/uapi/asm/unistd.h
> @@ -20,6 +20,8 @@
>  /* Use the standard ABI for syscalls. */
>  #include 
>  
> +#define NR_syscalls (__NR_syscalls)

The parenthesis around __NR_syscalls seems unnecessary. (unless
parenthesis would happen to be missing around a __NR_syscalls definition
with multiple identifiers, but clearly, the parenthesis don't belong
here).

Thanks,

Mathieu

> +
>  /* Additional Tilera-specific syscalls. */
>  #define __NR_cacheflush  (__NR_arch_specific_syscall + 1)
>  __SYSCALL(__NR_cacheflush, sys_cacheflush)
> -- 
> 1.7.1
> 
> 
> ___
> lttng-dev mailing list
> lttng-...@lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 2/4] tile: Add definition of NR_syscalls

2013-01-21 Thread Simon Marchi
It is required by the syscall tracepoint mechanism.

Signed-off-by: Simon Marchi 
---
 arch/tile/include/uapi/asm/unistd.h |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/tile/include/uapi/asm/unistd.h 
b/arch/tile/include/uapi/asm/unistd.h
index cd7b6dd..c763c86 100644
--- a/arch/tile/include/uapi/asm/unistd.h
+++ b/arch/tile/include/uapi/asm/unistd.h
@@ -20,6 +20,8 @@
 /* Use the standard ABI for syscalls. */
 #include 
 
+#define NR_syscalls (__NR_syscalls)
+
 /* Additional Tilera-specific syscalls. */
 #define __NR_cacheflush(__NR_arch_specific_syscall + 1)
 __SYSCALL(__NR_cacheflush, sys_cacheflush)
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 2/4] tile: Add definition of NR_syscalls

2013-01-21 Thread Simon Marchi
It is required by the syscall tracepoint mechanism.

Signed-off-by: Simon Marchi simon.mar...@polymtl.ca
---
 arch/tile/include/uapi/asm/unistd.h |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/tile/include/uapi/asm/unistd.h 
b/arch/tile/include/uapi/asm/unistd.h
index cd7b6dd..c763c86 100644
--- a/arch/tile/include/uapi/asm/unistd.h
+++ b/arch/tile/include/uapi/asm/unistd.h
@@ -20,6 +20,8 @@
 /* Use the standard ABI for syscalls. */
 #include asm-generic/unistd.h
 
+#define NR_syscalls (__NR_syscalls)
+
 /* Additional Tilera-specific syscalls. */
 #define __NR_cacheflush(__NR_arch_specific_syscall + 1)
 __SYSCALL(__NR_cacheflush, sys_cacheflush)
-- 
1.7.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [lttng-dev] [PATCH 2/4] tile: Add definition of NR_syscalls

2013-01-21 Thread Mathieu Desnoyers
* Simon Marchi (simon.mar...@polymtl.ca) wrote:
 It is required by the syscall tracepoint mechanism.
 
 Signed-off-by: Simon Marchi simon.mar...@polymtl.ca
 ---
  arch/tile/include/uapi/asm/unistd.h |2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)
 
 diff --git a/arch/tile/include/uapi/asm/unistd.h 
 b/arch/tile/include/uapi/asm/unistd.h
 index cd7b6dd..c763c86 100644
 --- a/arch/tile/include/uapi/asm/unistd.h
 +++ b/arch/tile/include/uapi/asm/unistd.h
 @@ -20,6 +20,8 @@
  /* Use the standard ABI for syscalls. */
  #include asm-generic/unistd.h
  
 +#define NR_syscalls (__NR_syscalls)

The parenthesis around __NR_syscalls seems unnecessary. (unless
parenthesis would happen to be missing around a __NR_syscalls definition
with multiple identifiers, but clearly, the parenthesis don't belong
here).

Thanks,

Mathieu

 +
  /* Additional Tilera-specific syscalls. */
  #define __NR_cacheflush  (__NR_arch_specific_syscall + 1)
  __SYSCALL(__NR_cacheflush, sys_cacheflush)
 -- 
 1.7.1
 
 
 ___
 lttng-dev mailing list
 lttng-...@lists.lttng.org
 http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/