Re: [PATCH 2/5] PM / devfreq: make devfreq-event explicitly non-modular

[Chanwoo Choi]

Hi Paul,

On 2016년 06월 26일 03:43, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> menuconfig PM_DEVFREQ_EVENT
>   bool "DEVFREQ-Event device Support"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> This code wasn't using module_init, so we don't need to be concerned
> with altering the initcall level here.
> 
> We don't replace module.h with init.h since the file already has that.
> But we do add export.h since this file does export some symbols.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> 
> Cc: MyungJoo Ham 
> Cc: Kyungmin Park 
> Cc: Chanwoo Choi 
> Cc: linux...@vger.kernel.org
> Signed-off-by: Paul Gortmaker 
> ---
>  drivers/devfreq/devfreq-event.c | 12 +---
>  1 file changed, 1 insertion(+), 11 deletions(-)

Acked-by: Chanwoo Choi 

Regards,
Chanwoo Choi

Re: [PATCH 2/5] PM / devfreq: make devfreq-event explicitly non-modular

[Chanwoo Choi]

Hi Paul,

On 2016년 06월 26일 03:43, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> menuconfig PM_DEVFREQ_EVENT
>   bool "DEVFREQ-Event device Support"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> This code wasn't using module_init, so we don't need to be concerned
> with altering the initcall level here.
> 
> We don't replace module.h with init.h since the file already has that.
> But we do add export.h since this file does export some symbols.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> 
> Cc: MyungJoo Ham 
> Cc: Kyungmin Park 
> Cc: Chanwoo Choi 
> Cc: linux...@vger.kernel.org
> Signed-off-by: Paul Gortmaker 
> ---
>  drivers/devfreq/devfreq-event.c | 12 +---
>  1 file changed, 1 insertion(+), 11 deletions(-)

Acked-by: Chanwoo Choi 

Regards,
Chanwoo Choi

[PATCH 2/5] PM / devfreq: make devfreq-event explicitly non-modular

[Paul Gortmaker]

The Kconfig currently controlling compilation of this code is:

menuconfig PM_DEVFREQ_EVENT
bool "DEVFREQ-Event device Support"

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

This code wasn't using module_init, so we don't need to be concerned
with altering the initcall level here.

We don't replace module.h with init.h since the file already has that.
But we do add export.h since this file does export some symbols.

We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.

Cc: MyungJoo Ham 
Cc: Kyungmin Park 
Cc: Chanwoo Choi 
Cc: linux...@vger.kernel.org
Signed-off-by: Paul Gortmaker 
---
 drivers/devfreq/devfreq-event.c | 12 +---
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/drivers/devfreq/devfreq-event.c b/drivers/devfreq/devfreq-event.c
index 39b048eda2ce..9aea2c7ecbe6 100644
--- a/drivers/devfreq/devfreq-event.c
+++ b/drivers/devfreq/devfreq-event.c
@@ -15,7 +15,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -481,13 +481,3 @@ static int __init devfreq_event_init(void)
return 0;
 }
 subsys_initcall(devfreq_event_init);
-
-static void __exit devfreq_event_exit(void)
-{
-   class_destroy(devfreq_event_class);
-}
-module_exit(devfreq_event_exit);
-
-MODULE_AUTHOR("Chanwoo Choi ");
-MODULE_DESCRIPTION("DEVFREQ-Event class support");
-MODULE_LICENSE("GPL");
-- 
2.8.4

[PATCH 2/5] PM / devfreq: make devfreq-event explicitly non-modular

[Paul Gortmaker]

The Kconfig currently controlling compilation of this code is:

menuconfig PM_DEVFREQ_EVENT
bool "DEVFREQ-Event device Support"

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

This code wasn't using module_init, so we don't need to be concerned
with altering the initcall level here.

We don't replace module.h with init.h since the file already has that.
But we do add export.h since this file does export some symbols.

We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.

Cc: MyungJoo Ham 
Cc: Kyungmin Park 
Cc: Chanwoo Choi 
Cc: linux...@vger.kernel.org
Signed-off-by: Paul Gortmaker 
---
 drivers/devfreq/devfreq-event.c | 12 +---
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/drivers/devfreq/devfreq-event.c b/drivers/devfreq/devfreq-event.c
index 39b048eda2ce..9aea2c7ecbe6 100644
--- a/drivers/devfreq/devfreq-event.c
+++ b/drivers/devfreq/devfreq-event.c
@@ -15,7 +15,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -481,13 +481,3 @@ static int __init devfreq_event_init(void)
return 0;
 }
 subsys_initcall(devfreq_event_init);
-
-static void __exit devfreq_event_exit(void)
-{
-   class_destroy(devfreq_event_class);
-}
-module_exit(devfreq_event_exit);
-
-MODULE_AUTHOR("Chanwoo Choi ");
-MODULE_DESCRIPTION("DEVFREQ-Event class support");
-MODULE_LICENSE("GPL");
-- 
2.8.4

[PATCH 2/5] PM / devfreq: make devfreq-event explicitly non-modular

[Paul Gortmaker]

The Kconfig currently controlling compilation of this code is:

menuconfig PM_DEVFREQ_EVENT
bool "DEVFREQ-Event device Support"

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

This code wasn't using module_init, so we don't need to be concerned
with altering the initcall level here.

We don't replace module.h with init.h since the file already has that.
But we do add export.h since this file does export some symbols.

We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.

Cc: MyungJoo Ham 
Cc: Kyungmin Park 
Cc: Chanwoo Choi 
Cc: linux...@vger.kernel.org
Signed-off-by: Paul Gortmaker 
---
 drivers/devfreq/devfreq-event.c | 12 +---
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/drivers/devfreq/devfreq-event.c b/drivers/devfreq/devfreq-event.c
index 39b048eda2ce..9aea2c7ecbe6 100644
--- a/drivers/devfreq/devfreq-event.c
+++ b/drivers/devfreq/devfreq-event.c
@@ -15,7 +15,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -481,13 +481,3 @@ static int __init devfreq_event_init(void)
return 0;
 }
 subsys_initcall(devfreq_event_init);
-
-static void __exit devfreq_event_exit(void)
-{
-   class_destroy(devfreq_event_class);
-}
-module_exit(devfreq_event_exit);
-
-MODULE_AUTHOR("Chanwoo Choi ");
-MODULE_DESCRIPTION("DEVFREQ-Event class support");
-MODULE_LICENSE("GPL");
-- 
2.8.4

[PATCH 2/5] PM / devfreq: make devfreq-event explicitly non-modular

[Paul Gortmaker]

The Kconfig currently controlling compilation of this code is:

menuconfig PM_DEVFREQ_EVENT
bool "DEVFREQ-Event device Support"

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

This code wasn't using module_init, so we don't need to be concerned
with altering the initcall level here.

We don't replace module.h with init.h since the file already has that.
But we do add export.h since this file does export some symbols.

We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.

Cc: MyungJoo Ham 
Cc: Kyungmin Park 
Cc: Chanwoo Choi 
Cc: linux...@vger.kernel.org
Signed-off-by: Paul Gortmaker 
---
 drivers/devfreq/devfreq-event.c | 12 +---
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/drivers/devfreq/devfreq-event.c b/drivers/devfreq/devfreq-event.c
index 39b048eda2ce..9aea2c7ecbe6 100644
--- a/drivers/devfreq/devfreq-event.c
+++ b/drivers/devfreq/devfreq-event.c
@@ -15,7 +15,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -481,13 +481,3 @@ static int __init devfreq_event_init(void)
return 0;
 }
 subsys_initcall(devfreq_event_init);
-
-static void __exit devfreq_event_exit(void)
-{
-   class_destroy(devfreq_event_class);
-}
-module_exit(devfreq_event_exit);
-
-MODULE_AUTHOR("Chanwoo Choi ");
-MODULE_DESCRIPTION("DEVFREQ-Event class support");
-MODULE_LICENSE("GPL");
-- 
2.8.4