Re: [PATCH 2/5] sctp: Delete an error message for a failed memory allocation in sctp_init()
On 05/22/2017 12:38 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 22 May 2017 17:28:14 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Link: > http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf > Signed-off-by: Markus Elfring > --- > net/sctp/protocol.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c > index 2b1a6215bd2f..5e7c8a344770 100644 > --- a/net/sctp/protocol.c > +++ b/net/sctp/protocol.c > @@ -1447,5 +1447,4 @@ static __init int sctp_init(void) > if (!sctp_ep_hashtable) { > - pr_err("Failed endpoint_hash alloc\n"); > status = -ENOMEM; > goto err_ehash_alloc; > } > Acked-by: Vlad Yasevich At the time this was written, it was patterned after TCP. Since then TCP changed significantly. We can surely clean-up the pr_err() here and possibly update the code as well later. -vlad
Re: [PATCH 2/5] sctp: Delete an error message for a failed memory allocation in sctp_init()
On Mon, May 22, 2017 at 06:38:21PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 22 May 2017 17:28:14 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Link: > http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf > Signed-off-by: Markus Elfring Acked-by: Marcelo Ricardo Leitner > --- > net/sctp/protocol.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c > index 2b1a6215bd2f..5e7c8a344770 100644 > --- a/net/sctp/protocol.c > +++ b/net/sctp/protocol.c > @@ -1447,5 +1447,4 @@ static __init int sctp_init(void) > if (!sctp_ep_hashtable) { > - pr_err("Failed endpoint_hash alloc\n"); > status = -ENOMEM; > goto err_ehash_alloc; > } > -- > 2.13.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sctp" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
Re: [PATCH 2/5] sctp: Delete an error message for a failed memory allocation in sctp_init()
On Mon, May 22, 2017 at 09:46:21PM +0200, SF Markus Elfring wrote: > >> +++ b/net/sctp/protocol.c > >> @@ -1447,5 +1447,4 @@ static __init int sctp_init(void) > >>if (!sctp_ep_hashtable) { > >> - pr_err("Failed endpoint_hash alloc\n"); > > > > Okay but then why not also delete the one a few lines below this one: > > if (!sctp_port_hashtable) { > > pr_err("Failed bind hash alloc\n"); > > status = -ENOMEM; > > goto err_bhash_alloc; > > } > > Seems the same pattern to me. > > > >>status = -ENOMEM; > >>goto err_ehash_alloc; > >>} > > How do you think about to remove the other error message in another > update step if a consensus would be achieved in such a direction > for this software module? Fine by me. Regards, Marcelo
Re: [PATCH 2/5] sctp: Delete an error message for a failed memory allocation in sctp_init()
>> +++ b/net/sctp/protocol.c >> @@ -1447,5 +1447,4 @@ static __init int sctp_init(void) >> if (!sctp_ep_hashtable) { >> -pr_err("Failed endpoint_hash alloc\n"); > > Okay but then why not also delete the one a few lines below this one: > if (!sctp_port_hashtable) { > pr_err("Failed bind hash alloc\n"); > status = -ENOMEM; > goto err_bhash_alloc; > } > Seems the same pattern to me. > >> status = -ENOMEM; >> goto err_ehash_alloc; >> } How do you think about to remove the other error message in another update step if a consensus would be achieved in such a direction for this software module? Regards, Markus
Re: [PATCH 2/5] sctp: Delete an error message for a failed memory allocation in sctp_init()
On Mon, May 22, 2017 at 06:38:21PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 22 May 2017 17:28:14 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Link: > http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf > Signed-off-by: Markus Elfring > --- > net/sctp/protocol.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c > index 2b1a6215bd2f..5e7c8a344770 100644 > --- a/net/sctp/protocol.c > +++ b/net/sctp/protocol.c > @@ -1447,5 +1447,4 @@ static __init int sctp_init(void) > if (!sctp_ep_hashtable) { > - pr_err("Failed endpoint_hash alloc\n"); Okay but then why not also delete the one a few lines below this one: if (!sctp_port_hashtable) { pr_err("Failed bind hash alloc\n"); status = -ENOMEM; goto err_bhash_alloc; } Seems the same pattern to me. > status = -ENOMEM; > goto err_ehash_alloc; > } > -- > 2.13.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sctp" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
[PATCH 2/5] sctp: Delete an error message for a failed memory allocation in sctp_init()
From: Markus Elfring Date: Mon, 22 May 2017 17:28:14 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- net/sctp/protocol.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c index 2b1a6215bd2f..5e7c8a344770 100644 --- a/net/sctp/protocol.c +++ b/net/sctp/protocol.c @@ -1447,5 +1447,4 @@ static __init int sctp_init(void) if (!sctp_ep_hashtable) { - pr_err("Failed endpoint_hash alloc\n"); status = -ENOMEM; goto err_ehash_alloc; } -- 2.13.0