Re: [PATCH 2/6] ARM: cpuidle: Remove overzealous error logging

[Daniel Lezcano]

On 22/07/2019 17:37, Lorenzo Pieralisi wrote:
> CPUidle back-end operations are not implemented in some platforms
> but this should not be considered an error serious enough to be
> logged. Check the arm_cpuidle_init() return value to detect whether
> the failure must be reported or not in the kernel log and do
> not log it if the platform does not support CPUidle operations.
> 
> Signed-off-by: Lorenzo Pieralisi 
> Cc: Ulf Hansson 
> Cc: Sudeep Holla 
> Cc: Daniel Lezcano 
> Cc: "Rafael J. Wysocki" 

Acked-by: Daniel Lezcano 


-- 
  Linaro.org │ Open source software for ARM SoCs

Follow Linaro:   Facebook |
 Twitter |
 Blog

Re: [PATCH 2/6] ARM: cpuidle: Remove overzealous error logging

[Sudeep Holla]

On Mon, Jul 22, 2019 at 04:37:41PM +0100, Lorenzo Pieralisi wrote:
> CPUidle back-end operations are not implemented in some platforms
> but this should not be considered an error serious enough to be
> logged. Check the arm_cpuidle_init() return value to detect whether
> the failure must be reported or not in the kernel log and do
> not log it if the platform does not support CPUidle operations.
> 
> Signed-off-by: Lorenzo Pieralisi 
> Cc: Ulf Hansson 
> Cc: Sudeep Holla 

Reviewed-by: Sudeep Holla 

--
Regards,
Sudeep

[PATCH 2/6] ARM: cpuidle: Remove overzealous error logging

[Lorenzo Pieralisi]

CPUidle back-end operations are not implemented in some platforms
but this should not be considered an error serious enough to be
logged. Check the arm_cpuidle_init() return value to detect whether
the failure must be reported or not in the kernel log and do
not log it if the platform does not support CPUidle operations.

Signed-off-by: Lorenzo Pieralisi 
Cc: Ulf Hansson 
Cc: Sudeep Holla 
Cc: Daniel Lezcano 
Cc: "Rafael J. Wysocki" 
---
 drivers/cpuidle/cpuidle-arm.c | 12 +---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/cpuidle/cpuidle-arm.c b/drivers/cpuidle/cpuidle-arm.c
index dc33b3d2954f..9e5156d39627 100644
--- a/drivers/cpuidle/cpuidle-arm.c
+++ b/drivers/cpuidle/cpuidle-arm.c
@@ -105,11 +105,17 @@ static int __init arm_idle_init_cpu(int cpu)
ret = arm_cpuidle_init(cpu);
 
/*
-* Allow the initialization to continue for other CPUs, if the reported
-* failure is a HW misconfiguration/breakage (-ENXIO).
+* Allow the initialization to continue for other CPUs, if the
+* reported failure is a HW misconfiguration/breakage (-ENXIO).
+*
+* Some platforms do not support idle operations
+* (arm_cpuidle_init() returning -EOPNOTSUPP), we should
+* not flag this case as an error, it is a valid
+* configuration.
 */
if (ret) {
-   pr_err("CPU %d failed to init idle CPU ops\n", cpu);
+   if (ret != -EOPNOTSUPP)
+   pr_err("CPU %d failed to init idle CPU ops\n", cpu);
ret = ret == -ENXIO ? 0 : ret;
goto out_kfree_drv;
}
-- 
2.21.0