Re: [PATCH 2/6] ARM64: dts: meson-axg: uart: fix address space range

[Yixun Lan]

On 01/05/2018 06:30 PM, Jerome Brunet wrote:
> On Fri, 2018-01-05 at 17:56 +0800, Yixun Lan wrote:
>> The address space range is actually 0x18, fixed here.
> 
> Isn't it the same for other meson SoC ? If they are compatible, it should.
> Could you please re-submit this change addressing all the required platforms ?
> 

sure

sorry, I was in hurry to send the patch set without do a full tree check..

you right, the fix should also apply to other SoCs, I will fold them
into this patch together, thanks for raising the idea.



>>
>> Signed-off-by: Yixun Lan 
>> ---
>>  arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi 
>> b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>> index 1c6002b3fe34..9636a7c5f6ed 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>> @@ -143,14 +143,14 @@
>>  
>>  uart_A: serial@24000 {
>>  compatible = "amlogic,meson-gx-uart";
>> -reg = <0x0 0x24000 0x0 0x14>;
>> +reg = <0x0 0x24000 0x0 0x18>;
>>  interrupts = ;
>>  status = "disabled";
>>  };
>>  
>>  uart_B: serial@23000 {
>>  compatible = "amlogic,meson-gx-uart";
>> -reg = <0x0 0x23000 0x0 0x14>;
>> +reg = <0x0 0x23000 0x0 0x18>;
>>  interrupts = ;
>>  status = "disabled";
>>  };
> 
> .
> 

Re: [PATCH 2/6] ARM64: dts: meson-axg: uart: fix address space range

[Yixun Lan]

On 01/05/2018 06:30 PM, Jerome Brunet wrote:
> On Fri, 2018-01-05 at 17:56 +0800, Yixun Lan wrote:
>> The address space range is actually 0x18, fixed here.
> 
> Isn't it the same for other meson SoC ? If they are compatible, it should.
> Could you please re-submit this change addressing all the required platforms ?
> 

sure

sorry, I was in hurry to send the patch set without do a full tree check..

you right, the fix should also apply to other SoCs, I will fold them
into this patch together, thanks for raising the idea.



>>
>> Signed-off-by: Yixun Lan 
>> ---
>>  arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi 
>> b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>> index 1c6002b3fe34..9636a7c5f6ed 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>> @@ -143,14 +143,14 @@
>>  
>>  uart_A: serial@24000 {
>>  compatible = "amlogic,meson-gx-uart";
>> -reg = <0x0 0x24000 0x0 0x14>;
>> +reg = <0x0 0x24000 0x0 0x18>;
>>  interrupts = ;
>>  status = "disabled";
>>  };
>>  
>>  uart_B: serial@23000 {
>>  compatible = "amlogic,meson-gx-uart";
>> -reg = <0x0 0x23000 0x0 0x14>;
>> +reg = <0x0 0x23000 0x0 0x18>;
>>  interrupts = ;
>>  status = "disabled";
>>  };
> 
> .
> 

Re: [PATCH 2/6] ARM64: dts: meson-axg: uart: fix address space range

[Jerome Brunet]

On Fri, 2018-01-05 at 17:56 +0800, Yixun Lan wrote:
> The address space range is actually 0x18, fixed here.

Isn't it the same for other meson SoC ? If they are compatible, it should.
Could you please re-submit this change addressing all the required platforms ?

> 
> Signed-off-by: Yixun Lan 
> ---
>  arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi 
> b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index 1c6002b3fe34..9636a7c5f6ed 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -143,14 +143,14 @@
>  
>   uart_A: serial@24000 {
>   compatible = "amlogic,meson-gx-uart";
> - reg = <0x0 0x24000 0x0 0x14>;
> + reg = <0x0 0x24000 0x0 0x18>;
>   interrupts = ;
>   status = "disabled";
>   };
>  
>   uart_B: serial@23000 {
>   compatible = "amlogic,meson-gx-uart";
> - reg = <0x0 0x23000 0x0 0x14>;
> + reg = <0x0 0x23000 0x0 0x18>;
>   interrupts = ;
>   status = "disabled";
>   };

Re: [PATCH 2/6] ARM64: dts: meson-axg: uart: fix address space range

[Jerome Brunet]

On Fri, 2018-01-05 at 17:56 +0800, Yixun Lan wrote:
> The address space range is actually 0x18, fixed here.

Isn't it the same for other meson SoC ? If they are compatible, it should.
Could you please re-submit this change addressing all the required platforms ?

> 
> Signed-off-by: Yixun Lan 
> ---
>  arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi 
> b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index 1c6002b3fe34..9636a7c5f6ed 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -143,14 +143,14 @@
>  
>   uart_A: serial@24000 {
>   compatible = "amlogic,meson-gx-uart";
> - reg = <0x0 0x24000 0x0 0x14>;
> + reg = <0x0 0x24000 0x0 0x18>;
>   interrupts = ;
>   status = "disabled";
>   };
>  
>   uart_B: serial@23000 {
>   compatible = "amlogic,meson-gx-uart";
> - reg = <0x0 0x23000 0x0 0x14>;
> + reg = <0x0 0x23000 0x0 0x18>;
>   interrupts = ;
>   status = "disabled";
>   };

[PATCH 2/6] ARM64: dts: meson-axg: uart: fix address space range

[Yixun Lan]

The address space range is actually 0x18, fixed here.

Signed-off-by: Yixun Lan 
---
 arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi 
b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index 1c6002b3fe34..9636a7c5f6ed 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -143,14 +143,14 @@
 
uart_A: serial@24000 {
compatible = "amlogic,meson-gx-uart";
-   reg = <0x0 0x24000 0x0 0x14>;
+   reg = <0x0 0x24000 0x0 0x18>;
interrupts = ;
status = "disabled";
};
 
uart_B: serial@23000 {
compatible = "amlogic,meson-gx-uart";
-   reg = <0x0 0x23000 0x0 0x14>;
+   reg = <0x0 0x23000 0x0 0x18>;
interrupts = ;
status = "disabled";
};
-- 
2.15.1

[PATCH 2/6] ARM64: dts: meson-axg: uart: fix address space range

[Yixun Lan]

The address space range is actually 0x18, fixed here.

Signed-off-by: Yixun Lan 
---
 arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi 
b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index 1c6002b3fe34..9636a7c5f6ed 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -143,14 +143,14 @@
 
uart_A: serial@24000 {
compatible = "amlogic,meson-gx-uart";
-   reg = <0x0 0x24000 0x0 0x14>;
+   reg = <0x0 0x24000 0x0 0x18>;
interrupts = ;
status = "disabled";
};
 
uart_B: serial@23000 {
compatible = "amlogic,meson-gx-uart";
-   reg = <0x0 0x23000 0x0 0x14>;
+   reg = <0x0 0x23000 0x0 0x18>;
interrupts = ;
status = "disabled";
};
-- 
2.15.1