Re: [PATCH 2/6] LBS: fix uninitialized swapper_space
On Wed, 26 Sep 2007, Hugh Dickins wrote: > Probably better, yes. In -mm Peter is doing an #ifdef CONFIG_SWAP > bdi_init() on swapper_space. Would make sense to do both together, > perhaps move them to a swapper_space_init() in swap_state.c, saving > his #ifdef too. I suggest leave such cleanups until one or the > other is mainlined. Ok. I have updated the largeblock git tree with your patches and a new revision of the mmap patches. Still working on it. Fallback in the block layer is not yet working. I probably need to look at Nick's patches a bit. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/6] LBS: fix uninitialized swapper_space
On Mon, 24 Sep 2007, Christoph Lameter wrote: > On Fri, 21 Sep 2007, Hugh Dickins wrote: > > > Swapping crashed immediately: must initialize new fields of swapper_space. > > Thanks for finding that. It may be better though to use the new > mapping_setup() function instead? That way there is no #ifdef. Probably better, yes. In -mm Peter is doing an #ifdef CONFIG_SWAP bdi_init() on swapper_space. Would make sense to do both together, perhaps move them to a swapper_space_init() in swap_state.c, saving his #ifdef too. I suggest leave such cleanups until one or the other is mainlined. Hugh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/6] LBS: fix uninitialized swapper_space
On Mon, 24 Sep 2007, Christoph Lameter wrote: On Fri, 21 Sep 2007, Hugh Dickins wrote: Swapping crashed immediately: must initialize new fields of swapper_space. Thanks for finding that. It may be better though to use the new mapping_setup() function instead? That way there is no #ifdef. Probably better, yes. In -mm Peter is doing an #ifdef CONFIG_SWAP bdi_init() on swapper_space. Would make sense to do both together, perhaps move them to a swapper_space_init() in swap_state.c, saving his #ifdef too. I suggest leave such cleanups until one or the other is mainlined. Hugh - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/6] LBS: fix uninitialized swapper_space
On Wed, 26 Sep 2007, Hugh Dickins wrote: Probably better, yes. In -mm Peter is doing an #ifdef CONFIG_SWAP bdi_init() on swapper_space. Would make sense to do both together, perhaps move them to a swapper_space_init() in swap_state.c, saving his #ifdef too. I suggest leave such cleanups until one or the other is mainlined. Ok. I have updated the largeblock git tree with your patches and a new revision of the mmap patches. Still working on it. Fallback in the block layer is not yet working. I probably need to look at Nick's patches a bit. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/6] LBS: fix uninitialized swapper_space
On Fri, 21 Sep 2007, Hugh Dickins wrote: > Swapping crashed immediately: must initialize new fields of swapper_space. Thanks for finding that. It may be better though to use the new mapping_setup() function instead? That way there is no #ifdef. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/6] LBS: fix uninitialized swapper_space
On Fri, 21 Sep 2007, Hugh Dickins wrote: Swapping crashed immediately: must initialize new fields of swapper_space. Thanks for finding that. It may be better though to use the new mapping_setup() function instead? That way there is no #ifdef. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/6] LBS: fix uninitialized swapper_space
Swapping crashed immediately: must initialize new fields of swapper_space.
Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]>
--- 2.6.23-rc6-lbs/mm/swap_state.c 2007-07-26 19:49:58.0 +0100
+++ linux/mm/swap_state.c 2007-09-13 20:00:45.0 +0100
@@ -42,6 +42,10 @@ struct address_space swapper_space = {
.a_ops = _aops,
.i_mmap_nonlinear = LIST_HEAD_INIT(swapper_space.i_mmap_nonlinear),
.backing_dev_info = _backing_dev_info,
+#ifdef CONFIG_LARGE_BLOCKSIZE
+ .shift = PAGE_SHIFT,
+ .offset_mask= PAGE_SIZE - 1,
+#endif
};
#define INC_CACHE_INFO(x) do { swap_cache_info.x++; } while (0)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/6] LBS: fix uninitialized swapper_space
Swapping crashed immediately: must initialize new fields of swapper_space.
Signed-off-by: Hugh Dickins [EMAIL PROTECTED]
--- 2.6.23-rc6-lbs/mm/swap_state.c 2007-07-26 19:49:58.0 +0100
+++ linux/mm/swap_state.c 2007-09-13 20:00:45.0 +0100
@@ -42,6 +42,10 @@ struct address_space swapper_space = {
.a_ops = swap_aops,
.i_mmap_nonlinear = LIST_HEAD_INIT(swapper_space.i_mmap_nonlinear),
.backing_dev_info = swap_backing_dev_info,
+#ifdef CONFIG_LARGE_BLOCKSIZE
+ .shift = PAGE_SHIFT,
+ .offset_mask= PAGE_SIZE - 1,
+#endif
};
#define INC_CACHE_INFO(x) do { swap_cache_info.x++; } while (0)
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
