Re: [PATCH 2/7] console: fix section mismatch warning in vgacon.c
On Sun, 2007-07-22 at 12:20 +0200, Geert Uytterhoeven wrote: > On Sat, 21 Jul 2007, Antonino A. Daplas wrote: > > On Fri, 2007-07-20 at 23:27 +0200, Sam Ravnborg wrote: > > > Fix following section mismatch warning: > > > WARNING: vmlinux.o(.text+0x121e62): Section mismatch: reference to > > > .init.text:__alloc_bootmem (between 'vgacon_startup' and > > > 'vgacon_scrolldelta') > > > > > > Browsing the code it seems that vgacon_scrollback_startup() is only > > > called during the init phase so the reference to the .init.text > > > section is OK. > > > Teach modpost not to warn using ___init_refok. > > > > > > Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> > > Acked-by: Antonino Daplas <[EMAIL PROTECTED]> > > I assume the check for `vga_init_done' in vgacon_startup() is sufficient to > prevent vgacon_scrollback_startup() from being called later due to > (un)bind_con_driver()? > Yes. Tony - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/7] console: fix section mismatch warning in vgacon.c
On Sat, 21 Jul 2007, Antonino A. Daplas wrote:
> On Fri, 2007-07-20 at 23:27 +0200, Sam Ravnborg wrote:
> > Fix following section mismatch warning:
> > WARNING: vmlinux.o(.text+0x121e62): Section mismatch: reference to
> > .init.text:__alloc_bootmem (between 'vgacon_startup' and
> > 'vgacon_scrolldelta')
> >
> > Browsing the code it seems that vgacon_scrollback_startup() is only
> > called during the init phase so the reference to the .init.text
> > section is OK.
> > Teach modpost not to warn using ___init_refok.
> >
> > Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]>
> Acked-by: Antonino Daplas <[EMAIL PROTECTED]>
I assume the check for `vga_init_done' in vgacon_startup() is sufficient to
prevent vgacon_scrollback_startup() from being called later due to
(un)bind_con_driver()?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [EMAIL PROTECTED]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/7] console: fix section mismatch warning in vgacon.c
On Fri, Jul 20, 2007 at 11:01:14PM -0700, Andrew Morton wrote: > On Sat, 21 Jul 2007 07:43:59 +0200 Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > On Sat, Jul 21, 2007 at 07:37:29AM +0800, Antonino A. Daplas wrote: > > > On Fri, 2007-07-20 at 23:27 +0200, Sam Ravnborg wrote: > > > > Fix following section mismatch warning: > > > > WARNING: vmlinux.o(.text+0x121e62): Section mismatch: reference to > > > > .init.text:__alloc_bootmem (between 'vgacon_startup' and > > > > 'vgacon_scrolldelta') > > > > > > > > Browsing the code it seems that vgacon_scrollback_startup() is only > > > > called during the init phase so the reference to the .init.text > > > > section is OK. > > > > Teach modpost not to warn using ___init_refok. > > > > > > > > Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> > > > Acked-by: Antonino Daplas <[EMAIL PROTECTED]> > > > > Thanks. Will you take care of forwarding it it or do we rely > > on Andrew in this area? > > > > I tossed it into the next batch for Linus. Tomorrow, I guess. OK, thanks. Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/7] console: fix section mismatch warning in vgacon.c
On Sat, 21 Jul 2007 07:43:59 +0200 Sam Ravnborg <[EMAIL PROTECTED]> wrote: > On Sat, Jul 21, 2007 at 07:37:29AM +0800, Antonino A. Daplas wrote: > > On Fri, 2007-07-20 at 23:27 +0200, Sam Ravnborg wrote: > > > Fix following section mismatch warning: > > > WARNING: vmlinux.o(.text+0x121e62): Section mismatch: reference to > > > .init.text:__alloc_bootmem (between 'vgacon_startup' and > > > 'vgacon_scrolldelta') > > > > > > Browsing the code it seems that vgacon_scrollback_startup() is only > > > called during the init phase so the reference to the .init.text > > > section is OK. > > > Teach modpost not to warn using ___init_refok. > > > > > > Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> > > Acked-by: Antonino Daplas <[EMAIL PROTECTED]> > > Thanks. Will you take care of forwarding it it or do we rely > on Andrew in this area? > I tossed it into the next batch for Linus. Tomorrow, I guess. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/7] console: fix section mismatch warning in vgacon.c
On Sat, Jul 21, 2007 at 07:37:29AM +0800, Antonino A. Daplas wrote: > On Fri, 2007-07-20 at 23:27 +0200, Sam Ravnborg wrote: > > Fix following section mismatch warning: > > WARNING: vmlinux.o(.text+0x121e62): Section mismatch: reference to > > .init.text:__alloc_bootmem (between 'vgacon_startup' and > > 'vgacon_scrolldelta') > > > > Browsing the code it seems that vgacon_scrollback_startup() is only > > called during the init phase so the reference to the .init.text > > section is OK. > > Teach modpost not to warn using ___init_refok. > > > > Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> > Acked-by: Antonino Daplas <[EMAIL PROTECTED]> Thanks. Will you take care of forwarding it it or do we rely on Andrew in this area? Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/7] console: fix section mismatch warning in vgacon.c
On Fri, 2007-07-20 at 23:27 +0200, Sam Ravnborg wrote: > Fix following section mismatch warning: > WARNING: vmlinux.o(.text+0x121e62): Section mismatch: reference to > .init.text:__alloc_bootmem (between 'vgacon_startup' and 'vgacon_scrolldelta') > > Browsing the code it seems that vgacon_scrollback_startup() is only > called during the init phase so the reference to the .init.text > section is OK. > Teach modpost not to warn using ___init_refok. > > Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Acked-by: Antonino Daplas <[EMAIL PROTECTED]> Tony - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/7] console: fix section mismatch warning in vgacon.c
Fix following section mismatch warning:
WARNING: vmlinux.o(.text+0x121e62): Section mismatch: reference to
.init.text:__alloc_bootmem (between 'vgacon_startup' and 'vgacon_scrolldelta')
Browsing the code it seems that vgacon_scrollback_startup() is only
called during the init phase so the reference to the .init.text
section is OK.
Teach modpost not to warn using ___init_refok.
Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]>
---
drivers/video/console/vgacon.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c
index f46fe95..d18b73a 100644
--- a/drivers/video/console/vgacon.c
+++ b/drivers/video/console/vgacon.c
@@ -187,7 +187,11 @@ static void vgacon_scrollback_init(int pitch)
}
}
-static void vgacon_scrollback_startup(void)
+/*
+ * Called only duing init so call of alloc_bootmen is ok.
+ * Marked __init_refok to silence modpost.
+ */
+static void __init_refok vgacon_scrollback_startup(void)
{
vgacon_scrollback = alloc_bootmem(CONFIG_VGACON_SOFT_SCROLLBACK_SIZE
* 1024);
--
1.5.1.rc3.g84b7-dirty
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
