Re: [PATCH 2/7] net: ethernet: nb8800: Fix module autoload

[Måns Rullgård]

Javier Martinez Canillas  writes:

> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ $ modinfo drivers/net/ethernet/aurora/nb8800.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/net/ethernet/aurora/nb8800.ko | grep alias
> alias:  of:N*T*Csigma,smp8734-ethernetC*
> alias:  of:N*T*Csigma,smp8734-ethernet
> alias:  of:N*T*Csigma,smp8642-ethernetC*
> alias:  of:N*T*Csigma,smp8642-ethernet
> alias:  of:N*T*Caurora,nb8800C*
> alias:  of:N*T*Caurora,nb8800
>
> Signed-off-by: Javier Martinez Canillas 

Acked-by: Mans Rullgard 

> ---
>
>  drivers/net/ethernet/aurora/nb8800.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/aurora/nb8800.c 
> b/drivers/net/ethernet/aurora/nb8800.c
> index 453dc0967125..d5f2ad1a5a30 100644
> --- a/drivers/net/ethernet/aurora/nb8800.c
> +++ b/drivers/net/ethernet/aurora/nb8800.c
> @@ -1357,6 +1357,7 @@ static const struct of_device_id nb8800_dt_ids[] = {
>   },
>   { }
>  };
> +MODULE_DEVICE_TABLE(of, nb8800_dt_ids);
>
>  static int nb8800_probe(struct platform_device *pdev)
>  {
> -- 

-- 
Måns Rullgård

Re: [PATCH 2/7] net: ethernet: nb8800: Fix module autoload

[Måns Rullgård]

Javier Martinez Canillas  writes:

> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ $ modinfo drivers/net/ethernet/aurora/nb8800.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/net/ethernet/aurora/nb8800.ko | grep alias
> alias:  of:N*T*Csigma,smp8734-ethernetC*
> alias:  of:N*T*Csigma,smp8734-ethernet
> alias:  of:N*T*Csigma,smp8642-ethernetC*
> alias:  of:N*T*Csigma,smp8642-ethernet
> alias:  of:N*T*Caurora,nb8800C*
> alias:  of:N*T*Caurora,nb8800
>
> Signed-off-by: Javier Martinez Canillas 

Acked-by: Mans Rullgard 

> ---
>
>  drivers/net/ethernet/aurora/nb8800.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/aurora/nb8800.c 
> b/drivers/net/ethernet/aurora/nb8800.c
> index 453dc0967125..d5f2ad1a5a30 100644
> --- a/drivers/net/ethernet/aurora/nb8800.c
> +++ b/drivers/net/ethernet/aurora/nb8800.c
> @@ -1357,6 +1357,7 @@ static const struct of_device_id nb8800_dt_ids[] = {
>   },
>   { }
>  };
> +MODULE_DEVICE_TABLE(of, nb8800_dt_ids);
>
>  static int nb8800_probe(struct platform_device *pdev)
>  {
> -- 

-- 
Måns Rullgård

[PATCH 2/7] net: ethernet: nb8800: Fix module autoload

[Javier Martinez Canillas]

If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() macro.

Before this patch:

$ $ modinfo drivers/net/ethernet/aurora/nb8800.ko | grep alias
$

After this patch:

$ modinfo drivers/net/ethernet/aurora/nb8800.ko | grep alias
alias:  of:N*T*Csigma,smp8734-ethernetC*
alias:  of:N*T*Csigma,smp8734-ethernet
alias:  of:N*T*Csigma,smp8642-ethernetC*
alias:  of:N*T*Csigma,smp8642-ethernet
alias:  of:N*T*Caurora,nb8800C*
alias:  of:N*T*Caurora,nb8800

Signed-off-by: Javier Martinez Canillas 
---

 drivers/net/ethernet/aurora/nb8800.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/aurora/nb8800.c 
b/drivers/net/ethernet/aurora/nb8800.c
index 453dc0967125..d5f2ad1a5a30 100644
--- a/drivers/net/ethernet/aurora/nb8800.c
+++ b/drivers/net/ethernet/aurora/nb8800.c
@@ -1357,6 +1357,7 @@ static const struct of_device_id nb8800_dt_ids[] = {
},
{ }
 };
+MODULE_DEVICE_TABLE(of, nb8800_dt_ids);
 
 static int nb8800_probe(struct platform_device *pdev)
 {
-- 
2.7.4

[PATCH 2/7] net: ethernet: nb8800: Fix module autoload

[Javier Martinez Canillas]

If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() macro.

Before this patch:

$ $ modinfo drivers/net/ethernet/aurora/nb8800.ko | grep alias
$

After this patch:

$ modinfo drivers/net/ethernet/aurora/nb8800.ko | grep alias
alias:  of:N*T*Csigma,smp8734-ethernetC*
alias:  of:N*T*Csigma,smp8734-ethernet
alias:  of:N*T*Csigma,smp8642-ethernetC*
alias:  of:N*T*Csigma,smp8642-ethernet
alias:  of:N*T*Caurora,nb8800C*
alias:  of:N*T*Caurora,nb8800

Signed-off-by: Javier Martinez Canillas 
---

 drivers/net/ethernet/aurora/nb8800.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/aurora/nb8800.c 
b/drivers/net/ethernet/aurora/nb8800.c
index 453dc0967125..d5f2ad1a5a30 100644
--- a/drivers/net/ethernet/aurora/nb8800.c
+++ b/drivers/net/ethernet/aurora/nb8800.c
@@ -1357,6 +1357,7 @@ static const struct of_device_id nb8800_dt_ids[] = {
},
{ }
 };
+MODULE_DEVICE_TABLE(of, nb8800_dt_ids);
 
 static int nb8800_probe(struct platform_device *pdev)
 {
-- 
2.7.4