Re: [PATCH 2/7] uprobes: Kill the "uprobe != NULL" check in uprobe_unregister()
* Oleg Nesterov [2012-11-23 21:28:02]: > Trivial. uprobe can't be NULL after mutex_unlock(), it was already used. > > Signed-off-by: Oleg Nesterov Acked-by: Srikar Dronamraju > --- > kernel/events/uprobes.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c > index e9f22ed..13b247c 100644 > --- a/kernel/events/uprobes.c > +++ b/kernel/events/uprobes.c > @@ -900,8 +900,7 @@ void uprobe_unregister(struct inode *inode, loff_t > offset, struct uprobe_consume > } > > mutex_unlock(uprobes_hash(inode)); > - if (uprobe) > - put_uprobe(uprobe); > + put_uprobe(uprobe); > } > > static struct rb_node * > -- > 1.5.5.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/7] uprobes: Kill the uprobe != NULL check in uprobe_unregister()
* Oleg Nesterov o...@redhat.com [2012-11-23 21:28:02]: Trivial. uprobe can't be NULL after mutex_unlock(), it was already used. Signed-off-by: Oleg Nesterov o...@redhat.com Acked-by: Srikar Dronamraju sri...@linux.vnet.ibm.com --- kernel/events/uprobes.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index e9f22ed..13b247c 100644 --- a/kernel/events/uprobes.c +++ b/kernel/events/uprobes.c @@ -900,8 +900,7 @@ void uprobe_unregister(struct inode *inode, loff_t offset, struct uprobe_consume } mutex_unlock(uprobes_hash(inode)); - if (uprobe) - put_uprobe(uprobe); + put_uprobe(uprobe); } static struct rb_node * -- 1.5.5.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/7] uprobes: Kill the "uprobe != NULL" check in uprobe_unregister()
Trivial. uprobe can't be NULL after mutex_unlock(), it was already used. Signed-off-by: Oleg Nesterov --- kernel/events/uprobes.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index e9f22ed..13b247c 100644 --- a/kernel/events/uprobes.c +++ b/kernel/events/uprobes.c @@ -900,8 +900,7 @@ void uprobe_unregister(struct inode *inode, loff_t offset, struct uprobe_consume } mutex_unlock(uprobes_hash(inode)); - if (uprobe) - put_uprobe(uprobe); + put_uprobe(uprobe); } static struct rb_node * -- 1.5.5.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/7] uprobes: Kill the uprobe != NULL check in uprobe_unregister()
Trivial. uprobe can't be NULL after mutex_unlock(), it was already used. Signed-off-by: Oleg Nesterov o...@redhat.com --- kernel/events/uprobes.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index e9f22ed..13b247c 100644 --- a/kernel/events/uprobes.c +++ b/kernel/events/uprobes.c @@ -900,8 +900,7 @@ void uprobe_unregister(struct inode *inode, loff_t offset, struct uprobe_consume } mutex_unlock(uprobes_hash(inode)); - if (uprobe) - put_uprobe(uprobe); + put_uprobe(uprobe); } static struct rb_node * -- 1.5.5.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
