Re: [PATCH 2.6.13-rc3] pcmcia: pcmcia_request_irq for !IRQ_HANDLE_PRESENT
On Sun, Jul 24, 2005 at 12:40:40PM +0100, Russell King wrote: > On Sat, Jul 23, 2005 at 10:11:13PM +0200, Dominik Brodowski wrote: > > Thanks for the excellent debugging. Your patch seems to work, however it > > might be better to do just this: > > This can be racy if two drivers are simultaneously trying to request an > IRQ. 'data' must be unique to different threads if they are to avoid > interfering with each other. As it's enough to keep PCMCIA functions apart (there can't be two drivers registering with the same PCMCIA function at the same moment), I'll use that now. void *data = _dev->dev.driver; /* something unique to this device */ Thanks, Dominik - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2.6.13-rc3] pcmcia: pcmcia_request_irq for !IRQ_HANDLE_PRESENT
On Sat, Jul 23, 2005 at 10:11:13PM +0200, Dominik Brodowski wrote: > Thanks for the excellent debugging. Your patch seems to work, however it > might be better to do just this: This can be racy if two drivers are simultaneously trying to request an IRQ. 'data' must be unique to different threads if they are to avoid interfering with each other. -- Russell King Linux kernel2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2.6.13-rc3] pcmcia: pcmcia_request_irq for !IRQ_HANDLE_PRESENT
On Sat, Jul 23, 2005 at 10:11:13PM +0200, Dominik Brodowski wrote: Thanks for the excellent debugging. Your patch seems to work, however it might be better to do just this: This can be racy if two drivers are simultaneously trying to request an IRQ. 'data' must be unique to different threads if they are to avoid interfering with each other. -- Russell King Linux kernel2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2.6.13-rc3] pcmcia: pcmcia_request_irq for !IRQ_HANDLE_PRESENT
On Sun, Jul 24, 2005 at 12:40:40PM +0100, Russell King wrote: On Sat, Jul 23, 2005 at 10:11:13PM +0200, Dominik Brodowski wrote: Thanks for the excellent debugging. Your patch seems to work, however it might be better to do just this: This can be racy if two drivers are simultaneously trying to request an IRQ. 'data' must be unique to different threads if they are to avoid interfering with each other. As it's enough to keep PCMCIA functions apart (there can't be two drivers registering with the same PCMCIA function at the same moment), I'll use that now. void *data = p_dev-dev.driver; /* something unique to this device */ Thanks, Dominik - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2.6.13-rc3] pcmcia: pcmcia_request_irq for !IRQ_HANDLE_PRESENT
Hi,
> When a driver calls pcmcia_request_irq with IRQ_HANDLE_PRESENT unset, it looks
> for an open IRQ by request_irq()ing with a dummy handler and NULL dev_info.
> free_irq uses dev_info as a key for identifying the handler to free among
> those
> sharing an IRQ, so request_irq returns -EINVAL if dev_info is NULL and the IRQ
> may be shared. That unknown error code is the -EINVAL.
>
> It looks like only pcnet_cs and axnet_cs are affected. Most other drivers let
> pcmcia_request_irq install their interrupt handlers. sym53c500_cs requests
> its
> IRQ manually, but it cannot share an IRQ.
>
> The appended patch changes pcmcia_request_irq to pass an arbitrary, unique,
> non-NULL dev_info with the dummy handler.
Thanks for the excellent debugging. Your patch seems to work, however it
might be better to do just this:
Index: 2.6.13-rc3-git2/drivers/pcmcia/pcmcia_resource.c
===
--- 2.6.13-rc3-git2.orig/drivers/pcmcia/pcmcia_resource.c
+++ 2.6.13-rc3-git2/drivers/pcmcia/pcmcia_resource.c
@@ -800,7 +800,7 @@ int pcmcia_request_irq(struct pcmcia_dev
} else {
int try;
u32 mask = s->irq_mask;
- void *data = NULL;
+ void *data = test_action;
for (try = 0; try < 64; try++) {
irq = try % 32;
Thanks,
Dominik
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2.6.13-rc3] pcmcia: pcmcia_request_irq for !IRQ_HANDLE_PRESENT
Hi,
When a driver calls pcmcia_request_irq with IRQ_HANDLE_PRESENT unset, it looks
for an open IRQ by request_irq()ing with a dummy handler and NULL dev_info.
free_irq uses dev_info as a key for identifying the handler to free among
those
sharing an IRQ, so request_irq returns -EINVAL if dev_info is NULL and the IRQ
may be shared. That unknown error code is the -EINVAL.
It looks like only pcnet_cs and axnet_cs are affected. Most other drivers let
pcmcia_request_irq install their interrupt handlers. sym53c500_cs requests
its
IRQ manually, but it cannot share an IRQ.
The appended patch changes pcmcia_request_irq to pass an arbitrary, unique,
non-NULL dev_info with the dummy handler.
Thanks for the excellent debugging. Your patch seems to work, however it
might be better to do just this:
Index: 2.6.13-rc3-git2/drivers/pcmcia/pcmcia_resource.c
===
--- 2.6.13-rc3-git2.orig/drivers/pcmcia/pcmcia_resource.c
+++ 2.6.13-rc3-git2/drivers/pcmcia/pcmcia_resource.c
@@ -800,7 +800,7 @@ int pcmcia_request_irq(struct pcmcia_dev
} else {
int try;
u32 mask = s-irq_mask;
- void *data = NULL;
+ void *data = test_action;
for (try = 0; try 64; try++) {
irq = try % 32;
Thanks,
Dominik
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2.6.13-rc3] pcmcia: pcmcia_request_irq for !IRQ_HANDLE_PRESENT
Between 2.6.10 and 2.6.11, the kernel began to print this message when I
inserted my IBM Home and Away adapter (pcnet_cs) into an i82365 slot:
1.0: RequestIRQ: Unknown error code 0xffea
Initialization of the device then aborted; no `eth0' appeared. Another user
recently reported the same problem:
http://lists.infradead.org/pipermail/linux-pcmcia/2005-July/002151.html
I believe this change to pcmcia_request_irq brought about the problem:
http://linus.bkbits.net:8080/linux-2.5/diffs/drivers/pcmcia/[EMAIL
PROTECTED]|src/|src/drivers|src/drivers/pcmcia|hist/drivers/pcmcia/cs.c
When a driver calls pcmcia_request_irq with IRQ_HANDLE_PRESENT unset, it looks
for an open IRQ by request_irq()ing with a dummy handler and NULL dev_info.
free_irq uses dev_info as a key for identifying the handler to free among those
sharing an IRQ, so request_irq returns -EINVAL if dev_info is NULL and the IRQ
may be shared. That unknown error code is the -EINVAL.
It looks like only pcnet_cs and axnet_cs are affected. Most other drivers let
pcmcia_request_irq install their interrupt handlers. sym53c500_cs requests its
IRQ manually, but it cannot share an IRQ.
The appended patch changes pcmcia_request_irq to pass an arbitrary, unique,
non-NULL dev_info with the dummy handler.
Signed-off-by: Noah Misch <[EMAIL PROTECTED]>
--- pristine-linux-2.6.13-rc3/drivers/pcmcia/pcmcia_resource.c 2005-07-16
16:57:21.0 -0400
+++ rc3dbg/drivers/pcmcia/pcmcia_resource.c 2005-07-16 22:53:00.0
-0400
@@ -800,7 +800,7 @@ int pcmcia_request_irq(struct pcmcia_dev
} else {
int try;
u32 mask = s->irq_mask;
- void *data = NULL;
+ int data;
for (try = 0; try < 64; try++) {
irq = try % 32;
@@ -822,10 +822,10 @@ int pcmcia_request_irq(struct pcmcia_dev
(s->functions > 1) ||
(irq == s->pci_irq)) ? SA_SHIRQ : 0,
p_dev->dev.bus_id,
- (req->Attributes &
IRQ_HANDLE_PRESENT) ? req->Instance : data);
+ (req->Attributes &
IRQ_HANDLE_PRESENT) ? req->Instance : );
if (!ret) {
if (!(req->Attributes & IRQ_HANDLE_PRESENT))
- free_irq(irq, data);
+ free_irq(irq, );
break;
}
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2.6.13-rc3] pcmcia: pcmcia_request_irq for !IRQ_HANDLE_PRESENT
Between 2.6.10 and 2.6.11, the kernel began to print this message when I
inserted my IBM Home and Away adapter (pcnet_cs) into an i82365 slot:
1.0: RequestIRQ: Unknown error code 0xffea
Initialization of the device then aborted; no `eth0' appeared. Another user
recently reported the same problem:
http://lists.infradead.org/pipermail/linux-pcmcia/2005-July/002151.html
I believe this change to pcmcia_request_irq brought about the problem:
http://linus.bkbits.net:8080/linux-2.5/diffs/drivers/pcmcia/[EMAIL
PROTECTED]|src/|src/drivers|src/drivers/pcmcia|hist/drivers/pcmcia/cs.c
When a driver calls pcmcia_request_irq with IRQ_HANDLE_PRESENT unset, it looks
for an open IRQ by request_irq()ing with a dummy handler and NULL dev_info.
free_irq uses dev_info as a key for identifying the handler to free among those
sharing an IRQ, so request_irq returns -EINVAL if dev_info is NULL and the IRQ
may be shared. That unknown error code is the -EINVAL.
It looks like only pcnet_cs and axnet_cs are affected. Most other drivers let
pcmcia_request_irq install their interrupt handlers. sym53c500_cs requests its
IRQ manually, but it cannot share an IRQ.
The appended patch changes pcmcia_request_irq to pass an arbitrary, unique,
non-NULL dev_info with the dummy handler.
Signed-off-by: Noah Misch [EMAIL PROTECTED]
--- pristine-linux-2.6.13-rc3/drivers/pcmcia/pcmcia_resource.c 2005-07-16
16:57:21.0 -0400
+++ rc3dbg/drivers/pcmcia/pcmcia_resource.c 2005-07-16 22:53:00.0
-0400
@@ -800,7 +800,7 @@ int pcmcia_request_irq(struct pcmcia_dev
} else {
int try;
u32 mask = s-irq_mask;
- void *data = NULL;
+ int data;
for (try = 0; try 64; try++) {
irq = try % 32;
@@ -822,10 +822,10 @@ int pcmcia_request_irq(struct pcmcia_dev
(s-functions 1) ||
(irq == s-pci_irq)) ? SA_SHIRQ : 0,
p_dev-dev.bus_id,
- (req-Attributes
IRQ_HANDLE_PRESENT) ? req-Instance : data);
+ (req-Attributes
IRQ_HANDLE_PRESENT) ? req-Instance : data);
if (!ret) {
if (!(req-Attributes IRQ_HANDLE_PRESENT))
- free_irq(irq, data);
+ free_irq(irq, data);
break;
}
}
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
