Re: [PATCH 2.6.22 3/3] Add LED trigger to libata core
Tony Vroon wrote: The first user of ata_ac_issue_prot_with_ledtrigger, the ServerWorks Frodo/ Apple K2 driver. Used by the IDE LED trigger on G5 towers. Respin of an earlier patch, based on comments by Tejun Heo & Alan Cox. Just two comments. 1. IMHO, ata_qc_issue_prot_ledtrigger() without 'with' is good enough. This is just my personal preference. Feel free to ignore it. 2. Patch #1 and #2 should be merged. They're one logical change of adding ata_qc_issue_prot_with_ledtrigger(). Patch #3 is a logically separate change of using it, but unless it's a wide conversion, implementing something and using something can be merged. So, please merge #1 and #2 and possibly #3. Thanks. -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2.6.22 3/3] Add LED trigger to libata core
The first user of ata_ac_issue_prot_with_ledtrigger, the ServerWorks Frodo/ Apple K2 driver. Used by the IDE LED trigger on G5 towers. Respin of an earlier patch, based on comments by Tejun Heo & Alan Cox. Signed-off-by: Tony Vroon <[EMAIL PROTECTED]> --- linux-2.6/drivers/ata/sata_svw.c.orig 2007-03-19 20:58:20.0 + +++ linux-2.6/drivers/ata/sata_svw.c2007-03-19 20:58:35.0 + @@ -348,7 +348,7 @@ .bmdma_stop = ata_bmdma_stop, .bmdma_status = ata_bmdma_status, .qc_prep= ata_qc_prep, - .qc_issue = ata_qc_issue_prot, + .qc_issue = ata_qc_issue_prot_with_ledtrigger, .data_xfer = ata_data_xfer, .freeze = ata_bmdma_freeze, .thaw = ata_bmdma_thaw, - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
