Re: [PATCH 20/24] rtc: rtc-sh: use module_platform_driver_probe()

2013-03-04 Thread Paul Mundt
On Mon, Mar 04, 2013 at 05:05:34PM +0900, Jingoo Han wrote:
> This patch uses module_platform_driver_probe() macro which makes
> the code smaller and simpler.
> 
> Signed-off-by: Jingoo Han 

Not sure I see the point, but:

Acked-by: Paul Mundt 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 20/24] rtc: rtc-sh: use module_platform_driver_probe()

2013-03-04 Thread Jingoo Han
This patch uses module_platform_driver_probe() macro which makes
the code smaller and simpler.

Signed-off-by: Jingoo Han 
---
 drivers/rtc/rtc-sh.c |   13 +
 1 files changed, 1 insertions(+), 12 deletions(-)

diff --git a/drivers/rtc/rtc-sh.c b/drivers/rtc/rtc-sh.c
index e55a763..5f47085 100644
--- a/drivers/rtc/rtc-sh.c
+++ b/drivers/rtc/rtc-sh.c
@@ -820,18 +820,7 @@ static struct platform_driver sh_rtc_platform_driver = {
.remove = __exit_p(sh_rtc_remove),
 };
 
-static int __init sh_rtc_init(void)
-{
-   return platform_driver_probe(_rtc_platform_driver, sh_rtc_probe);
-}
-
-static void __exit sh_rtc_exit(void)
-{
-   platform_driver_unregister(_rtc_platform_driver);
-}
-
-module_init(sh_rtc_init);
-module_exit(sh_rtc_exit);
+module_platform_driver_probe(sh_rtc_platform_driver, sh_rtc_probe);
 
 MODULE_DESCRIPTION("SuperH on-chip RTC driver");
 MODULE_VERSION(DRV_VERSION);
-- 
1.7.2.5


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 20/24] rtc: rtc-sh: use module_platform_driver_probe()

2013-03-04 Thread Jingoo Han
This patch uses module_platform_driver_probe() macro which makes
the code smaller and simpler.

Signed-off-by: Jingoo Han jg1@samsung.com
---
 drivers/rtc/rtc-sh.c |   13 +
 1 files changed, 1 insertions(+), 12 deletions(-)

diff --git a/drivers/rtc/rtc-sh.c b/drivers/rtc/rtc-sh.c
index e55a763..5f47085 100644
--- a/drivers/rtc/rtc-sh.c
+++ b/drivers/rtc/rtc-sh.c
@@ -820,18 +820,7 @@ static struct platform_driver sh_rtc_platform_driver = {
.remove = __exit_p(sh_rtc_remove),
 };
 
-static int __init sh_rtc_init(void)
-{
-   return platform_driver_probe(sh_rtc_platform_driver, sh_rtc_probe);
-}
-
-static void __exit sh_rtc_exit(void)
-{
-   platform_driver_unregister(sh_rtc_platform_driver);
-}
-
-module_init(sh_rtc_init);
-module_exit(sh_rtc_exit);
+module_platform_driver_probe(sh_rtc_platform_driver, sh_rtc_probe);
 
 MODULE_DESCRIPTION(SuperH on-chip RTC driver);
 MODULE_VERSION(DRV_VERSION);
-- 
1.7.2.5


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 20/24] rtc: rtc-sh: use module_platform_driver_probe()

2013-03-04 Thread Paul Mundt
On Mon, Mar 04, 2013 at 05:05:34PM +0900, Jingoo Han wrote:
 This patch uses module_platform_driver_probe() macro which makes
 the code smaller and simpler.
 
 Signed-off-by: Jingoo Han jg1@samsung.com

Not sure I see the point, but:

Acked-by: Paul Mundt let...@linux-sh.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/