Re: [PATCH 22/23] watchdog: sunxi_wdt: Use 'dev' instead of dereferencing it repeatedly

[Maxime Ripard]

On Tue, Apr 09, 2019 at 10:24:00AM -0700, Guenter Roeck wrote:
> Introduce local variable 'struct device *dev' and use it instead of
> dereferencing it repeatedly.
>
> The conversion was done automatically with coccinelle using the
> following semantic patches. The semantic patches and the scripts
> used to generate this commit log are available at
> https://github.com/groeck/coccinelle-patches
>
> Cc: Maxime Ripard 
> Cc: Chen-Yu Tsai 
> Signed-off-by: Guenter Roeck 

Acked-by: Maxime Ripard 

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


signature.asc
Description: PGP signature

[PATCH 22/23] watchdog: sunxi_wdt: Use 'dev' instead of dereferencing it repeatedly

[Guenter Roeck]

Introduce local variable 'struct device *dev' and use it instead of
dereferencing it repeatedly.

The conversion was done automatically with coccinelle using the
following semantic patches. The semantic patches and the scripts
used to generate this commit log are available at
https://github.com/groeck/coccinelle-patches

Cc: Maxime Ripard 
Cc: Chen-Yu Tsai 
Signed-off-by: Guenter Roeck 
---
 drivers/watchdog/sunxi_wdt.c | 15 ---
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/drivers/watchdog/sunxi_wdt.c b/drivers/watchdog/sunxi_wdt.c
index f0e7ef40b1e4..9c22f7753c6b 100644
--- a/drivers/watchdog/sunxi_wdt.c
+++ b/drivers/watchdog/sunxi_wdt.c
@@ -233,14 +233,15 @@ MODULE_DEVICE_TABLE(of, sunxi_wdt_dt_ids);
 
 static int sunxi_wdt_probe(struct platform_device *pdev)
 {
+   struct device *dev = >dev;
struct sunxi_wdt_dev *sunxi_wdt;
int err;
 
-   sunxi_wdt = devm_kzalloc(>dev, sizeof(*sunxi_wdt), GFP_KERNEL);
+   sunxi_wdt = devm_kzalloc(dev, sizeof(*sunxi_wdt), GFP_KERNEL);
if (!sunxi_wdt)
return -EINVAL;
 
-   sunxi_wdt->wdt_regs = of_device_get_match_data(>dev);
+   sunxi_wdt->wdt_regs = of_device_get_match_data(dev);
if (!sunxi_wdt->wdt_regs)
return -ENODEV;
 
@@ -253,9 +254,9 @@ static int sunxi_wdt_probe(struct platform_device *pdev)
sunxi_wdt->wdt_dev.timeout = WDT_MAX_TIMEOUT;
sunxi_wdt->wdt_dev.max_timeout = WDT_MAX_TIMEOUT;
sunxi_wdt->wdt_dev.min_timeout = WDT_MIN_TIMEOUT;
-   sunxi_wdt->wdt_dev.parent = >dev;
+   sunxi_wdt->wdt_dev.parent = dev;
 
-   watchdog_init_timeout(_wdt->wdt_dev, timeout, >dev);
+   watchdog_init_timeout(_wdt->wdt_dev, timeout, dev);
watchdog_set_nowayout(_wdt->wdt_dev, nowayout);
watchdog_set_restart_priority(_wdt->wdt_dev, 128);
 
@@ -264,12 +265,12 @@ static int sunxi_wdt_probe(struct platform_device *pdev)
sunxi_wdt_stop(_wdt->wdt_dev);
 
watchdog_stop_on_reboot(_wdt->wdt_dev);
-   err = devm_watchdog_register_device(>dev, _wdt->wdt_dev);
+   err = devm_watchdog_register_device(dev, _wdt->wdt_dev);
if (unlikely(err))
return err;
 
-   dev_info(>dev, "Watchdog enabled (timeout=%d sec, nowayout=%d)",
-   sunxi_wdt->wdt_dev.timeout, nowayout);
+   dev_info(dev, "Watchdog enabled (timeout=%d sec, nowayout=%d)",
+sunxi_wdt->wdt_dev.timeout, nowayout);
 
return 0;
 }
-- 
2.7.4