Re: [PATCH 23/32] softirq: Remove stale comment

2019-02-27 Thread Frederic Weisbecker 
On Wed, Feb 27, 2019 at 12:04:04PM +0100, Sebastian Andrzej Siewior wrote:
> On 2019-02-12 18:14:14 [+0100], Frederic Weisbecker wrote:
> > __local_bh_disable_ip() is neither for strict internal use nor does it
> > require the caller to disable hardirqs. Probaby a celebration for ancient
> 
> Probaby
> 
> > behaviour.
> 
> I think the point was to override the IP for the tracer. So everyone
> else used local_bh_disable() and was recorded as the caller except for
> softirq.c internal usage where __do_softirq() did also
> "local_bh_disable()" but recorded its caller (instead recording
> __do_softirq()).

Looks so. Anyway now it's also used by locking functions that need to pass
their own callers. So the comment is stale.

Re: [PATCH 23/32] softirq: Remove stale comment

2019-02-27 Thread Sebastian Andrzej Siewior 
On 2019-02-12 18:14:14 [+0100], Frederic Weisbecker wrote:
> __local_bh_disable_ip() is neither for strict internal use nor does it
> require the caller to disable hardirqs. Probaby a celebration for ancient

Probaby

> behaviour.

I think the point was to override the IP for the tracer. So everyone
else used local_bh_disable() and was recorded as the caller except for
softirq.c internal usage where __do_softirq() did also
"local_bh_disable()" but recorded its caller (instead recording
__do_softirq()).

Sebastian

[PATCH 23/32] softirq: Remove stale comment

2019-02-12 Thread Frederic Weisbecker 
__local_bh_disable_ip() is neither for strict internal use nor does it
require the caller to disable hardirqs. Probaby a celebration for ancient
behaviour.

Signed-off-by: Frederic Weisbecker 
Cc: Mauro Carvalho Chehab 
Cc: Joel Fernandes 
Cc: Thomas Gleixner 
Cc: Pavan Kondeti 
Cc: Paul E . McKenney 
Cc: David S . Miller 
Cc: Ingo Molnar 
Cc: Sebastian Andrzej Siewior 
Cc: Linus Torvalds 
Cc: Peter Zijlstra 
---
 kernel/softirq.c | 4 
 1 file changed, 4 deletions(-)

diff --git a/kernel/softirq.c b/kernel/softirq.c
index a2257a5aaa0b..5fea9e299caf 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -102,10 +102,6 @@ static bool ksoftirqd_running(unsigned long pending)
  * softirq and whether we just have bh disabled.
  */
 
-/*
- * This one is for softirq.c-internal use,
- * where hardirqs are disabled legitimately:
- */
 #ifdef CONFIG_TRACE_IRQFLAGS
 void __local_bh_disable_ip(unsigned long ip, unsigned int cnt)
 {
-- 
2.17.1