Re: [PATCH 26/27] [AARCH64] Change type of __align to long long

2016-07-06 Thread Andreas Schwab 
"Zhangjian (Bamvor)"  writes:

> Hi, Yury
>
> On 2016/6/21 13:07, Yury Norov wrote:
>> From: Andrew Pinski 
>>
>> So that ILP32 is aligned to 64bits.
>>
>> Signed-off-by: Yury Norov 
>> ---
>>   sysdeps/aarch64/nptl/bits/semaphore.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sysdeps/aarch64/nptl/bits/semaphore.h 
>> b/sysdeps/aarch64/nptl/bits/semaphore.h
>> index 3cc5b37..3fe6047 100644
>> --- a/sysdeps/aarch64/nptl/bits/semaphore.h
>> +++ b/sysdeps/aarch64/nptl/bits/semaphore.h
>> @@ -31,5 +31,5 @@
>>   typedef union
>>   {
>> char __size[__SIZEOF_SEM_T];
>> -  long int __align;
>> +  long long int __align;
> Why we need align to 64bit?

Because aarch64 defines __HAVE_64B_ATOMICS.

Andreas.

-- 
Andreas Schwab, SUSE Labs, sch...@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Re: [PATCH 26/27] [AARCH64] Change type of __align to long long

2016-07-06 Thread Andreas Schwab 
"Zhangjian (Bamvor)"  writes:

> Hi, Yury
>
> On 2016/6/21 13:07, Yury Norov wrote:
>> From: Andrew Pinski 
>>
>> So that ILP32 is aligned to 64bits.
>>
>> Signed-off-by: Yury Norov 
>> ---
>>   sysdeps/aarch64/nptl/bits/semaphore.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sysdeps/aarch64/nptl/bits/semaphore.h 
>> b/sysdeps/aarch64/nptl/bits/semaphore.h
>> index 3cc5b37..3fe6047 100644
>> --- a/sysdeps/aarch64/nptl/bits/semaphore.h
>> +++ b/sysdeps/aarch64/nptl/bits/semaphore.h
>> @@ -31,5 +31,5 @@
>>   typedef union
>>   {
>> char __size[__SIZEOF_SEM_T];
>> -  long int __align;
>> +  long long int __align;
> Why we need align to 64bit?

Because aarch64 defines __HAVE_64B_ATOMICS.

Andreas.

-- 
Andreas Schwab, SUSE Labs, sch...@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Re: [PATCH 26/27] [AARCH64] Change type of __align to long long

2016-06-21 Thread Zhangjian (Bamvor) 

Hi, Yury

On 2016/6/21 13:07, Yury Norov wrote:

From: Andrew Pinski 

So that ILP32 is aligned to 64bits.

Signed-off-by: Yury Norov 
---
  sysdeps/aarch64/nptl/bits/semaphore.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sysdeps/aarch64/nptl/bits/semaphore.h 
b/sysdeps/aarch64/nptl/bits/semaphore.h
index 3cc5b37..3fe6047 100644
--- a/sysdeps/aarch64/nptl/bits/semaphore.h
+++ b/sysdeps/aarch64/nptl/bits/semaphore.h
@@ -31,5 +31,5 @@
  typedef union
  {
char __size[__SIZEOF_SEM_T];
-  long int __align;
+  long long int __align;

Why we need align to 64bit?

Regard

Bamvor

  } sem_t;

Re: [PATCH 26/27] [AARCH64] Change type of __align to long long

2016-06-21 Thread Zhangjian (Bamvor) 

Hi, Yury

On 2016/6/21 13:07, Yury Norov wrote:

From: Andrew Pinski 

So that ILP32 is aligned to 64bits.

Signed-off-by: Yury Norov 
---
  sysdeps/aarch64/nptl/bits/semaphore.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sysdeps/aarch64/nptl/bits/semaphore.h 
b/sysdeps/aarch64/nptl/bits/semaphore.h
index 3cc5b37..3fe6047 100644
--- a/sysdeps/aarch64/nptl/bits/semaphore.h
+++ b/sysdeps/aarch64/nptl/bits/semaphore.h
@@ -31,5 +31,5 @@
  typedef union
  {
char __size[__SIZEOF_SEM_T];
-  long int __align;
+  long long int __align;

Why we need align to 64bit?

Regard

Bamvor

  } sem_t;

Re: [PATCH 26/27] [AARCH64] Change type of __align to long long

2016-06-21 Thread Andreas Schwab 
Yury Norov  writes:

> From: Andrew Pinski 
>
> So that ILP32 is aligned to 64bits.
>
> Signed-off-by: Yury Norov 
> ---
>  sysdeps/aarch64/nptl/bits/semaphore.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/aarch64/nptl/bits/semaphore.h 
> b/sysdeps/aarch64/nptl/bits/semaphore.h
> index 3cc5b37..3fe6047 100644
> --- a/sysdeps/aarch64/nptl/bits/semaphore.h
> +++ b/sysdeps/aarch64/nptl/bits/semaphore.h
> @@ -31,5 +31,5 @@
>  typedef union
>  {
>char __size[__SIZEOF_SEM_T];
> -  long int __align;
> +  long long int __align;
>  } sem_t;

Should __SIZEOF_SEM_T be reduced for ILP32?

Andreas.

-- 
Andreas Schwab, SUSE Labs, sch...@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Re: [PATCH 26/27] [AARCH64] Change type of __align to long long

2016-06-21 Thread Andreas Schwab 
Yury Norov  writes:

> From: Andrew Pinski 
>
> So that ILP32 is aligned to 64bits.
>
> Signed-off-by: Yury Norov 
> ---
>  sysdeps/aarch64/nptl/bits/semaphore.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/aarch64/nptl/bits/semaphore.h 
> b/sysdeps/aarch64/nptl/bits/semaphore.h
> index 3cc5b37..3fe6047 100644
> --- a/sysdeps/aarch64/nptl/bits/semaphore.h
> +++ b/sysdeps/aarch64/nptl/bits/semaphore.h
> @@ -31,5 +31,5 @@
>  typedef union
>  {
>char __size[__SIZEOF_SEM_T];
> -  long int __align;
> +  long long int __align;
>  } sem_t;

Should __SIZEOF_SEM_T be reduced for ILP32?

Andreas.

-- 
Andreas Schwab, SUSE Labs, sch...@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

[PATCH 26/27] [AARCH64] Change type of __align to long long

2016-06-20 Thread Yury Norov 
From: Andrew Pinski 

So that ILP32 is aligned to 64bits.

Signed-off-by: Yury Norov 
---
 sysdeps/aarch64/nptl/bits/semaphore.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sysdeps/aarch64/nptl/bits/semaphore.h 
b/sysdeps/aarch64/nptl/bits/semaphore.h
index 3cc5b37..3fe6047 100644
--- a/sysdeps/aarch64/nptl/bits/semaphore.h
+++ b/sysdeps/aarch64/nptl/bits/semaphore.h
@@ -31,5 +31,5 @@
 typedef union
 {
   char __size[__SIZEOF_SEM_T];
-  long int __align;
+  long long int __align;
 } sem_t;
-- 
2.7.4

[PATCH 26/27] [AARCH64] Change type of __align to long long

2016-06-20 Thread Yury Norov 
From: Andrew Pinski 

So that ILP32 is aligned to 64bits.

Signed-off-by: Yury Norov 
---
 sysdeps/aarch64/nptl/bits/semaphore.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sysdeps/aarch64/nptl/bits/semaphore.h 
b/sysdeps/aarch64/nptl/bits/semaphore.h
index 3cc5b37..3fe6047 100644
--- a/sysdeps/aarch64/nptl/bits/semaphore.h
+++ b/sysdeps/aarch64/nptl/bits/semaphore.h
@@ -31,5 +31,5 @@
 typedef union
 {
   char __size[__SIZEOF_SEM_T];
-  long int __align;
+  long long int __align;
 } sem_t;
-- 
2.7.4