Re: [PATCH 26/42] drivers: gpio: rcar: pendantic formatting

2019-04-02 Thread Linus Walleij
On Tue, Mar 12, 2019 at 1:56 AM Enrico Weigelt, metux IT consult
 wrote:

> a tab sneaked in, where it shouldn't be.
>
> Signed-off-by: Enrico Weigelt, metux IT consult 

Waiting for a new version of this patch.

Yours,
Linus Walleij


Re: [PATCH 26/42] drivers: gpio: rcar: pendantic formatting

2019-03-12 Thread Thierry Reding
On Mon, Mar 11, 2019 at 07:55:05PM +0100, Enrico Weigelt, metux IT consult 
wrote:
> a tab sneaked in, where it shouldn't be.

Pedantic nitpick: "pendantic" -> "pedantic" in the subject, and start
the commit message with a capital letter: "A tab sneaked in [...]".

Thierry


signature.asc
Description: PGP signature


[PATCH 26/42] drivers: gpio: rcar: pendantic formatting

2019-03-11 Thread Enrico Weigelt, metux IT consult
a tab sneaked in, where it shouldn't be.

Signed-off-by: Enrico Weigelt, metux IT consult 
---
 drivers/gpio/gpio-rcar.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
index 500a359..df4419e 100644
--- a/drivers/gpio/gpio-rcar.c
+++ b/drivers/gpio/gpio-rcar.c
@@ -490,7 +490,7 @@ static int gpio_rcar_probe(struct platform_device *pdev)
irq_chip->irq_unmask = gpio_rcar_irq_enable;
irq_chip->irq_set_type = gpio_rcar_irq_set_type;
irq_chip->irq_set_wake = gpio_rcar_irq_set_wake;
-   irq_chip->flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_MASK_ON_SUSPEND;
+   irq_chip->flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_MASK_ON_SUSPEND;
 
ret = gpiochip_add_data(gpio_chip, p);
if (ret) {
-- 
1.9.1