Re: [PATCH 27/40] drm/ttm/ttm_device: Demote kernel-doc abuses
On Fri, Apr 16, 2021 at 05:32:52PM +0200, Christian König wrote: > Am 16.04.21 um 16:37 schrieb Lee Jones: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/ttm/ttm_device.c:42: warning: Function parameter or > > member 'ttm_global_mutex' not described in 'DEFINE_MUTEX' > > drivers/gpu/drm/ttm/ttm_device.c:42: warning: expecting prototype for > > ttm_global_mutex(). Prototype was for DEFINE_MUTEX() instead > > drivers/gpu/drm/ttm/ttm_device.c:112: warning: Function parameter or > > member 'ctx' not described in 'ttm_global_swapout' > > drivers/gpu/drm/ttm/ttm_device.c:112: warning: Function parameter or > > member 'gfp_flags' not described in 'ttm_global_swapout' > > drivers/gpu/drm/ttm/ttm_device.c:112: warning: expecting prototype for A > > buffer object shrink method that tries to swap out the first(). Prototype > > was for ttm_global_swapout() instead > > > > Cc: Christian Koenig > > Cc: Huang Rui > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: dri-de...@lists.freedesktop.org > > Signed-off-by: Lee Jones > > Reviewed-by: Christian König Can you pls also land all the patches you reviewed from Lee into drm-misc-next? Just so they wont' get lost. Will all head in for 5.14. -Daniel > > > --- > > drivers/gpu/drm/ttm/ttm_device.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/ttm/ttm_device.c > > b/drivers/gpu/drm/ttm/ttm_device.c > > index 9b787b3caeb50..a8bec8358350d 100644 > > --- a/drivers/gpu/drm/ttm/ttm_device.c > > +++ b/drivers/gpu/drm/ttm/ttm_device.c > > @@ -36,7 +36,7 @@ > > #include "ttm_module.h" > > -/** > > +/* > >* ttm_global_mutex - protecting the global state > >*/ > > DEFINE_MUTEX(ttm_global_mutex); > > @@ -104,7 +104,7 @@ static int ttm_global_init(void) > > return ret; > > } > > -/** > > +/* > >* A buffer object shrink method that tries to swap out the first > >* buffer object on the global::swap_lru list. > >*/ > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Re: [PATCH 27/40] drm/ttm/ttm_device: Demote kernel-doc abuses
Am 16.04.21 um 16:37 schrieb Lee Jones: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/ttm/ttm_device.c:42: warning: Function parameter or member 'ttm_global_mutex' not described in 'DEFINE_MUTEX' drivers/gpu/drm/ttm/ttm_device.c:42: warning: expecting prototype for ttm_global_mutex(). Prototype was for DEFINE_MUTEX() instead drivers/gpu/drm/ttm/ttm_device.c:112: warning: Function parameter or member 'ctx' not described in 'ttm_global_swapout' drivers/gpu/drm/ttm/ttm_device.c:112: warning: Function parameter or member 'gfp_flags' not described in 'ttm_global_swapout' drivers/gpu/drm/ttm/ttm_device.c:112: warning: expecting prototype for A buffer object shrink method that tries to swap out the first(). Prototype was for ttm_global_swapout() instead Cc: Christian Koenig Cc: Huang Rui Cc: David Airlie Cc: Daniel Vetter Cc: dri-de...@lists.freedesktop.org Signed-off-by: Lee Jones Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_device.c b/drivers/gpu/drm/ttm/ttm_device.c index 9b787b3caeb50..a8bec8358350d 100644 --- a/drivers/gpu/drm/ttm/ttm_device.c +++ b/drivers/gpu/drm/ttm/ttm_device.c @@ -36,7 +36,7 @@ #include "ttm_module.h" -/** +/* * ttm_global_mutex - protecting the global state */ DEFINE_MUTEX(ttm_global_mutex); @@ -104,7 +104,7 @@ static int ttm_global_init(void) return ret; } -/** +/* * A buffer object shrink method that tries to swap out the first * buffer object on the global::swap_lru list. */
[PATCH 27/40] drm/ttm/ttm_device: Demote kernel-doc abuses
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/ttm/ttm_device.c:42: warning: Function parameter or member 'ttm_global_mutex' not described in 'DEFINE_MUTEX' drivers/gpu/drm/ttm/ttm_device.c:42: warning: expecting prototype for ttm_global_mutex(). Prototype was for DEFINE_MUTEX() instead drivers/gpu/drm/ttm/ttm_device.c:112: warning: Function parameter or member 'ctx' not described in 'ttm_global_swapout' drivers/gpu/drm/ttm/ttm_device.c:112: warning: Function parameter or member 'gfp_flags' not described in 'ttm_global_swapout' drivers/gpu/drm/ttm/ttm_device.c:112: warning: expecting prototype for A buffer object shrink method that tries to swap out the first(). Prototype was for ttm_global_swapout() instead Cc: Christian Koenig Cc: Huang Rui Cc: David Airlie Cc: Daniel Vetter Cc: dri-de...@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/ttm/ttm_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_device.c b/drivers/gpu/drm/ttm/ttm_device.c index 9b787b3caeb50..a8bec8358350d 100644 --- a/drivers/gpu/drm/ttm/ttm_device.c +++ b/drivers/gpu/drm/ttm/ttm_device.c @@ -36,7 +36,7 @@ #include "ttm_module.h" -/** +/* * ttm_global_mutex - protecting the global state */ DEFINE_MUTEX(ttm_global_mutex); @@ -104,7 +104,7 @@ static int ttm_global_init(void) return ret; } -/** +/* * A buffer object shrink method that tries to swap out the first * buffer object on the global::swap_lru list. */ -- 2.27.0
