Re: [PATCH 3/3] Altix: Add ACPI SSDT PCI device support (hotplug)

2007-01-29 Thread Greg KH
On Sat, Jan 27, 2007 at 02:04:43AM -0500, Len Brown wrote:
> From: John Keller <[EMAIL PROTECTED]>
> 
> Support for dynamic loading and unloading of ACPI SSDT tables upon slot
> hotplugs and unplugs.
> 
> On SN platforms, we now represent every populated root bus slot with a single
> ACPI SSDT table containing info for every device and PPB attached to the slot.
>  These SSDTs are generated by the prom at initial boot and hotplug time.  The
> info in these SSDT tables is used by the SN kernel IO "fixup" code (which is
> called at boot and hotplug time).
> 
> On hotplugs (i.e.  enable_slot()), if running with an ACPI capable prom,
> attempt to obtain a new ACPI SSDT table for the slot being hotplugged.  If
> successful, add the table to the ACPI namespace (acpi_load_table()) and then
> walk the new devices and add them to the ACPI infrastructure (acpi_bus_add()).
> 
> On hot unplugs (i.e.  disable_slot()), if running with an ACPI capable prom,
> attempt to remove the SSDT table associated with the slot from the ACPI
> namespace (acpi_unload_table_id()) and infastructure (acpi_bus_trim()).
> 
> From: John Keller <[EMAIL PROTECTED]>
> 
>  A bug was fixed where the sgi hotplug driver was removing
>  the slot's SSDT table from the ACPI namespace a bit too early in
>  disable_slot(). Also, we now call acpi_bus_start() subsequent
>  to acpi_bus_add().
> 
> Signed-off-by: Aaron Young <[EMAIL PROTECTED]>
> Cc: Greg KH <[EMAIL PROTECTED]>

This should go through Kristen, as she is now the pci hotplug
maintainer, not I.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 3/3] Altix: Add ACPI SSDT PCI device support (hotplug)

2007-01-26 Thread Len Brown
From: John Keller <[EMAIL PROTECTED]>

Support for dynamic loading and unloading of ACPI SSDT tables upon slot
hotplugs and unplugs.

On SN platforms, we now represent every populated root bus slot with a single
ACPI SSDT table containing info for every device and PPB attached to the slot.
 These SSDTs are generated by the prom at initial boot and hotplug time.  The
info in these SSDT tables is used by the SN kernel IO "fixup" code (which is
called at boot and hotplug time).

On hotplugs (i.e.  enable_slot()), if running with an ACPI capable prom,
attempt to obtain a new ACPI SSDT table for the slot being hotplugged.  If
successful, add the table to the ACPI namespace (acpi_load_table()) and then
walk the new devices and add them to the ACPI infrastructure (acpi_bus_add()).

On hot unplugs (i.e.  disable_slot()), if running with an ACPI capable prom,
attempt to remove the SSDT table associated with the slot from the ACPI
namespace (acpi_unload_table_id()) and infastructure (acpi_bus_trim()).

From: John Keller <[EMAIL PROTECTED]>

 A bug was fixed where the sgi hotplug driver was removing
 the slot's SSDT table from the ACPI namespace a bit too early in
 disable_slot(). Also, we now call acpi_bus_start() subsequent
 to acpi_bus_add().

Signed-off-by: Aaron Young <[EMAIL PROTECTED]>
Cc: Greg KH <[EMAIL PROTECTED]>
Cc: "Luck, Tony" <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Signed-off-by: Len Brown<[EMAIL PROTECTED]>
---

 drivers/pci/hotplug/sgi_hotplug.c |  155 ++--
 1 files changed, 148 insertions(+), 7 deletions(-)

Index: acpi/drivers/pci/hotplug/sgi_hotplug.c
===
--- acpi.orig/drivers/pci/hotplug/sgi_hotplug.c
+++ acpi/drivers/pci/hotplug/sgi_hotplug.c
@@ -28,6 +28,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 
 #include "../pci.h"
 
@@ -35,14 +37,17 @@ MODULE_LICENSE("GPL");
 MODULE_AUTHOR("SGI ([EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED])");
 MODULE_DESCRIPTION("SGI Altix Hot Plug PCI Controller Driver");
 
-#define PCIIO_ASIC_TYPE_TIOCA  4
+
+/* SAL call error codes. Keep in sync with prom header io/include/pcibr.h */
 #define PCI_SLOT_ALREADY_UP2   /* slot already up */
 #define PCI_SLOT_ALREADY_DOWN  3   /* slot already down */
 #define PCI_L1_ERR 7   /* L1 console command error */
 #define PCI_EMPTY_33MHZ15  /* empty 33 MHz bus */
+
+
+#define PCIIO_ASIC_TYPE_TIOCA  4
 #define PCI_L1_QSIZE   128 /* our L1 message buffer size */
 #define SN_MAX_HP_SLOTS32  /* max hotplug slots */
-#define SGI_HOTPLUG_PROM_REV   0x0430  /* Min. required PROM version */
 #define SN_SLOT_NAME_SIZE  33  /* size of name string */
 
 /* internal list head */
@@ -227,7 +232,7 @@ static void sn_bus_free_data(struct pci_
 }
 
 static int sn_slot_enable(struct hotplug_slot *bss_hotplug_slot,
- int device_num)
+ int device_num, char **ssdt)
 {
struct slot *slot = bss_hotplug_slot->private;
struct pcibus_info *pcibus_info;
@@ -240,7 +245,8 @@ static int sn_slot_enable(struct hotplug
 * Power-on and initialize the slot in the SN
 * PCI infrastructure.
 */
-   rc = sal_pcibr_slot_enable(pcibus_info, device_num, &resp);
+   rc = sal_pcibr_slot_enable(pcibus_info, device_num, &resp, ssdt);
+
 
if (rc == PCI_SLOT_ALREADY_UP) {
dev_dbg(slot->pci_bus->self, "is already active\n");
@@ -335,6 +341,7 @@ static int enable_slot(struct hotplug_sl
int func, num_funcs;
int new_ppb = 0;
int rc;
+   char *ssdt = NULL;
void pcibios_fixup_device_resources(struct pci_dev *);
 
/* Serialize the Linux PCI infrastructure */
@@ -342,14 +349,29 @@ static int enable_slot(struct hotplug_sl
 
/*
 * Power-on and initialize the slot in the SN
-* PCI infrastructure.
+* PCI infrastructure. Also, retrieve the ACPI SSDT
+* table for the slot (if ACPI capable PROM).
 */
-   rc = sn_slot_enable(bss_hotplug_slot, slot->device_num);
+   rc = sn_slot_enable(bss_hotplug_slot, slot->device_num, &ssdt);
if (rc) {
mutex_unlock(&sn_hotplug_mutex);
return rc;
}
 
+   if (ssdt)
+   ssdt = __va(ssdt);
+   /* Add the new SSDT for the slot to the ACPI namespace */
+   if (SN_ACPI_BASE_SUPPORT() && ssdt) {
+   acpi_status ret;
+
+   ret = acpi_load_table((struct acpi_table_header *)ssdt);
+   if (ACPI_FAILURE(ret)) {
+   printk(KERN_ERR "%s: acpi_load_table failed (0x%x)\n",
+  __FUNCTION__, ret);
+   /* try to continue on */
+   }
+   }
+
num_funcs = pci_scan