Re: [PATCH 3/3] arm64: dts: hi3660: Add hisi asp dma device

2019-01-03 Thread Rob Herring
On Fri, Dec 28, 2018 at 02:36:23PM +0800, h00249924 wrote:
> From: Youlin Wang 
> 
> Signed-off-by: John Stultz 
> Signed-off-by: Youlin Wang 
> Signed-off-by: Tanglei Han 
> Cc: Wei Xu 
> Cc: Rob Herring 
> Cc: Mark Rutland 
> ---
>  arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 14 ++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi 
> b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> index f432b0a..5223e36 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> @@ -1122,5 +1122,19 @@
>   };
>   };
>   };
> +
> + asp_dmac: asp_dmac@E804B000 {

dma-controller@e804b000

> + compatible = "hisilicon,hisi-pcm-asp-dma-1.0";
> + reg = <0x0 0xe804b000 0x0 0x1000>;
> + #dma-cells = <1>;
> + dma-channels = <16>;
> + dma-requests = <32>;
> + dma-min-chan = <0>;
> + dma-used-chans = <0xFFFE>;

Use lowercase hex.

But more importantly, as John mentioned, this and other properties 
aren't documented.

> + dma-share;
> + interrupts = <0 216 4>;
> + interrupt-names = "asp_dma_irq";
> + status = "ok";

Don't need this.

> + };
>   };
>  };
> -- 
> 1.9.1
> 


[PATCH 3/3] arm64: dts: hi3660: Add hisi asp dma device

2018-12-27 Thread h00249924
From: Youlin Wang 

Signed-off-by: John Stultz 
Signed-off-by: Youlin Wang 
Signed-off-by: Tanglei Han 
Cc: Wei Xu 
Cc: Rob Herring 
Cc: Mark Rutland 
---
 arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 14 ++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi 
b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
index f432b0a..5223e36 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
@@ -1122,5 +1122,19 @@
};
};
};
+
+   asp_dmac: asp_dmac@E804B000 {
+   compatible = "hisilicon,hisi-pcm-asp-dma-1.0";
+   reg = <0x0 0xe804b000 0x0 0x1000>;
+   #dma-cells = <1>;
+   dma-channels = <16>;
+   dma-requests = <32>;
+   dma-min-chan = <0>;
+   dma-used-chans = <0xFFFE>;
+   dma-share;
+   interrupts = <0 216 4>;
+   interrupt-names = "asp_dma_irq";
+   status = "ok";
+   };
};
 };
-- 
1.9.1