Re: [PATCH 3/3] crypto: s5p-sss - Pass error from clk_get and reduce verbosity on deferral

2020-09-11 Thread Herbert Xu 
On Thu, Sep 03, 2020 at 08:04:00PM +0200, Krzysztof Kozlowski wrote:
> Pass the error directly from devm_clk_get() to describe the real reason,
> instead of fixed ENOENT.  Do not print error messages on deferred probe.
> 
> Signed-off-by: Krzysztof Kozlowski 
> ---
>  drivers/crypto/s5p-sss.c | 15 +++
>  1 file changed, 7 insertions(+), 8 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 3/3] crypto: s5p-sss - Pass error from clk_get and reduce verbosity on deferral

2020-09-04 Thread Kamil Konieczny 



On 9/3/20 8:04 PM, Krzysztof Kozlowski wrote:
> Pass the error directly from devm_clk_get() to describe the real reason,
> instead of fixed ENOENT.  Do not print error messages on deferred probe.
> 
> Signed-off-by: Krzysztof Kozlowski 
> ---
>  drivers/crypto/s5p-sss.c | 15 +++
>  1 file changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> index f67f1e22ecd1..e83145c43b18 100644
> --- a/drivers/crypto/s5p-sss.c
> +++ b/drivers/crypto/s5p-sss.c
> @@ -2201,11 +2201,10 @@ static int s5p_aes_probe(struct platform_device *pdev)
>   }
>  
>   pdata->clk = devm_clk_get(dev, variant->clk_names[0]);
> - if (IS_ERR(pdata->clk)) {
> - dev_err(dev, "failed to find secss clock %s\n",
> - variant->clk_names[0]);
> - return -ENOENT;
> - }
> + if (IS_ERR(pdata->clk))
> + return dev_err_probe(dev, PTR_ERR(pdata->clk),
> +  "failed to find secss clock %s\n",
> +  variant->clk_names[0]);
>  
>   err = clk_prepare_enable(pdata->clk);
>   if (err < 0) {
> @@ -2217,9 +2216,9 @@ static int s5p_aes_probe(struct platform_device *pdev)
>   if (variant->clk_names[1]) {
>   pdata->pclk = devm_clk_get(dev, variant->clk_names[1]);
>   if (IS_ERR(pdata->pclk)) {
> - dev_err(dev, "failed to find clock %s\n",
> - variant->clk_names[1]);
> - err = -ENOENT;
> + err = dev_err_probe(dev, PTR_ERR(pdata->pclk),
> + "failed to find clock %s\n",
> + variant->clk_names[1]);
>   goto err_clk;
>   }
>  
> 

Reviewed-by: Kamil Konieczny 
Acked-by: Kamil Konieczny

[PATCH 3/3] crypto: s5p-sss - Pass error from clk_get and reduce verbosity on deferral

2020-09-03 Thread Krzysztof Kozlowski 
Pass the error directly from devm_clk_get() to describe the real reason,
instead of fixed ENOENT.  Do not print error messages on deferred probe.

Signed-off-by: Krzysztof Kozlowski 
---
 drivers/crypto/s5p-sss.c | 15 +++
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index f67f1e22ecd1..e83145c43b18 100644
--- a/drivers/crypto/s5p-sss.c
+++ b/drivers/crypto/s5p-sss.c
@@ -2201,11 +2201,10 @@ static int s5p_aes_probe(struct platform_device *pdev)
}
 
pdata->clk = devm_clk_get(dev, variant->clk_names[0]);
-   if (IS_ERR(pdata->clk)) {
-   dev_err(dev, "failed to find secss clock %s\n",
-   variant->clk_names[0]);
-   return -ENOENT;
-   }
+   if (IS_ERR(pdata->clk))
+   return dev_err_probe(dev, PTR_ERR(pdata->clk),
+"failed to find secss clock %s\n",
+variant->clk_names[0]);
 
err = clk_prepare_enable(pdata->clk);
if (err < 0) {
@@ -2217,9 +2216,9 @@ static int s5p_aes_probe(struct platform_device *pdev)
if (variant->clk_names[1]) {
pdata->pclk = devm_clk_get(dev, variant->clk_names[1]);
if (IS_ERR(pdata->pclk)) {
-   dev_err(dev, "failed to find clock %s\n",
-   variant->clk_names[1]);
-   err = -ENOENT;
+   err = dev_err_probe(dev, PTR_ERR(pdata->pclk),
+   "failed to find clock %s\n",
+   variant->clk_names[1]);
goto err_clk;
}
 
-- 
2.17.1