Re: [PATCH 3/3] soc: ixp4xx: Hide auto-selected drivers
On Fri, Jul 12, 2019 at 3:57 PM Jean Delvare wrote: > The 2 IXP4xx SOC drivers qmgr and npe are selected automatically when > needed so they do not need to be presented to the user. > > Furthermore these helper drivers are specific to the IXP4xx arch so > hide them completely on other architectures so as to not clutter the > config file. > > Signed-off-by: Jean Delvare > Cc: Krzysztof Halasa > Cc: Linus Walleij > --- > Note: Ultimately all I want is that non-ixp4xx users are not asked > about IXP4XX_QMGR and IXP4XX_NPE. If there is another preferred option > to achieve the same, that would work with me too, just let me know. Reviewed-by: Linus Walleij This is the right thing to do, sorry for not doing it like this to begin with. I'll queue it in my ixp4xx tree. Yours, Linus Walleij
[PATCH 3/3] soc: ixp4xx: Hide auto-selected drivers
The 2 IXP4xx SOC drivers qmgr and npe are selected automatically when needed so they do not need to be presented to the user. Furthermore these helper drivers are specific to the IXP4xx arch so hide them completely on other architectures so as to not clutter the config file. Signed-off-by: Jean Delvare Cc: Krzysztof Halasa Cc: Linus Walleij --- Note: Ultimately all I want is that non-ixp4xx users are not asked about IXP4XX_QMGR and IXP4XX_NPE. If there is another preferred option to achieve the same, that would work with me too, just let me know. drivers/soc/ixp4xx/Kconfig |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) --- linux-5.2.orig/drivers/soc/ixp4xx/Kconfig 2019-07-08 00:41:56.0 +0200 +++ linux-5.2/drivers/soc/ixp4xx/Kconfig2019-07-12 15:21:44.769229835 +0200 @@ -1,17 +1,19 @@ # SPDX-License-Identifier: GPL-2.0-only +if ARCH_IXP4XX menu "IXP4xx SoC drivers" config IXP4XX_QMGR - tristate "IXP4xx Queue Manager support" + tristate help This driver supports IXP4xx built-in hardware queue manager and is automatically selected by Ethernet and HSS drivers. config IXP4XX_NPE - tristate "IXP4xx Network Processor Engine support" + tristate select FW_LOADER help This driver supports IXP4xx built-in network coprocessors and is automatically selected by Ethernet and HSS drivers. endmenu +endif -- Jean Delvare SUSE L3 Support
