Re: [PATCH 3/4] misc: hpilo: Do not claim unsupported hardware
On Thu, Feb 21, 2019 at 09:35:15AM +0100, Greg KH wrote: > On Thu, Feb 21, 2019 at 04:04:41PM +0800, Matt Hsiao wrote: > > Do not claim when SSID 0x0289 as the iLO features > > are not enabled/validated by the firmware. > > Can you put more information here, like _what_ hardware is not being > supported anymore? As it is, this has nothing to do with "validation by > the firmware", you are just deciding to not support a device that > previously was supported by this driver. As such you should provide > more information why you are taking away functionality. Hi Greg, The SSID 0x0289 correspond to the recent CL2600/CL2800 servers. These servers leveraged Proliant hardware but are targeted to a different market segment with different requirements. They also come with a different firmware base. Based upon the targeted market needs, these server de-featured certain aspects of Proliants with this being one. As a result, the linux hpilo driver still claims the hardware but is not functional. We decided to blacklist the driver to reduce confusion to customers. Matt will update the documentation in the second version of the patch set. Hope this helps. Take care, Jerry -- - Jerry Hoemann Software Engineer Hewlett Packard Enterprise -
Re: [PATCH 3/4] misc: hpilo: Do not claim unsupported hardware
On Thu, Feb 21, 2019 at 04:04:41PM +0800, Matt Hsiao wrote: > Do not claim when SSID 0x0289 as the iLO features > are not enabled/validated by the firmware. Can you put more information here, like _what_ hardware is not being supported anymore? As it is, this has nothing to do with "validation by the firmware", you are just deciding to not support a device that previously was supported by this driver. As such you should provide more information why you are taking away functionality. thnaks, greg k-h
[PATCH 3/4] misc: hpilo: Do not claim unsupported hardware
Do not claim when SSID 0x0289 as the iLO features
are not enabled/validated by the firmware.
Signed-off-by: Matt Hsiao
---
drivers/misc/hpilo.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/misc/hpilo.c b/drivers/misc/hpilo.c
index 0224e50..927309b 100644
--- a/drivers/misc/hpilo.c
+++ b/drivers/misc/hpilo.c
@@ -32,6 +32,8 @@
static const struct pci_device_id ilo_blacklist[] = {
/* auxiliary iLO */
{PCI_DEVICE_SUB(PCI_VENDOR_ID_HP, 0x3307, PCI_VENDOR_ID_HP, 0x1979)},
+ /* CL */
+ {PCI_DEVICE_SUB(PCI_VENDOR_ID_HP, 0x3307, PCI_VENDOR_ID_HP_3PAR,
0x0289)},
{}
};
--
1.8.3.1
