split_huge_page() will never call on a page which isn't on lru list, so
this code never got a chance to run, and should not be run, to add tail
pages on a lru list which head page isn't there.
Although the bug was never triggered, it'better be removed for code
correctness.
BTW, it looks better to have a WARN() set in the wrong path, but the
path will be changed in incoming new page isolation func. So just save
it now.
Signed-off-by: Alex Shi <alex....@linux.alibaba.com>
Reviewed-by: Kirill A. Shutemov <kirill.shute...@linux.intel.com>
Cc: Kirill A. Shutemov <kir...@shutemov.name>
Cc: Andrew Morton <a...@linux-foundation.org>
Cc: Johannes Weiner <han...@cmpxchg.org>
Cc: Matthew Wilcox <wi...@infradead.org>
Cc: Hugh Dickins <hu...@google.com>
Cc: linux...@kvack.org
Cc: linux-kernel@vger.kernel.org
---
mm/huge_memory.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 8cecd39bd8b7..dfe7378ab4be 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -2332,16 +2332,6 @@ static void lru_add_page_tail(struct page *head, struct
page *page_tail,
/* page reclaim is reclaiming a huge page */
get_page(page_tail);
list_add_tail(&page_tail->lru, list);
- } else {
- /*
- * Head page has not yet been counted, as an hpage,
- * so we must account for each subpage individually.
- *
- * Put page_tail on the list at the correct position
- * so they all end up in order.
- */
- add_page_to_lru_list_tail(page_tail, lruvec,
- page_lru(page_tail));
}
}
--
1.8.3.1
