Re: [PATCH 3/5] media: videobuf2-core.h: add a helper to get status of start_streaming()

2014-09-08 Thread Hans Verkuil
On 09/06/2014 05:26 PM, Lad, Prabhakar wrote:
> this patch adds a helper to get the status if start_streaming()
> was called successfully.

Nice! I've had the same idea for quite some time now, but for some reason
I never got around to actually adding it.

Hans

> 
> Signed-off-by: Lad, Prabhakar 
> Cc: Pawel Osciak 
> Cc: Marek Szyprowski 
> Cc: Kyungmin Park 
> Cc: Hans Verkuil 
> ---
>  include/media/videobuf2-core.h | 9 +
>  1 file changed, 9 insertions(+)
> 
> diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h
> index 5a10d8d..b3c9973 100644
> --- a/include/media/videobuf2-core.h
> +++ b/include/media/videobuf2-core.h
> @@ -590,6 +590,15 @@ vb2_plane_size(struct vb2_buffer *vb, unsigned int 
> plane_no)
>   return 0;
>  }
>  
> +/**
> + * vb2_start_streaming_called() - return streaming status of driver
> + * @q:   videobuf queue
> + */
> +static inline bool vb2_start_streaming_called(struct vb2_queue *q)
> +{
> + return q->start_streaming_called;
> +}
> +
>  /*
>   * The following functions are not part of the vb2 core API, but are simple
>   * helper functions that you can use in your struct v4l2_file_operations,
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 3/5] media: videobuf2-core.h: add a helper to get status of start_streaming()

2014-09-08 Thread Hans Verkuil
On 09/06/2014 05:26 PM, Lad, Prabhakar wrote:
 this patch adds a helper to get the status if start_streaming()
 was called successfully.

Nice! I've had the same idea for quite some time now, but for some reason
I never got around to actually adding it.

Hans

 
 Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com
 Cc: Pawel Osciak pa...@osciak.com
 Cc: Marek Szyprowski m.szyprow...@samsung.com
 Cc: Kyungmin Park kyungmin.p...@samsung.com
 Cc: Hans Verkuil hans.verk...@cisco.com
 ---
  include/media/videobuf2-core.h | 9 +
  1 file changed, 9 insertions(+)
 
 diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h
 index 5a10d8d..b3c9973 100644
 --- a/include/media/videobuf2-core.h
 +++ b/include/media/videobuf2-core.h
 @@ -590,6 +590,15 @@ vb2_plane_size(struct vb2_buffer *vb, unsigned int 
 plane_no)
   return 0;
  }
  
 +/**
 + * vb2_start_streaming_called() - return streaming status of driver
 + * @q:   videobuf queue
 + */
 +static inline bool vb2_start_streaming_called(struct vb2_queue *q)
 +{
 + return q-start_streaming_called;
 +}
 +
  /*
   * The following functions are not part of the vb2 core API, but are simple
   * helper functions that you can use in your struct v4l2_file_operations,
 

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 3/5] media: videobuf2-core.h: add a helper to get status of start_streaming()

2014-09-06 Thread Lad, Prabhakar
this patch adds a helper to get the status if start_streaming()
was called successfully.

Signed-off-by: Lad, Prabhakar 
Cc: Pawel Osciak 
Cc: Marek Szyprowski 
Cc: Kyungmin Park 
Cc: Hans Verkuil 
---
 include/media/videobuf2-core.h | 9 +
 1 file changed, 9 insertions(+)

diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h
index 5a10d8d..b3c9973 100644
--- a/include/media/videobuf2-core.h
+++ b/include/media/videobuf2-core.h
@@ -590,6 +590,15 @@ vb2_plane_size(struct vb2_buffer *vb, unsigned int 
plane_no)
return 0;
 }
 
+/**
+ * vb2_start_streaming_called() - return streaming status of driver
+ * @q: videobuf queue
+ */
+static inline bool vb2_start_streaming_called(struct vb2_queue *q)
+{
+   return q->start_streaming_called;
+}
+
 /*
  * The following functions are not part of the vb2 core API, but are simple
  * helper functions that you can use in your struct v4l2_file_operations,
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 3/5] media: videobuf2-core.h: add a helper to get status of start_streaming()

2014-09-06 Thread Lad, Prabhakar
this patch adds a helper to get the status if start_streaming()
was called successfully.

Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Cc: Pawel Osciak pa...@osciak.com
Cc: Marek Szyprowski m.szyprow...@samsung.com
Cc: Kyungmin Park kyungmin.p...@samsung.com
Cc: Hans Verkuil hans.verk...@cisco.com
---
 include/media/videobuf2-core.h | 9 +
 1 file changed, 9 insertions(+)

diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h
index 5a10d8d..b3c9973 100644
--- a/include/media/videobuf2-core.h
+++ b/include/media/videobuf2-core.h
@@ -590,6 +590,15 @@ vb2_plane_size(struct vb2_buffer *vb, unsigned int 
plane_no)
return 0;
 }
 
+/**
+ * vb2_start_streaming_called() - return streaming status of driver
+ * @q: videobuf queue
+ */
+static inline bool vb2_start_streaming_called(struct vb2_queue *q)
+{
+   return q-start_streaming_called;
+}
+
 /*
  * The following functions are not part of the vb2 core API, but are simple
  * helper functions that you can use in your struct v4l2_file_operations,
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/