[PATCH 3.18 016/151] iwlwifi: mvm: always use mac color zero
3.18-stable review patch. If anyone has any objections, please let me know. -- From: Luciano Coelho commit 5523d11cc46393a1e61b7ef4a0b2d4e7ed9521e4 upstream. We don't really need to use different mac colors when adding mac contexts, because they're not used anywhere. In fact, the firmware doesn't accept 255 as a valid color, so we get into a SYSASSERT 0x3401 when we reach that. Remove the color increment to use always zero and avoid reaching 255. Signed-off-by: Luciano Coelho Reviewed-by: Johannes Berg Signed-off-by: Emmanuel Grumbach Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/iwlwifi/mvm/mac80211.c |3 --- 1 file changed, 3 deletions(-) --- a/drivers/net/wireless/iwlwifi/mvm/mac80211.c +++ b/drivers/net/wireless/iwlwifi/mvm/mac80211.c @@ -668,9 +668,6 @@ static void iwl_mvm_cleanup_iterator(voi mvmvif->uploaded = false; mvmvif->ap_sta_id = IWL_MVM_STATION_COUNT; - /* does this make sense at all? */ - mvmvif->color++; - spin_lock_bh(>time_event_lock); iwl_mvm_te_clear_data(mvm, >time_event_data); spin_unlock_bh(>time_event_lock); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 3.18 016/151] iwlwifi: mvm: always use mac color zero
3.18-stable review patch. If anyone has any objections, please let me know. -- From: Luciano Coelho luciano.coe...@intel.com commit 5523d11cc46393a1e61b7ef4a0b2d4e7ed9521e4 upstream. We don't really need to use different mac colors when adding mac contexts, because they're not used anywhere. In fact, the firmware doesn't accept 255 as a valid color, so we get into a SYSASSERT 0x3401 when we reach that. Remove the color increment to use always zero and avoid reaching 255. Signed-off-by: Luciano Coelho luciano.coe...@intel.com Reviewed-by: Johannes Berg johannes.b...@intel.com Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/net/wireless/iwlwifi/mvm/mac80211.c |3 --- 1 file changed, 3 deletions(-) --- a/drivers/net/wireless/iwlwifi/mvm/mac80211.c +++ b/drivers/net/wireless/iwlwifi/mvm/mac80211.c @@ -668,9 +668,6 @@ static void iwl_mvm_cleanup_iterator(voi mvmvif-uploaded = false; mvmvif-ap_sta_id = IWL_MVM_STATION_COUNT; - /* does this make sense at all? */ - mvmvif-color++; - spin_lock_bh(mvm-time_event_lock); iwl_mvm_te_clear_data(mvm, mvmvif-time_event_data); spin_unlock_bh(mvm-time_event_lock); -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
