RE: [PATCH 38/74] lto, watchdog/hpwdt.c: Make assembler label global
I am OK with the changes. We have a few more coming soon to improve the kdump process when hpwdt is running. Just a heads up. Thanks, Tom -Original Message- From: wi...@spo001.leaseweb.com [mailto:wi...@spo001.leaseweb.com] On Behalf Of Wim Van Sebroeck Sent: Wednesday, August 22, 2012 2:25 PM To: Andi Kleen Cc: linux-kernel@vger.kernel.org; x...@kernel.org; mma...@suse.cz; linux-kbu...@vger.kernel.org; jbeul...@suse.com; a...@linux-foundation.org; Andi Kleen; Mingarelli, Thomas Subject: Re: [PATCH 38/74] lto, watchdog/hpwdt.c: Make assembler label global Hi andi, > From: Andi Kleen > > We cannot assume that the inline assembler code always ends up > in the same file as the original C file. So make any assembler labels > that are called with "extern" by C global > > Cc: w...@iguana.be > Signed-off-by: Andi Kleen You have my signed-off-by, but I'm Cc-ing also the author of the driver (Tom Mingarelli) so that he is also aware of the proposed change. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 38/74] lto, watchdog/hpwdt.c: Make assembler label global
Hi andi, > From: Andi Kleen > > We cannot assume that the inline assembler code always ends up > in the same file as the original C file. So make any assembler labels > that are called with "extern" by C global > > Cc: w...@iguana.be > Signed-off-by: Andi Kleen You have my signed-off-by, but I'm Cc-ing also the author of the driver (Tom Mingarelli) so that he is also aware of the proposed change. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 38/74] lto, watchdog/hpwdt.c: Make assembler label global
Hi andi, From: Andi Kleen a...@linux.intel.com We cannot assume that the inline assembler code always ends up in the same file as the original C file. So make any assembler labels that are called with extern by C global Cc: w...@iguana.be Signed-off-by: Andi Kleen a...@linux.intel.com You have my signed-off-by, but I'm Cc-ing also the author of the driver (Tom Mingarelli) so that he is also aware of the proposed change. Kind regards, Wim. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 38/74] lto, watchdog/hpwdt.c: Make assembler label global
I am OK with the changes. We have a few more coming soon to improve the kdump process when hpwdt is running. Just a heads up. Thanks, Tom -Original Message- From: wi...@spo001.leaseweb.com [mailto:wi...@spo001.leaseweb.com] On Behalf Of Wim Van Sebroeck Sent: Wednesday, August 22, 2012 2:25 PM To: Andi Kleen Cc: linux-kernel@vger.kernel.org; x...@kernel.org; mma...@suse.cz; linux-kbu...@vger.kernel.org; jbeul...@suse.com; a...@linux-foundation.org; Andi Kleen; Mingarelli, Thomas Subject: Re: [PATCH 38/74] lto, watchdog/hpwdt.c: Make assembler label global Hi andi, From: Andi Kleen a...@linux.intel.com We cannot assume that the inline assembler code always ends up in the same file as the original C file. So make any assembler labels that are called with extern by C global Cc: w...@iguana.be Signed-off-by: Andi Kleen a...@linux.intel.com You have my signed-off-by, but I'm Cc-ing also the author of the driver (Tom Mingarelli) so that he is also aware of the proposed change. Kind regards, Wim. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 38/74] lto, watchdog/hpwdt.c: Make assembler label global
From: Andi Kleen
We cannot assume that the inline assembler code always ends up
in the same file as the original C file. So make any assembler labels
that are called with "extern" by C global
Cc: w...@iguana.be
Signed-off-by: Andi Kleen
---
drivers/watchdog/hpwdt.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index 1eff743..68bda60 100644
--- a/drivers/watchdog/hpwdt.c
+++ b/drivers/watchdog/hpwdt.c
@@ -161,7 +161,8 @@ extern asmlinkage void asminline_call(struct cmn_registers
*pi86Regs,
#define HPWDT_ARCH 32
asm(".text \n\t"
-".align 4 \n"
+".align 4 \n\t"
+".globl asminline_call \n"
"asminline_call:\n\t"
"pushl %ebp \n\t"
"movl%esp, %ebp \n\t"
@@ -351,7 +352,8 @@ static int __devinit detect_cru_service(void)
#define HPWDT_ARCH 64
asm(".text \n\t"
-".align 4 \n"
+".align 4 \n\t"
+".globl asminline_call \n"
"asminline_call:\n\t"
"pushq %rbp\n\t"
"movq %rsp, %rbp \n\t"
--
1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 38/74] lto, watchdog/hpwdt.c: Make assembler label global
From: Andi Kleen a...@linux.intel.com We cannot assume that the inline assembler code always ends up in the same file as the original C file. So make any assembler labels that are called with extern by C global Cc: w...@iguana.be Signed-off-by: Andi Kleen a...@linux.intel.com --- drivers/watchdog/hpwdt.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c index 1eff743..68bda60 100644 --- a/drivers/watchdog/hpwdt.c +++ b/drivers/watchdog/hpwdt.c @@ -161,7 +161,8 @@ extern asmlinkage void asminline_call(struct cmn_registers *pi86Regs, #define HPWDT_ARCH 32 asm(.text \n\t -.align 4 \n +.align 4 \n\t +.globl asminline_call \n asminline_call:\n\t pushl %ebp \n\t movl%esp, %ebp \n\t @@ -351,7 +352,8 @@ static int __devinit detect_cru_service(void) #define HPWDT_ARCH 64 asm(.text \n\t -.align 4 \n +.align 4 \n\t +.globl asminline_call \n asminline_call:\n\t pushq %rbp\n\t movq %rsp, %rbp \n\t -- 1.7.7.6 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
