Re: [PATCH 4/4] ASoC: wm2000: Improve a size determination in wm2000_i2c_probe()

2017-11-24 Thread Charles Keepax 
On Fri, Nov 24, 2017 at 08:40:22AM +0100, SF Markus Elfring wrote:
> From: Markus Elfring 
> Date: Fri, 24 Nov 2017 08:18:14 +0100
> 
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring 
> ---

Acked-by: Charles Keepax 

Thanks,
Charles

Re: [PATCH 4/4] ASoC: wm2000: Improve a size determination in wm2000_i2c_probe()

2017-11-24 Thread Charles Keepax 
On Fri, Nov 24, 2017 at 08:40:22AM +0100, SF Markus Elfring wrote:
> From: Markus Elfring 
> Date: Fri, 24 Nov 2017 08:18:14 +0100
> 
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring 
> ---

Acked-by: Charles Keepax 

Thanks,
Charles

[PATCH 4/4] ASoC: wm2000: Improve a size determination in wm2000_i2c_probe()

2017-11-23 Thread SF Markus Elfring 
From: Markus Elfring 
Date: Fri, 24 Nov 2017 08:18:14 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
---
 sound/soc/codecs/wm2000.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/soc/codecs/wm2000.c b/sound/soc/codecs/wm2000.c
index 2151e75ee5c6..86e7f9ebab44 100644
--- a/sound/soc/codecs/wm2000.c
+++ b/sound/soc/codecs/wm2000.c
@@ -826,8 +826,7 @@ static int wm2000_i2c_probe(struct i2c_client *i2c,
int reg;
u16 id;
 
-   wm2000 = devm_kzalloc(>dev, sizeof(struct wm2000_priv),
- GFP_KERNEL);
+   wm2000 = devm_kzalloc(>dev, sizeof(*wm2000), GFP_KERNEL);
if (!wm2000)
return -ENOMEM;
 
-- 
2.15.0

[PATCH 4/4] ASoC: wm2000: Improve a size determination in wm2000_i2c_probe()

2017-11-23 Thread SF Markus Elfring 
From: Markus Elfring 
Date: Fri, 24 Nov 2017 08:18:14 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
---
 sound/soc/codecs/wm2000.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/soc/codecs/wm2000.c b/sound/soc/codecs/wm2000.c
index 2151e75ee5c6..86e7f9ebab44 100644
--- a/sound/soc/codecs/wm2000.c
+++ b/sound/soc/codecs/wm2000.c
@@ -826,8 +826,7 @@ static int wm2000_i2c_probe(struct i2c_client *i2c,
int reg;
u16 id;
 
-   wm2000 = devm_kzalloc(>dev, sizeof(struct wm2000_priv),
- GFP_KERNEL);
+   wm2000 = devm_kzalloc(>dev, sizeof(*wm2000), GFP_KERNEL);
if (!wm2000)
return -ENOMEM;
 
-- 
2.15.0