Re: [PATCH 4/4] staging: rtl8188eu: rtw_debug.h

2014-08-30 Thread Miguel Oliveira
>
> How does this change relate to what you said you were going to do above?
>
> confused,
>
That was a fix for a sparse warning that went on this patch acidenttly.
Sorry about that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 4/4] staging: rtl8188eu: rtw_debug.h

2014-08-30 Thread Greg KH
On Fri, Aug 22, 2014 at 11:33:52AM +0100, Miguel Oliveira wrote:
> Convert all rtw_proc_xxx references to rtw_sys_xxx in file
> include/rtw_debug.h

That's interesting, but:

> 
> Signed-off-by: Miguel Oliveira 
> ---
>  drivers/staging/rtl8188eu/include/rtw_debug.h |  227 
> +++--
>  1 file changed, 98 insertions(+), 129 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/include/rtw_debug.h 
> b/drivers/staging/rtl8188eu/include/rtw_debug.h
> index a38616e..aa0f46a 100644
> --- a/drivers/staging/rtl8188eu/include/rtw_debug.h
> +++ b/drivers/staging/rtl8188eu/include/rtw_debug.h
> @@ -87,7 +87,7 @@ extern u32 GlobalDebugLevel;
>  #define MSG_88E(...) \
>   do {\
>   if (_drv_err_ <= GlobalDebugLevel)  \
> - pr_info(DRIVER_PREFIX __VA_ARGS__); 
> \
> + pr_info(DRIVER_PREFIX __VA_ARGS__); \

How does this change relate to what you said you were going to do above?

confused,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 4/4] staging: rtl8188eu: rtw_debug.h

2014-08-30 Thread Greg KH
On Fri, Aug 22, 2014 at 11:33:52AM +0100, Miguel Oliveira wrote:
 Convert all rtw_proc_xxx references to rtw_sys_xxx in file
 include/rtw_debug.h

That's interesting, but:

 
 Signed-off-by: Miguel Oliveira cmro...@gmail.com
 ---
  drivers/staging/rtl8188eu/include/rtw_debug.h |  227 
 +++--
  1 file changed, 98 insertions(+), 129 deletions(-)
 
 diff --git a/drivers/staging/rtl8188eu/include/rtw_debug.h 
 b/drivers/staging/rtl8188eu/include/rtw_debug.h
 index a38616e..aa0f46a 100644
 --- a/drivers/staging/rtl8188eu/include/rtw_debug.h
 +++ b/drivers/staging/rtl8188eu/include/rtw_debug.h
 @@ -87,7 +87,7 @@ extern u32 GlobalDebugLevel;
  #define MSG_88E(...) \
   do {\
   if (_drv_err_ = GlobalDebugLevel)  \
 - pr_info(DRIVER_PREFIX __VA_ARGS__); 
 \
 + pr_info(DRIVER_PREFIX __VA_ARGS__); \

How does this change relate to what you said you were going to do above?

confused,

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 4/4] staging: rtl8188eu: rtw_debug.h

2014-08-30 Thread Miguel Oliveira

 How does this change relate to what you said you were going to do above?

 confused,

That was a fix for a sparse warning that went on this patch acidenttly.
Sorry about that.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 4/4] staging: rtl8188eu: rtw_debug.h

2014-08-22 Thread Miguel Oliveira
Convert all rtw_proc_xxx references to rtw_sys_xxx in file
include/rtw_debug.h

Signed-off-by: Miguel Oliveira 
---
 drivers/staging/rtl8188eu/include/rtw_debug.h |  227 +++--
 1 file changed, 98 insertions(+), 129 deletions(-)

diff --git a/drivers/staging/rtl8188eu/include/rtw_debug.h 
b/drivers/staging/rtl8188eu/include/rtw_debug.h
index a38616e..aa0f46a 100644
--- a/drivers/staging/rtl8188eu/include/rtw_debug.h
+++ b/drivers/staging/rtl8188eu/include/rtw_debug.h
@@ -87,7 +87,7 @@ extern u32 GlobalDebugLevel;
 #define MSG_88E(...)   \
do {\
if (_drv_err_ <= GlobalDebugLevel)  \
-   pr_info(DRIVER_PREFIX __VA_ARGS__); 
\
+   pr_info(DRIVER_PREFIX __VA_ARGS__); \
} while (0)
 
 #define RT_TRACE(_comp, _level, fmt)   \
@@ -106,7 +106,7 @@ extern u32 GlobalDebugLevel;
u8  *ptr = (u8 *)_hexdata;  \
pr_info("%s", DRIVER_PREFIX);   \
pr_info(_titlestring);  \
-   for (__i = 0; __i < (int)_hexdatalen; __i++ ) { \
+   for (__i = 0; __i < (int)_hexdatalen; __i++) {  \
pr_info("%02X%s", ptr[__i], \
 (((__i + 1) % 4) == 0) ?   \
 "  " : " ");   \
@@ -117,150 +117,119 @@ extern u32 GlobalDebugLevel;
}   \
} while (0)
 
-int proc_get_drv_version(char *page, char **start,
-off_t offset, int count,
-int *eof, void *data);
-
-int proc_get_write_reg(char *page, char **start,
-  off_t offset, int count,
-  int *eof, void *data);
-
-int proc_set_write_reg(struct file *file, const char __user *buffer,
-  unsigned long count, void *data);
-int proc_get_read_reg(char *page, char **start,
- off_t offset, int count,
- int *eof, void *data);
-
-int proc_set_read_reg(struct file *file, const char __user *buffer,
- unsigned long count, void *data);
-
-int proc_get_fwstate(char *page, char **start,
-off_t offset, int count,
-int *eof, void *data);
-int proc_get_sec_info(char *page, char **start,
- off_t offset, int count,
- int *eof, void *data);
-int proc_get_mlmext_state(char *page, char **start,
- off_t offset, int count,
- int *eof, void *data);
-
-int proc_get_qos_option(char *page, char **start,
-   off_t offset, int count,
-   int *eof, void *data);
-int proc_get_ht_option(char *page, char **start,
-  off_t offset, int count,
-  int *eof, void *data);
-int proc_get_rf_info(char *page, char **start,
-off_t offset, int count,
-int *eof, void *data);
-int proc_get_ap_info(char *page, char **start,
-off_t offset, int count,
-int *eof, void *data);
-
-int proc_get_adapter_state(char *page, char **start,
-  off_t offset, int count,
-  int *eof, void *data);
-
-int proc_get_trx_info(char *page, char **start,
- off_t offset, int count,
- int *eof, void *data);
-
-int proc_get_mac_reg_dump1(char *page, char **start,
-  off_t offset, int count,
-  int *eof, void *data);
-
-int proc_get_mac_reg_dump2(char *page, char **start,
-  off_t offset, int count,
-  int *eof, void *data);
-
-int proc_get_mac_reg_dump3(char *page, char **start,
-  off_t offset, int count,
-  int *eof, void *data);
-
-int proc_get_bb_reg_dump1(char *page, char **start,
- off_t offset, int count,
- int *eof, void *data);
-
-int proc_get_bb_reg_dump2(char *page, char **start,
- off_t offset, int count,
- int *eof, void *data);
-
-int proc_get_bb_reg_dump3(char *page, char **start,
- off_t offset, int count,
- int *eof, void *data);
-
-int proc_get_rf_reg_dump1(char *page, char **start,
- off_t offset, int count,
- int *eof, void *data);
-
-int proc_get_rf_reg_dump2(char *page, char **start,
- off_t offset, int count,
-  

[PATCH 4/4] staging: rtl8188eu: rtw_debug.h

2014-08-22 Thread Miguel Oliveira
Convert all rtw_proc_xxx references to rtw_sys_xxx in file
include/rtw_debug.h

Signed-off-by: Miguel Oliveira cmro...@gmail.com
---
 drivers/staging/rtl8188eu/include/rtw_debug.h |  227 +++--
 1 file changed, 98 insertions(+), 129 deletions(-)

diff --git a/drivers/staging/rtl8188eu/include/rtw_debug.h 
b/drivers/staging/rtl8188eu/include/rtw_debug.h
index a38616e..aa0f46a 100644
--- a/drivers/staging/rtl8188eu/include/rtw_debug.h
+++ b/drivers/staging/rtl8188eu/include/rtw_debug.h
@@ -87,7 +87,7 @@ extern u32 GlobalDebugLevel;
 #define MSG_88E(...)   \
do {\
if (_drv_err_ = GlobalDebugLevel)  \
-   pr_info(DRIVER_PREFIX __VA_ARGS__); 
\
+   pr_info(DRIVER_PREFIX __VA_ARGS__); \
} while (0)
 
 #define RT_TRACE(_comp, _level, fmt)   \
@@ -106,7 +106,7 @@ extern u32 GlobalDebugLevel;
u8  *ptr = (u8 *)_hexdata;  \
pr_info(%s, DRIVER_PREFIX);   \
pr_info(_titlestring);  \
-   for (__i = 0; __i  (int)_hexdatalen; __i++ ) { \
+   for (__i = 0; __i  (int)_hexdatalen; __i++) {  \
pr_info(%02X%s, ptr[__i], \
 (((__i + 1) % 4) == 0) ?   \
:  );   \
@@ -117,150 +117,119 @@ extern u32 GlobalDebugLevel;
}   \
} while (0)
 
-int proc_get_drv_version(char *page, char **start,
-off_t offset, int count,
-int *eof, void *data);
-
-int proc_get_write_reg(char *page, char **start,
-  off_t offset, int count,
-  int *eof, void *data);
-
-int proc_set_write_reg(struct file *file, const char __user *buffer,
-  unsigned long count, void *data);
-int proc_get_read_reg(char *page, char **start,
- off_t offset, int count,
- int *eof, void *data);
-
-int proc_set_read_reg(struct file *file, const char __user *buffer,
- unsigned long count, void *data);
-
-int proc_get_fwstate(char *page, char **start,
-off_t offset, int count,
-int *eof, void *data);
-int proc_get_sec_info(char *page, char **start,
- off_t offset, int count,
- int *eof, void *data);
-int proc_get_mlmext_state(char *page, char **start,
- off_t offset, int count,
- int *eof, void *data);
-
-int proc_get_qos_option(char *page, char **start,
-   off_t offset, int count,
-   int *eof, void *data);
-int proc_get_ht_option(char *page, char **start,
-  off_t offset, int count,
-  int *eof, void *data);
-int proc_get_rf_info(char *page, char **start,
-off_t offset, int count,
-int *eof, void *data);
-int proc_get_ap_info(char *page, char **start,
-off_t offset, int count,
-int *eof, void *data);
-
-int proc_get_adapter_state(char *page, char **start,
-  off_t offset, int count,
-  int *eof, void *data);
-
-int proc_get_trx_info(char *page, char **start,
- off_t offset, int count,
- int *eof, void *data);
-
-int proc_get_mac_reg_dump1(char *page, char **start,
-  off_t offset, int count,
-  int *eof, void *data);
-
-int proc_get_mac_reg_dump2(char *page, char **start,
-  off_t offset, int count,
-  int *eof, void *data);
-
-int proc_get_mac_reg_dump3(char *page, char **start,
-  off_t offset, int count,
-  int *eof, void *data);
-
-int proc_get_bb_reg_dump1(char *page, char **start,
- off_t offset, int count,
- int *eof, void *data);
-
-int proc_get_bb_reg_dump2(char *page, char **start,
- off_t offset, int count,
- int *eof, void *data);
-
-int proc_get_bb_reg_dump3(char *page, char **start,
- off_t offset, int count,
- int *eof, void *data);
-
-int proc_get_rf_reg_dump1(char *page, char **start,
- off_t offset, int count,
- int *eof, void *data);
-
-int proc_get_rf_reg_dump2(char *page, char **start,
- off_t offset, int count,
-