Re: [PATCH 4/6] SPEAr: clk: pr_err() strings should end with newlines
On 11/24, Arvind Yadav wrote: > pr_err() messages should end with a new-line to avoid other messages > being concatenated. > > Signed-off-by: Arvind Yadav> --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH 4/6] SPEAr: clk: pr_err() strings should end with newlines
On 11/24, Arvind Yadav wrote: > pr_err() messages should end with a new-line to avoid other messages > being concatenated. > > Signed-off-by: Arvind Yadav > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
Re: [PATCH 4/6] SPEAr: clk: pr_err() strings should end with newlines
On 24-11-17, 12:25, Arvind Yadav wrote: > pr_err() messages should end with a new-line to avoid other messages > being concatenated. > > Signed-off-by: Arvind Yadav> --- > drivers/clk/spear/clk-gpt-synth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/spear/clk-gpt-synth.c > b/drivers/clk/spear/clk-gpt-synth.c > index 1a722e9..1cf219a6 100644 > --- a/drivers/clk/spear/clk-gpt-synth.c > +++ b/drivers/clk/spear/clk-gpt-synth.c > @@ -120,7 +120,7 @@ struct clk *clk_register_gpt(const char *name, const char > *parent_name, unsigned > struct clk *clk; > > if (!name || !parent_name || !reg || !rtbl || !rtbl_cnt) { > - pr_err("Invalid arguments passed"); > + pr_err("Invalid arguments passed\n"); > return ERR_PTR(-EINVAL); > } Acked-by: Viresh Kumar -- viresh
Re: [PATCH 4/6] SPEAr: clk: pr_err() strings should end with newlines
On 24-11-17, 12:25, Arvind Yadav wrote: > pr_err() messages should end with a new-line to avoid other messages > being concatenated. > > Signed-off-by: Arvind Yadav > --- > drivers/clk/spear/clk-gpt-synth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/spear/clk-gpt-synth.c > b/drivers/clk/spear/clk-gpt-synth.c > index 1a722e9..1cf219a6 100644 > --- a/drivers/clk/spear/clk-gpt-synth.c > +++ b/drivers/clk/spear/clk-gpt-synth.c > @@ -120,7 +120,7 @@ struct clk *clk_register_gpt(const char *name, const char > *parent_name, unsigned > struct clk *clk; > > if (!name || !parent_name || !reg || !rtbl || !rtbl_cnt) { > - pr_err("Invalid arguments passed"); > + pr_err("Invalid arguments passed\n"); > return ERR_PTR(-EINVAL); > } Acked-by: Viresh Kumar -- viresh
[PATCH 4/6] SPEAr: clk: pr_err() strings should end with newlines
pr_err() messages should end with a new-line to avoid other messages being concatenated. Signed-off-by: Arvind Yadav--- drivers/clk/spear/clk-gpt-synth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/spear/clk-gpt-synth.c b/drivers/clk/spear/clk-gpt-synth.c index 1a722e9..1cf219a6 100644 --- a/drivers/clk/spear/clk-gpt-synth.c +++ b/drivers/clk/spear/clk-gpt-synth.c @@ -120,7 +120,7 @@ struct clk *clk_register_gpt(const char *name, const char *parent_name, unsigned struct clk *clk; if (!name || !parent_name || !reg || !rtbl || !rtbl_cnt) { - pr_err("Invalid arguments passed"); + pr_err("Invalid arguments passed\n"); return ERR_PTR(-EINVAL); } -- 1.9.1
[PATCH 4/6] SPEAr: clk: pr_err() strings should end with newlines
pr_err() messages should end with a new-line to avoid other messages being concatenated. Signed-off-by: Arvind Yadav --- drivers/clk/spear/clk-gpt-synth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/spear/clk-gpt-synth.c b/drivers/clk/spear/clk-gpt-synth.c index 1a722e9..1cf219a6 100644 --- a/drivers/clk/spear/clk-gpt-synth.c +++ b/drivers/clk/spear/clk-gpt-synth.c @@ -120,7 +120,7 @@ struct clk *clk_register_gpt(const char *name, const char *parent_name, unsigned struct clk *clk; if (!name || !parent_name || !reg || !rtbl || !rtbl_cnt) { - pr_err("Invalid arguments passed"); + pr_err("Invalid arguments passed\n"); return ERR_PTR(-EINVAL); } -- 1.9.1